Commit Graph

3549 Commits

Author SHA1 Message Date
Jason Williams
5cfc1f8ddd Merge pull request #5222 from rwjblue/guard-against-missing-element
Only attempt to `scrollTop` if element is available.
2015-05-05 20:23:57 -05:00
Robert Jackson
27e52c8979 Only attempt to scrollTop if element is available.
In later versions of Ember, the views and components can be stable
and are not guaranteed to be torn down before a new controller is
set on them.

In this case, the controller is initially set before the element has been
rendered to the DOM causing errors when invoking `closest` on undefined.
2015-05-05 19:05:36 -04:00
Jason Williams
cc7c5be75b Merge pull request #5220 from ErisDS/api-route-tweak
Remove unneeded code from API route
2015-05-05 15:07:21 -05:00
Jason Williams
d3498483ab Merge pull request #5221 from rwjblue/undefined-this-in-helpers
Replace gh-blog-url helper with a component.
2015-05-05 14:28:52 -05:00
Robert Jackson
b16284f1ed Replace gh-blog-url helper with a component.
Accessing `this` inside an `Ember.HTMLBars.makeBoundHelper` will not
always return the containing `view` object. Instead, use a component.
2015-05-05 14:40:18 -04:00
Austin Burdine
8ac168794e refactors the frontend controller
closes #5192
- combines homepage, author, tag routes into one function (with different hash params)
- provides some abstraction for channels
2015-05-05 07:35:08 -05:00
Hannah Wolfe
95a546171a Remove unneeded code from API route 2015-05-05 12:50:23 +01:00
Hannah Wolfe
3b286e4d00 Removing unused dependency 2015-05-04 23:26:24 +01:00
Hannah Wolfe
6244165841 Merge pull request #5208 from Artie18/master
Fixed issue with word count for non ASCII letters.
2015-05-03 18:23:33 +01:00
Artyom Fedenko
075c4fbf46 Added support for all letters in word-count (not only ASCII) and added xregexp bower module to a project 2015-05-02 22:56:33 +03:00
Hannah Wolfe
7fe63b260f Merge pull request #5103 from acburdine/passprotect
Password Protection
2015-05-02 15:14:00 +01:00
Matt Enlow
81e12a209a Merge pull request #5198 from ErisDS/bower-update
Updating bower dependencies
2015-05-01 22:00:57 +01:00
John O'Nolan
ed3d94e644 Merge pull request #5196 from PaulAdamDavis/minor-code-injection-fixes
Code injection syntax colour change
2015-05-01 15:50:14 +02:00
John O'Nolan
8e46b06c67 Update preview post link styling, add view post link 2015-05-01 12:19:25 +02:00
Austin Burdine
2865662ee5 added password protection
closes #4993
- brings password protection to the frontend of blogs
- adds testing for password protection
- upgrades bcrypt-js to 2.1.0
2015-04-30 23:44:43 -05:00
Hannah Wolfe
f089e1d544 Updating bower dependencies
- tying as many things to proper versions rather than repos as possible
- upgrading various packages, with the exception of anything to do with jQuery
- leaving normalize as-is due to previous issues
2015-04-30 22:43:31 +01:00
Jason Williams
dae66d00be Upgrade grunt-jscs to fix whitespace linting.
No issue.
- grunt-jscs@1.8.0
- Fix formatting
2015-04-30 16:14:19 -05:00
Matt Enlow
433956c102 Add post preview via uuid (/p/:uuid)
Refs #5097

- All drafts will show a preview link (this needs real css)
- Published posts will redirect
- prev/next post helpers only activate on published posts
- Powered by ~10 pints between the two of us (@ErisDS, @novaugust)
2015-04-30 11:57:37 +01:00
Paul Adam Davis
9377694bba Code injection syntax colour change
Closes #5179

- Overwrites the yellow code injection syntax highlighting (such as vendor prefixes in CSS) to be black, to match the rest of the property
- Adds rounded corners to the code injection CodeMorror wrapper to match its parents rounded corners (inherits the same value)
2015-04-28 16:35:14 +01:00
Jason Williams
5cfb2e701e Allow admin app to run when active theme missing
Closes #5155
- If the theme that has been set to active is missing, set
  a default express-hbs instance on the express app and allow
  middleware processing to continue so that the admin client can
  be accessed.
- Log a warning when this happens.
- Fix issue where frontend error page was not being rendered
  correctly.
2015-04-25 20:00:04 +00:00
Hannah Wolfe
1e6f6237e1 Merge pull request #5184 from lmoe/master
Added res.locals into the prePostsRender filter call
2015-04-24 17:05:40 +01:00
Wilhansen Li
d02bcbacc2 Provide secure post links if RSS accessed over SSL 2015-04-24 18:20:38 +08:00
lmoe
03dcb71b08 Added res.locals into the prePostsRender filter call
closes #2559

 - Added res.locals as a second parameter to the prePostsRender filter
call.
 - This allows accessing the relative url and makes it possible to
react to certain urls.
2015-04-22 23:22:31 +02:00
Hannah Wolfe
3d5fe130c2 Merge pull request #5181 from sebgie/issue#5178
Rename error.type to error.errorType
2015-04-22 22:00:08 +01:00
Sebastian Gierlinger
fdcb67d3cc Rename error.type to error.errorType
closes #5178
- renamed error.type to error.errorType
2015-04-22 22:29:45 +02:00
Hannah Wolfe
eb5eca6eda Don't pass helper options to API for next/prev
fixes #5177

- this combined with a change passing options through to toJSON results in a really flukey bug with next/prev
  where the name option from the helper clashes with a name option inside of toJSON
2015-04-22 20:24:22 +01:00
Hannah Wolfe
32125c2f46 Filter options passed to toJSON
fixes #5177

- we now pass API/model options directly to toJSON, which is unsafe as these options haven't always been filtered before they are passed.
- this fix adds a filter so that toJSON only uses the options it needs
- additionally, rename the 'name' option to something more specific to prevent clashes
2015-04-22 20:20:27 +01:00
Matt Enlow
fc142b3dff Merge pull request #5161 from ErisDS/test-coverage
Switch test coverage to use Istanbul
2015-04-21 19:14:35 +02:00
Sebastian Gierlinger
2ed6daee10 Merge pull request #5159 from ErisDS/author-email
Refactor to remove author.email from API
2015-04-21 12:12:31 +02:00
Matt Enlow
0ed5d51f11 Merge pull request #5143 from ErisDS/issue-5136
Avoid infinite transition loop
2015-04-21 07:48:00 +02:00
Hannah Wolfe
6d04ead9f2 Switch test coverage to use Istanbul
closes #4644

- Switch from using blanket to istanbul
- Rename some test files for consistency (and so that they will run)
2015-04-19 15:54:05 +01:00
Hannah Wolfe
e26e83d40a Refactor to remove author.email from API
refs #2330

- Pass through `options` to all toJSON calls on posts, tags, and users
- Use options.context.user to determine whether it's OK to return user.email
- Remove author.email handling code from frontend.js
2015-04-17 22:27:04 +01:00
Hannah Wolfe
ede50f38a3 Merge pull request #5149 from cobbspur/headfix
Fix ghost_head helper on error pages
2015-04-16 20:22:50 +01:00
Hannah Wolfe
b4b5e2a3f5 Avoid infinite transition loop
fixes #5136

- wrap notification fetch with a user role check to remove console error
- move author transition down to local route for users/user so that there's no infinite loop
- replace all store calls to fetch the current user with the session user instead
2015-04-16 20:05:30 +01:00
cobbspur
a48458b73d Fix ghost_head helper on error pages
closes #5146

 - Checks for context key before assigning it to variable
2015-04-16 18:40:17 +01:00
Sebastian Gierlinger
a11822c80d Merge pull request #5144 from ErisDS/cache-update
Cache invalidation can no longer be so clever
2015-04-16 17:38:29 +02:00
Paul Adam Davis
9ea2f5535e Show correct type in publish button
Closes #5138

Shows the correct type (post or page)  in the publish button
2015-04-15 11:13:38 +01:00
Hannah Wolfe
1b585f213c Cache invalidation can no longer be so clever
no issue

With the introduction of the prev/next helpers (and soon, get helper) we can no longer make any assumptions
about exactly which pages need to be cleared from the cache when a post is published/unpublished.
2015-04-14 16:34:34 +01:00
Sebastian Gierlinger
030481671a Merge pull request #5128 from ErisDS/rss-refactor
RSS Refactor with cache
2015-04-13 03:54:50 -05:00
Hannah Wolfe
5f0d98a110 Don't do autosave on new post
closes #5130

- rather than checking for a model change, noop autosave on new controller
2015-04-11 17:42:44 +01:00
Hannah Wolfe
8d1e729f30 RSS Refactor with cache
refs #5091, refs #2263

- Move rss handling out of the frontend controller and into its own module
- Separate the code into logical blocks
- Wrap the generation code in a in-memory cache to prevent it being regenerated on every request
2015-04-10 21:32:14 +01:00
Sebastian Gierlinger
8f5960e1c5 Merge pull request #5108 from ErisDS/rss-2
Add media:content support to RSS
2015-04-10 12:49:51 -05:00
Hannah Wolfe
0b1497a75b No more feature flag for Code Injection
closes #1993

- remove the feature/config flag that means code injection has to be enabled
2015-04-09 17:52:41 +01:00
Hannah Wolfe
e19573f5d5 Merge pull request #5122 from JohnONolan/settings-cleanup
Cleaned up some derpy settings padding and widths
2015-04-09 16:17:43 +01:00
John O'Nolan
8205e59810 Merge pull request #5075 from PaulAdamDavis/top-notifications
Re-implement top notification position styles
2015-04-09 17:52:12 +03:00
Hannah Wolfe
d1de0800ad Merge pull request #5121 from novaugust/pagination_controller_mixin_fix_#5120
Fix typofail in pagination-controller mixin
2015-04-09 15:36:42 +01:00
Matt Enlow
920856c479 Merge pull request #5109 from ErisDS/issue-5064
Remove duplicate subdirectory in RSS urls
2015-04-09 08:35:25 -06:00
John O'Nolan
c6fb8a873a Add labs description 2015-04-09 16:14:50 +02:00
John O'Nolan
6eed16a115 Cleaned up some derpy settings padding and widths 2015-04-09 15:59:17 +02:00
Matt Enlow
91d57c2f30 Fix typofail in pagination-controller mixin
Closes #5120
2015-04-09 07:56:08 -06:00