TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-22 18:31:57 +03:00
Code Issues Projects Releases Wiki Activity
9,001 Commits 250 Branches 1,686 Tags 392 MiB
d7238e94c2
Commit Graph

6562 Commits

Author SHA1 Message Date
Fabien O'Carroll
d7238e94c2
🐛 Supported "false" as absolute attribute value (#10556) 
no-issue

* Added breaking test
* 🐛 Supported "false" as absolute attribute value

refs https://github.com/TryGhost/docs-api/pull/29
 2019-03-04 11:23:42 +01:00
Vikas Potluri
42c472feff Removed superagent dependency (#10535) 
no issue

- Migrated default scheduling adapter to use Got via the request proxy
- SchedulingDefault is the only module that was using superagent so removed it as a dependency
 2019-03-04 15:59:38 +08:00
Nazar Gargol
01b03f7a1a 🐛 Fixed returning 'null' text for exerpt helper 
refs #10554

- Fixes a flow described in https://github.com/TryGhost/Ghost/issues/10554#issuecomment-469127056
 2019-03-04 14:39:20 +08:00
kirrg001
a180d4e103 Updated TODO's 
no issue
 2019-02-27 18:08:36 +01:00
kirrg001
f8d1e38290 🐛 Fixed empty amp page 
closes #10547

- TODO: raise issue
 2019-02-27 17:56:09 +01:00
kirrg001
f33dacaf64 🐛 Fixed {{url}} output when using {{#next_post}}/{{#prev_post}} 
closes #10546

- TODO: raise issue
 2019-02-27 17:50:51 +01:00
kirrg001
7041efd295 Updated Ghost-Admin to 2.16.2 2019-02-27 10:06:48 +01:00
kirrg001
cf85cf56a5 Updated Ghost-Admin to 2.16.1 2019-02-26 12:15:53 +01:00
kirrg001
5474a81f60 Updated Ghost-Admin to 2.16.0 2019-02-26 10:29:47 +01:00
Rish
d62feca270 Added members permission migrations 
no issue

- Added new fixtures for member permissions for Admin
 2019-02-26 15:43:36 +07:00
Rish
20a898a986 Refactored members auth flow with dynamic settings 
no issue

- Updated members auth flow UI
- Updated members settings and routing to be dynamic
 2019-02-26 15:43:36 +07:00
kirrg001
90aef4f6c9 Stripped "excerpt" and "plaintext" from API v2 schema 
no issue

- exceprt -> virtual field
- plaintext -> generated field
 2019-02-26 09:07:14 +01:00
kirrg001
5a52336791 Used correct posts controller name for Content API v2 
no issue
 2019-02-26 08:33:10 +01:00
kirrg001
38e93c19b5 Reverted & Solved apiType differently 
no issue

- was unable to revert 9dd7aff9c6, because it contains members changes
- functional calls did not work correctly, because the content and admin ctrl differentiation happend in the web layer
- `isContentAPI` returned true for `api.v2.settings.edit(data, {context: {internal:true{})`
- content & admin API are using different controllers
- we can just tell which ctrl is content API and which is not
- the direction fits for the content & admin API split
 2019-02-26 08:33:10 +01:00
kirrg001
46d7a5666e Renamed authors ctrl to authors-public 
no issue

- consistency
 2019-02-26 08:33:10 +01:00
kirrg001
7a2398b7f2 Fixed error handling for API frame 
no issue

- throwing an object from a catch handler is not a good idea
- unexpected and broke functional call to API (always returned a 500, because API returned {err: err, method: ...}
 2019-02-26 08:33:10 +01:00
Nazar Gargol
3baf52fba9 Added 'property' field to errors returned from API 
refs #10438
 2019-02-26 13:41:13 +07:00
Hannah Wolfe
bd904cd8e1
Tags endpoint is experimental 
- hasn't been tested yet, soooooooon
 2019-02-26 12:52:58 +07:00
Rish
392bb412d2 Fixed broken static routes with members serverside rendering 
no issue

refs cc1f62438d
 2019-02-26 12:19:31 +07:00
Nazar Gargol
96e0e3fcaf Fixed unit tests 
no issue

- Fixed breaking test suites that were introduced with 4f9e687f62
 2019-02-26 12:18:06 +07:00
Rish
b010c1be7e Fixed broken routes with members serverside rendering 
no issue

refs cc1f62438d
 2019-02-26 11:59:50 +07:00
Nazar Gargol
897247978b Fixed regression tests for importer 
no issue

- Fixed breaking test suites that were introduced with 4f9e687f62
 2019-02-26 11:58:37 +07:00
Fabien O'Carroll
4e6a6a24ac Updated Admin API key auth to require kid in header (#10538) 
* Required kid be a header claim as according to spec

https://tools.ietf.org/html/rfc7515#section-4.1.4 (JWT is an extension of JWS)

* Updated error message for missing kid

* Fixed admin-api key unit tests

* Fixed regression and acceptance tests
 2019-02-26 11:03:47 +07:00
kirrg001
71951eabea Fixed webhook resource name for page events 
no issue

- posts & pages live in the same table, need to use the event name
 2019-02-25 23:51:23 +01:00
kirrg001
6c50dadb90 Fixed serialized webhook payload for deleted resources 
no issue

- serializer did not kick in correctly
 2019-02-25 23:35:52 +01:00
kirrg001
370f3bbcc0 Removed single author serializer from v2 
no issue
 2019-02-25 23:35:09 +01:00
kirrg001
2fd5964089 Fixed emitEvent in base model 
no issue

- the options were not correctly remembered
 2019-02-25 22:53:47 +01:00
Fabien O'Carroll
cc1f62438d
Added support for serverside rendering of members content (#10522) 
no-issue

- Added member auth middleware to siteApp
- Passed member as context in routing service
- set Cache-Control: private for member requests
- fucked up some tests
- Added member as global template variable
- Updated tokens to have expiry of subscription_period_end
 2019-02-25 17:03:27 +01:00
Nazar Gargol
4d15b25153 Fixed regression tests that had to do with new error format 
refs #10438
 2019-02-25 22:19:51 +07:00
kirrg001
d6872de0b2 Added "useGravatar" to config endpoint in Admin API v2 
no issue
 2019-02-25 15:39:47 +01:00
kirrg001
a1023f0b11 Renamed theme upload file field name 
no issue

- consistent with /images/upload/ endpoint
 2019-02-25 13:26:03 +01:00
kirrg001
3278e8df22 Returned prefix for site & config response 
no issue

- otherwise it's super inconsistent to our other responses
- we always expose the resource type first
 2019-02-25 13:24:19 +01:00
kirrg001
bd7da54ce3 Changed config endpoint for Admin API v2 
no issue

- re-designed config endpoint
- timezones.json should live in Ghost-SDK long-term
 2019-02-25 13:24:19 +01:00
kirrg001
f9974a91a9 Added public /site endpoint to Admin API v2 
no issue
 2019-02-25 13:24:19 +01:00
kirrg001
b5155e280e Returned tags & authors by default for Admin API v2 
no issue

- tags, authors, authors.roles by default
 2019-02-25 13:22:50 +01:00
kirrg001
28a222703b Added computed "excerpt" field to Admin API v2 
no issue
 2019-02-25 13:22:50 +01:00
kirrg001
e65a82833c Changed default format from html to mobiledoc for Admin API v2 
no issue

- Ghost-Admin needs mobiledoc only
- Ghost-Android needs mobiledoc only
- any other client can fetch other formats using the query param
 2019-02-25 13:22:50 +01:00
Nazar Gargol
f558b58c89 Combined /images* endpoints into /images/upload 
- refs #10438

- /images/upload now accepts all the image uploads and distinguishes their purpuse using new `purpose` form data field
 2019-02-25 19:15:16 +07:00
Kevin Ansfield
4f9e687f62 Updated mobiledoc renderer to insert begin/end HTML comments around cards 
no issue

We're creating tooling to convert HTML to Ghost flavoured mobiledoc, however we have cards that allow arbitrary content without a wrapper element which means that we're unable to do a 1:1 mapping of mobiledoc->html->mobiledoc. To work around this problem we now output HTML comments before/after the output of each card so that our converter can extract card content correctly when parsing HTML.

- added `createCard` method which wraps a card's `render()` method to add begin/end comments and updated all cards to use it
- only takes affect for newly added or re-saved posts/pages
 2019-02-25 18:05:01 +07:00
kirrg001
23d54803e6 Triggered webhooks with all content formats 
no issue

- it make sense to include as much as possible
- webhook consumers don't need to re-fetch resources if they need a specific format
 2019-02-25 09:46:50 +01:00
kirrg001
f3f3b62d19 Removed console.log 
no issue
 2019-02-25 09:43:32 +01:00
kirrg001
3459f38c09 Fixed webhook payload 
no issue

- async code was not handled
 2019-02-25 09:38:08 +01:00
kirrg001
23fed961e5 Removed requirement to provide authors for admin api keys 
no issue

- we just fallback to owner user
- reason: consistent with how the importer works, easier to work with the API
 2019-02-25 09:16:32 +01:00
Nazar Gargol
50ea7f0eff Added user friendly error messages to Admin API 
refs #10438

- Adds new fields to errors returned from API:  help, code, and id
- Makes `message` more descriptive towards non technical users
 2019-02-25 10:40:35 +07:00
Kevin Ansfield
792c2608c5 Added kg-card-hascaption class to image/gallery/embed cards with captions 
refs https://github.com/TryGhost/Ghost/issues/10445
- adds class to card renderers
- class will only be present on new or re-saved posts
 2019-02-25 10:15:14 +07:00
kirrg001
0665c72dda Removed primary_tag & primary_author if null from Admin API v2 
refs #10438

- "null" means the resource does not exist (it was sett to "null"), which is not true
- we won't serve primary_tag and primary_author by default
- TODO: add the same change to the Content API v2 (raise issue)
 2019-02-24 13:31:43 +01:00
kirrg001
377d7e4271 Removed serving primary_tag when members is enabled 
no issue

- Content API v2 served primary_tag by default if members flag is enabled
- reference: b2201d4179
- it's safe to remove, because members is behind the dev flag
 2019-02-24 11:54:04 +01:00
Nazar Gargol
9d4b0c09a8 Renamed uploads to images 
refs #10438

- As the support of /uploads endpoint has been dropped in Admin API, all related files have to correspond to new naming
 2019-02-24 11:18:45 +07:00
Nazar Gargol
73bb626cae Removed unused GhostErrors 
refs #10438
 2019-02-24 10:52:03 +07:00
kirrg001
48bd7a094c Stripped virtual fields from Admin API v2: primary_tagg & primary_author 
refs #10438

- you cannot add or update these fields
- these are virtual fields
 2019-02-23 22:58:57 +01:00