4 Commits

Author	SHA1	Message	Date
Hannah Wolfe	b6e9eadef9	Fixed overly specific assertion ... - Asserting for the exact error message thrown was a bad idea as it is different between different versions of Node... derp - Also, don't really care, I'm just asserting that the serialize function errors under certain conditions	2022-05-03 11:59:50 +01:00
Hannah Wolfe	d01c1cba64	Fixed undefined error when serializing webhooks ... closes: https://github.com/TryGhost/Toolbox/issues/318 refs: https://github.com/TryGhost/Toolbox/issues/320 refs: 2a11d5100e - The underlying problem was caused by the removal of API versions - commit 2a11d5100e - I missed doing the same refactor as was done for the post-emailserializer here: 2a11d5100e (diff-0f7477bb5e5a9fdcb4c909a9e9e61ab5bb76b640b2d63a5791a9d6c8904f2758R7) - The removal of api versions included a change to remove circular references in the api module - Written some basic unit tests to prove that webhook serialization works - I'm not 100% happy with the output, and not sure if it's the tests or reality, needs further work - Future work tracked in https://github.com/TryGhost/Toolbox/issues/320	2022-05-03 11:40:59 +01:00
Naz	4dcb229b35	Removed models dependency from Webhook Service test ... no issue - There's no need to init whole models module in this test. Simplified mocks are easier to understand without any "magic" that's going on behind model's module "init()" call	2022-04-14 16:12:05 +08:00
Daniel Lockyer	1a3aa69c68	Re-throw error when attempting to create webhooks ... - we catch error arising from creating webhooks and check for specific codes - if our error does not match one of those codes, we don't propagate the error up - this becomes a problem if saving a webhook fails for some other reason because upstream code assumes we return an error or model - this commit re-throws the error and adds a test that would have caught this	2022-03-07 13:54:00 +00:00