Commit Graph

6062 Commits

Author SHA1 Message Date
Hannah Wolfe
d7b9eb6176 Fix facebook/twitter/schema description
refs #6534

- this is an initial fix for having no description at all unless a meta description is provided
- we may need to tweak the lengths / provide different lengths for different values in future
2016-02-18 12:11:46 +00:00
Kevin Ansfield
d7d3c681e8 Merge pull request #6536 from ErisDS/tpl
Adding GitHub issue & PR templates
2016-02-18 11:58:47 +00:00
Hannah Wolfe
e5afddfa61 Adding GitHub issue & PR templates 2016-02-18 09:50:09 +00:00
Kevin Ansfield
0daabbe02f Merge pull request #6513 from acburdine/issue-6512
Fix underscore usage in post serializer
2016-02-18 09:30:44 +00:00
Hannah Wolfe
cdbec7a8ba Merge pull request #6532 from jaswilli/issue-6491
Provide entire model to validator
2016-02-18 09:12:06 +00:00
Kevin Ansfield
b0f4a0391d Merge pull request #6533 from acburdine/issue-6483
Pass post tags as array to ember-cli-selectize
2016-02-18 09:08:09 +00:00
Kevin Ansfield
24e84ca531 Merge pull request #6531 from acburdine/issue-6530
Inject ajax service in settings/labs
2016-02-18 08:58:12 +00:00
Hannah Wolfe
71062a0026 Merge pull request #6517 from halfdan/fix-6516
Use req.path instead of req.url to check for file extension
2016-02-18 08:37:32 +00:00
Kevin Ansfield
dcf712643f Merge pull request #6524 from acburdine/signin-test
Add sign-in acceptance test
2016-02-18 08:31:03 +00:00
Hannah Wolfe
d1b56c23fe Merge pull request #6507 from cameronviner/6505
Clean up the after the shouldjs upgrade tests closes #6505
2016-02-18 07:44:23 +00:00
Austin Burdine
efff6f62ae pass post tags as array to ember-cli-selectize
closes #6483
- fix new post => settings/tags transition error
2016-02-17 22:24:16 -06:00
Jason Williams
b10da0569a Provide entire model to validator
Closes #6491
2016-02-17 17:30:16 -06:00
Austin Burdine
c1d962ac63 inject ajax service in settings/labs
closes #6530
- turns out one must inject a service in order to use it
2016-02-17 14:50:40 -06:00
Fabian Becker
f14910fa8e Use req.path instead of req.url to check for file extension
fixes #6516
2016-02-17 19:24:49 +01:00
Sebastian Gierlinger
2166c378ed Merge pull request #6527 from ErisDS/error-statusCode
Disambiguate between error code & status code
2016-02-17 18:41:33 +01:00
Hannah Wolfe
02199c6b02 Disambiguate between error code & status code
refs #6526

- Change our errors to use `statusCode` for the status code (like res.statusCode)
- Use statusCode for anything that's supposed to be the statusCode, rather than an error idenfier/code
- Update all the tests that check the key
- Route tests don't need fixing as the status codes are still returned correctly
2016-02-17 15:20:49 +00:00
Cameron Viner
8fd272476b Removed uneeded jshint comments in order to cleanup the tests
closes #6505
-Removed all of the /*jshint expr:true*/ comments from the tests
-Removed all of the should.equal(true, true) statements from the tests
-Removed should from the greenkeeper ignores
2016-02-17 12:52:43 +00:00
Austin Burdine
a13b899817 add signin acceptance test
refs #6039
2016-02-16 23:08:24 -06:00
Austin Burdine
1ed2a8b6a7 fix underscore usage in post serializer
closes #6512
- because of the keyForAttribute method in the application serializer, the hash property must be snake_case
- change the normalize method to the more concise normalizeHash method available on the rest serializer
2016-02-16 09:37:15 -06:00
Sebastian Gierlinger
39b326aa6d Merge pull request #6500 from ErisDS/remove-request
Refactor gravatarLookup, remove request dependency
2016-02-16 14:06:08 +01:00
Hannah Wolfe
c301510cd1 Refactor gravatarLookup, remove request dependency
no issue

- request is quite a heavy dependency
- we were only using request in 3 places: a test, storing contrib images in the gruntfile & the gravatar lookup
- all 3 are relatively simple to do with the http/https module
- refactored all 3, removed request
2016-02-16 11:12:01 +00:00
Sebastian Gierlinger
3c5c5ad9d0 Merge pull request #6469 from ErisDS/dynamic-channel-routing
Dynamic channel routing
2016-02-15 19:27:41 +01:00
Hannah Wolfe
13c1742eb9 Make frontend routing dynamic & driven by channels
refs #5091

- Move renderChannel to own file
- Update channel config to have get/list methods
- Move main routes to be generated based on the list of channels
- Move RSS routes to be subroutes of channels
- Move redirect301 to be a shared util
- Add full test coverage
- Split frontend route tests into frontend & channels
2016-02-15 15:57:20 +00:00
Kevin Ansfield
14a3f4411c Merge pull request #6486 from acburdine/code-injection-test
Add settings/code-injection acceptance test
2016-02-15 11:07:01 +00:00
Kevin Ansfield
777b0227fd Merge pull request #6488 from acburdine/labs-test
Add settings/labs acceptance test
2016-02-15 11:05:29 +00:00
Kevin Ansfield
1da47aa1c9 Merge pull request #6387 from novaugust/post-deletion
Fix post deletion scroll on content and tag screens
2016-02-15 11:02:42 +00:00
Kevin Ansfield
8ac61d0ed2 Merge pull request #6506 from acburdine/posts-error-fix
Improve 404 error handling in post route
2016-02-15 09:56:34 +00:00
Kevin Ansfield
d10773da1b Merge pull request #6508 from acburdine/patch-2
Remove unused modal outlet
2016-02-15 09:08:38 +00:00
Sebastian Gierlinger
fbd8ff7208 Merge pull request #6502 from ErisDS/mig-test
Migration related test improvements
2016-02-15 09:08:48 +01:00
Austin Burdine
53b92d4322 remove unused modal outlet 2016-02-14 18:55:59 -06:00
Austin Burdine
7e1941d45c improve 404 error handling in post route
closes #6503
- change post route 404 handling to match that of the editor and tag routes
- fix 404 tests
2016-02-14 16:49:57 -06:00
Hannah Wolfe
76934b44c1 Merge pull request #6499 from javorszky/iss_6493
Moves builFilesExist to startup-checks
2016-02-14 19:58:31 +00:00
Gabor Javorszky
7691b03d5a Moves builFilesExist to startup-checks
Fixes #6493

* moved function to startup checks
* flipped file system checks to sync versions
* exits on first sign of trouble
2016-02-14 18:28:37 +00:00
Hannah Wolfe
7c47249ac7 Merge pull request #6501 from cobbspur/backup
Backup database before deletion
2016-02-14 13:57:26 +00:00
Hannah Wolfe
17805767fd Merge pull request #6468 from kevinansfield/ember-sortable-nav-items
Replace jquery-ui.sortable with ember-sortable for nav items
2016-02-14 13:44:07 +00:00
Hannah Wolfe
54979049ee Migration related test improvements
refs #6301

- Don't hardcode the model fields in utils/api -> use the schema + modify the lists
   = We can now easily see what the differences between the schema and the API result are
- Don't hardcode the default DB version in the import/export tools
   = We don't have to update this every time we update the database version
2016-02-14 13:23:45 +00:00
cobbspur
8025325b15 Backup database before deletion
No issue

- a json object is now created when a user deletes content in labs
2016-02-14 09:04:53 +00:00
Sebastian Gierlinger
21c272b03f Merge pull request #6495 from ErisDS/db-config
Move db connection out of config
2016-02-13 13:25:35 +01:00
Hannah Wolfe
1c85650108 Move db connection out of config
refs #5047

- database connections are not configuration
2016-02-12 13:56:23 +00:00
Hannah Wolfe
d593425147 README: supported node version info update 2016-02-12 11:39:13 +00:00
Hannah Wolfe
893971cc51 Merge pull request #6490 from naoyak/node-4-semver
Support Node v4 LTS semver-minor releases
2016-02-12 11:28:21 +00:00
Sebastian Gierlinger
429223dc7f Merge pull request #6487 from ErisDS/app-fields
Don't include app fields
2016-02-11 23:08:35 +01:00
Sebastian Gierlinger
af91378643 Merge pull request #6489 from ErisDS/gql
deps: ghost-gql@0.0.4
2016-02-11 22:57:32 +01:00
Naoya Kanai
4834cb436d Support Node v4 LTS semver-minor releases
Fixes #6473
- Replace Node v4.2 with v4 in Travis config
- Replace ~4.2.0 with ^4.2.0 in engines to support semver-minor bumps in LTS line
2016-02-12 01:37:27 +09:00
Austin Burdine
970c3cfc7d add settings/labs acceptance test
refs #6039
2016-02-11 09:19:04 -06:00
Austin Burdine
330a74c8bd add settings/code-injection acceptance test
refs #6039
2016-02-11 09:05:48 -06:00
Hannah Wolfe
c3673be863 Don't include app fields
no issue

Including app fields along with tags & authors was a preoptimisation.
We don't use them yet, and having them results in database calls that are unnecessary.
2016-02-11 15:03:33 +00:00
Hannah Wolfe
ffa92ab913 deps: ghost-gql@0.0.4 2016-02-11 13:13:56 +00:00
Kevin Ansfield
76e9d88760 Merge pull request #6482 from acburdine/settings-general-test
Add settings/general acceptance test
2016-02-11 12:26:59 +00:00
Austin Burdine
c2a2af652c Add settings/general acceptance test
refs #6039
- adds acceptance tests for settings/general flows
- fixes up mirage settings fixtures
2016-02-11 06:06:38 -06:00