Commit Graph

1709 Commits

Author SHA1 Message Date
Robert Jackson
d8da21520f Remove ObjectController proxying behavior.
Ember.ObjectController (and Ember.ArrayController) will be deprecated in
Ember 1.11 (and removed from core in Ember 2.0). The reasoning is
detailed in the Ember 2.0 RFC.

This PR does the following:

* Updates templates/controllers/views to explicitly reference model
  properties (instead of relying on proxying behavior).
* Clearly delineate where certain properties are being set or retrieved
  from (for example it was not clear exactly where `scratch` and
  `titleScratch` were stored).
* Remove usage of `Ember.ObjectController`.
* Add JSCS rule to prevent future PR's from adding regressions.
2015-01-01 21:51:20 -05:00
Jason Williams
d15521ea12 Merge pull request #4742 from rwjblue/cleanup-posts-template
Cleanup posts template.
2015-01-01 10:13:45 -06:00
Robert Jackson
b99daa45bf Do not use static and {{bind-attr}} for the same attribute.
No issue.
2014-12-31 22:30:39 -05:00
Robert Jackson
b56c26c597 Cleanup posts template.
No issue.

* Fix indentation (it was surprisingly hard for me to grok what was happening
  without indentation).
* Utilize `alternateActive` from `core/client/utils/link-view.js` to
  maintain the `active` state. Observing `childViews` is deprecated (and
  may not work properly in future versions of Ember).
* Remove now unused `item-view`.
2014-12-31 21:06:05 -05:00
Robert Jackson
d2bb1dd613 Allow resolver to lookup gh-path helper. 2014-12-31 14:44:39 -05:00
Robert Jackson
ea95300385 Remove PostSettingsMenuView.
It seems that the properties this sets up (`datePlaceholder` and
`publishedAt`) are unused throughout the project.
2014-12-28 22:14:02 -05:00
Robert Jackson
69fac82fce Fix invalid HTML in templates.
HTMLBars (coming soon in Ember 1.10) validatest templates during
compilation. This PR fixes errors identified.
2014-12-28 18:01:05 -05:00
Jason Williams
51d7526466 Make embedded-relation-adapter the default
No Issue
- Generalize embedded-relation-adapter so it can be used for both fetching
  and saving records.
- Change Adapter inheritance hierarchy to
  RESTAdapter => BaseAdapter => EmbeddedRelationAdapter. ApplicationAdapter
  now extends EmbeddedRelationAdapter.
- Cleanup or remove adapters that existed just to extend directly
  from EmbeddedRelationAdapter.
2014-12-28 00:28:36 +00:00
Hannah Wolfe
e9f2b2a44a Merge pull request #4720 from jaswilli/modal-error
Use an explicit action name in action helper
2014-12-27 19:13:53 +00:00
Jason Williams
d86d0aabf1 Merge pull request #4666 from felixrieseberg/iss4651
Trigger Change Event before Login
2014-12-26 11:13:18 -06:00
Jason Williams
7e571a521f Use an explicit action name in action helper
No Issue
- Clicking on the body of a modal dialog causes an
  unhandled exception in the console.  Add an explicit
  action name to the helper.
2014-12-26 16:01:50 +00:00
Hannah Wolfe
d1ac65c855 Merge pull request #4708 from cobbspur/editors
Fixes navigation for Editors on small screen
2014-12-24 13:03:46 +00:00
John O'Nolan
5a9b8574a8 Fix settings back button implementation 2014-12-23 20:02:55 +00:00
Paul Davis
1f5c3b6970 Merge pull request #4711 from JohnONolan/fix-tagmgmt
Fix tag mgmt display bugs
2014-12-23 12:22:54 +00:00
John O'Nolan
0bc0a0e606 Fix tag mgmt display bugs
- Misaligned header due to back button being in the wrong place in the markup
- Corrected padding on tag delete button
- Updated tag settings input labels for consistency
2014-12-23 14:10:21 +02:00
Paul Adam Davis
118e25349f Fix modal edge spacing
No issue

The transparent border surrounding modals was being cut off.
This fix uses padding instead of adjusting the left & right valued to create space.
2014-12-23 12:05:18 +00:00
cobbspur
660f9fc4a1 Fixes navigation for Editors on small screen
closes #4707

- Changes Back-link on settings users page to content for editors
2014-12-23 10:35:49 +00:00
Hannah Wolfe
e90f10a6f1 Merge pull request #4699 from jaswilli/issue-4683
Finish tag post count UI.  Misc tag related fixes
2014-12-22 20:15:25 +00:00
cobbspur
e631ffb54f Fix back button on tag UI page
closes #4703

- previous link used absolute url which fails for subdirectories
2014-12-22 16:50:09 +00:00
Jason Williams
c922821c7a Finish tag post count UI. Misc tag related fixes
Issue #4683
- Finish setting up pagination in tag management page.
- Add post count warning to delete tag modal.  Fix styling.
- Make sure tag input menu is loading all tags.
- Only include saved tags in tag input suggestion list.
- Unload tag records from store when entering tag route so that
  we get accurate post count.
- Add a resetPagination action to pagination-controller-mixin for
  cases where we want to start fresh.
- Include tag.id when sending tag payload to API.
2014-12-22 02:17:18 +00:00
Jason Williams
c616cf5130 Merge pull request #4689 from ekulabuhov/4683_TagPostCountUI
Updated tag management UI with the post counts
2014-12-21 19:19:56 -06:00
Eugene Kulabuhov
52c5202885 Updated tag management UI with the post counts
closes #4683
- added post count to 'delete tag' modal
- fixed lint errors
- preventing extra data to be sent to server
- adjustments suggested by @jaswilli
2014-12-22 00:26:52 +00:00
Paul Adam Davis
ef02220cab Fix broken user list paginated scrolling
Closes #4695

- Adds a new class to the template and minor CSS to allow user list scroll events to work
2014-12-21 23:03:39 +00:00
Hannah Wolfe
c1380e29f2 Merge pull request #4546 from PaulAdamDavis/url-preview-comp
Add a URL preview componant
2014-12-20 15:26:59 +00:00
Paul Adam Davis
490c0f62b1 Add a URL preview componant
Closes #4499

- Introduces a URL preview component
- Added the component to tag settings and post settings
- Adds a new CSS file for this component which makes sure the preview never wraps onto multiple lines
2014-12-19 23:48:21 +00:00
Hannah Wolfe
596ef178ab Merge pull request #4674 from delgermurun/post-sort
Add 'id' to post sort fields. So there is no longer equally sorted posts.
2014-12-19 21:05:45 +00:00
Jason Williams
49e4bf3b77 Prevent error when closing modal dialog
No Issue
- Moved sendAction outside of the event handler as calling it
  from inside was generating an error in the console.
2014-12-18 23:10:25 +00:00
Hannah Wolfe
b3638316ce Merge pull request #4671 from jaswilli/ember-data-beta12
Update Ember-Data.
2014-12-18 16:45:00 +00:00
Hannah Wolfe
66166fc088 Merge pull request #4563 from felixrieseberg/iss4557
PSM: Reset 'Published Date'
2014-12-18 16:37:17 +00:00
Hannah Wolfe
f3362f81af Merge pull request #4643 from novaugust/settings-menu-mixin
Create settings-menu-mixin for subview state tracking
2014-12-18 16:34:39 +00:00
John O'Nolan
ae03f48cba Merge pull request #4647 from PaulAdamDavis/modal-css-ani
Use CSS animations for modals
2014-12-18 17:49:41 +02:00
Hannah Wolfe
b2c90bc098 Merge pull request #4665 from PaulAdamDavis/navigation-ui
Navigation UI Mockup
2014-12-18 10:28:34 +00:00
Delgermurun
8a9297e9c2 Add 'id' to post sort fields. So there is no longer equally sorted posts.
closes #4648
- Add id to order by fields on posts API
- Order by id on posts controller
2014-12-18 11:34:26 +08:00
Paul Adam Davis
048e241750 Navigation UI Mockup
Refs #4537

Static mockup of the navigation UI

- Includes hacky JS to simulate interactions (but not dragging, which is #4540 and no modal when deleting)
- Delete & add icons have invisible padding to increase hit area
- Drag handle has the `move` cursor
- Switches into a single column at 600px and below
2014-12-17 21:43:44 +00:00
Jason Williams
026366bc5c Update Ember-Data.
No Issue
- ember-data@beta.12
- ember-data now warns if a payload contains properties that do
  not exist in the model.  Because of this all missing model
  attributes have been added (without their relationship defined)
  because they're currently unused and we don't need to generate
  additional API requests to resolve the async relationships.
2014-12-17 20:34:25 +00:00
Hannah Wolfe
eb7118309b Merge pull request #4656 from felixrieseberg/iss4633
Tag Management: Delete Flow
2014-12-17 18:11:08 +00:00
Felix Rieseberg
8f6b23f3ab Tag Management: Delete Flow
Closes #4633
- The ‘delete’ button is now a smaller plain text link, opening a
confirmation modal analog to the delete user/post flow
- Adding a post count is dependent on #4654, but the modal is already a
neat step up from the immediate, warning-less deletion.
2014-12-17 08:38:14 -08:00
Hannah Wolfe
1d0945341d Merge pull request #4620 from jaswilli/ember19
Update to Ember 1.9.0.
2014-12-16 23:18:24 +00:00
Felix Rieseberg
812f80862c Trigger Change Event before Login
Ref #4651

- Manually triggering the change event ensures compatibility with
legacy password managers and browsers not properly firing events on
autofill (which leads to Ember not picking up the entered values)
2014-12-16 12:37:58 -08:00
Ilya Radchenko
9bf7ac03b1 Prevent publish-bar from floating up 2014-12-16 08:44:49 -05:00
Paul Adam Davis
3324c41857 Use CSS animations for modals
No issue

- Changes Modals to use CSS-based animations
- All modals have an animation, so the option is removed from the handlebars helper
- Removes `animation` from the handlebars helper, as all had one anyway
- Removed the `centered` style - All modals should be left-aligned
- Buttons now default to being on the left
- Cleans up some styles (modal body top spacing) which #4632 helped clean up
2014-12-15 18:23:42 +00:00
Hannah Wolfe
78dfdde2b0 Merge pull request #4653 from jaswilli/client-data
Do not include url and author_id in post payload.
2014-12-15 15:58:08 +00:00
Jason Williams
b5dbaaac69 Remove files for a modal that is no longer used.
Refs #4602
- The modal dialog that used to be shown when re-auth was
  needed in the editor has been replaced.
2014-12-15 15:29:35 +00:00
Jason Williams
496e92a515 Do not include url and author_id in post payload.
No Issue.
- Neither of these properties should be included in the
  payload sent from the client to the API.  URL is a
  read-only virtual property, and author_id is inserted
  locally as a convenience.
2014-12-15 15:07:04 +00:00
Jason Williams
5ac4bf1c3c Fixup behavior and styling of editor re-auth.
Closes #2092
- Adds styling for re-auth modal.
- Prevent transition to posts route on success.
- Clear credentials from controller.
- Handle confirmAccept action if form is submitted via 'enter'.
- Only allow re-auth as the user that was previously logged in.
2014-12-15 14:42:00 +00:00
Marco Otte-Witte
569c185de7 allow re-login when authorization fails on editor.edit route 2014-12-15 14:39:41 +00:00
Hannah Wolfe
7946926c93 Merge pull request #4629 from cobbspur/postpreview
Add view post link on published and updated posts
2014-12-15 13:28:47 +00:00
Hannah Wolfe
80325210e4 Merge pull request #4645 from katiefenn/issue-4356 2014-12-15 12:29:19 +00:00
Katie Fenn
48417d9b92 Fixed editor tag field handling of comma key on international keyboards
fixes #4356
- Added new keyPress event handler to identify keys by character instead of key
- Removed code for handling comma key from keyDown event handler
2014-12-15 12:27:35 +00:00
cobbspur
959a3a749d Add view post link on published and updated posts
closes #1756

- adds a post url link to 'post updated' and 'post published' in editor
- adds join function in ghost paths
- adds a '/' detection to makeRoute method
- adds test for join function
2014-12-15 12:18:47 +00:00