Commit Graph

280 Commits

Author SHA1 Message Date
Robert Jackson
d8da21520f Remove ObjectController proxying behavior.
Ember.ObjectController (and Ember.ArrayController) will be deprecated in
Ember 1.11 (and removed from core in Ember 2.0). The reasoning is
detailed in the Ember 2.0 RFC.

This PR does the following:

* Updates templates/controllers/views to explicitly reference model
  properties (instead of relying on proxying behavior).
* Clearly delineate where certain properties are being set or retrieved
  from (for example it was not clear exactly where `scratch` and
  `titleScratch` were stored).
* Remove usage of `Ember.ObjectController`.
* Add JSCS rule to prevent future PR's from adding regressions.
2015-01-01 21:51:20 -05:00
Jason Williams
d86d0aabf1 Merge pull request #4666 from felixrieseberg/iss4651
Trigger Change Event before Login
2014-12-26 11:13:18 -06:00
Jason Williams
c922821c7a Finish tag post count UI. Misc tag related fixes
Issue #4683
- Finish setting up pagination in tag management page.
- Add post count warning to delete tag modal.  Fix styling.
- Make sure tag input menu is loading all tags.
- Only include saved tags in tag input suggestion list.
- Unload tag records from store when entering tag route so that
  we get accurate post count.
- Add a resetPagination action to pagination-controller-mixin for
  cases where we want to start fresh.
- Include tag.id when sending tag payload to API.
2014-12-22 02:17:18 +00:00
Jason Williams
c616cf5130 Merge pull request #4689 from ekulabuhov/4683_TagPostCountUI
Updated tag management UI with the post counts
2014-12-21 19:19:56 -06:00
Eugene Kulabuhov
52c5202885 Updated tag management UI with the post counts
closes #4683
- added post count to 'delete tag' modal
- fixed lint errors
- preventing extra data to be sent to server
- adjustments suggested by @jaswilli
2014-12-22 00:26:52 +00:00
Hannah Wolfe
596ef178ab Merge pull request #4674 from delgermurun/post-sort
Add 'id' to post sort fields. So there is no longer equally sorted posts.
2014-12-19 21:05:45 +00:00
Hannah Wolfe
66166fc088 Merge pull request #4563 from felixrieseberg/iss4557
PSM: Reset 'Published Date'
2014-12-18 16:37:17 +00:00
Hannah Wolfe
f3362f81af Merge pull request #4643 from novaugust/settings-menu-mixin
Create settings-menu-mixin for subview state tracking
2014-12-18 16:34:39 +00:00
Delgermurun
8a9297e9c2 Add 'id' to post sort fields. So there is no longer equally sorted posts.
closes #4648
- Add id to order by fields on posts API
- Order by id on posts controller
2014-12-18 11:34:26 +08:00
Hannah Wolfe
eb7118309b Merge pull request #4656 from felixrieseberg/iss4633
Tag Management: Delete Flow
2014-12-17 18:11:08 +00:00
Felix Rieseberg
8f6b23f3ab Tag Management: Delete Flow
Closes #4633
- The ‘delete’ button is now a smaller plain text link, opening a
confirmation modal analog to the delete user/post flow
- Adding a post count is dependent on #4654, but the modal is already a
neat step up from the immediate, warning-less deletion.
2014-12-17 08:38:14 -08:00
Hannah Wolfe
1d0945341d Merge pull request #4620 from jaswilli/ember19
Update to Ember 1.9.0.
2014-12-16 23:18:24 +00:00
Felix Rieseberg
812f80862c Trigger Change Event before Login
Ref #4651

- Manually triggering the change event ensures compatibility with
legacy password managers and browsers not properly firing events on
autofill (which leads to Ember not picking up the entered values)
2014-12-16 12:37:58 -08:00
Jason Williams
b5dbaaac69 Remove files for a modal that is no longer used.
Refs #4602
- The modal dialog that used to be shown when re-auth was
  needed in the editor has been replaced.
2014-12-15 15:29:35 +00:00
Jason Williams
5ac4bf1c3c Fixup behavior and styling of editor re-auth.
Closes #2092
- Adds styling for re-auth modal.
- Prevent transition to posts route on success.
- Clear credentials from controller.
- Handle confirmAccept action if form is submitted via 'enter'.
- Only allow re-auth as the user that was previously logged in.
2014-12-15 14:42:00 +00:00
Marco Otte-Witte
569c185de7 allow re-login when authorization fails on editor.edit route 2014-12-15 14:39:41 +00:00
Matt Enlow
0d95ce4b8a Create settings-menu-mixin for subview state tracking
Ref #4642
- Move duplicate code from PSM and SettingsTags to a mixin
2014-12-13 20:37:36 -07:00
Hannah Wolfe
1518c41478 Merge pull request #4613 from felixrieseberg/iss4506-2
Tag Cover Images
2014-12-12 10:46:58 +00:00
Hannah Wolfe
143b579cb6 Merge pull request #4619 from jaswilli/issue-4583
Change user deletion warning to be more explicit.
2014-12-12 10:16:59 +00:00
Hannah Wolfe
1223e3237c Labs page bug fixes
- clear import errors on new attempt
- clear posts and tags from store after delete all
2014-12-11 19:53:56 +00:00
Felix Rieseberg
fd0e66a773 Tag Cover Images
Closes #4506

Works just like the Post Cover Images (and uses the same component)
Tiny changes to the component ensures that we can reuse it across Ghost
2014-12-10 17:48:18 -08:00
Paul Adam Davis
58b0eb701c Add Tag Meta View
Closes #4509, Closes #4615

- Adds meta title & meta description input fields
- Autosaves meta data
- Shows SEO preview (falling back to tag name & description if meta not supplied)
- Adds `type="button"` to delete button (which closes 4651)
2014-12-10 18:12:30 +00:00
Jason Williams
8968a60eb9 Update to Ember 1.9.0.
No Issue
- Ember@1.9.0
- Handlebars@2.0.0
- grunt-ember-templates@0.5.0-alpha
2014-12-10 16:24:20 +00:00
Jason Williams
90043cd28d Change user deletion warning to be more explicit.
Issue #4583
- If a user has posts, show the count in the deletion warning.
2014-12-10 01:44:36 +00:00
Matt Enlow
5cfebb3e50 Dry up tag saving behavior
Ref #4248
2014-12-09 07:38:32 -07:00
Hannah Wolfe
a7845cfd70 Code Injection - adds perms, shortcuts, icon, flag
refs #1993

- adds ctrl/cmd+s for save
- adds config flag
- adds icon on settings page, puts items in the right order
- sorts out permissions for all settings pages with consistent configuration
2014-12-04 13:34:44 +00:00
Stefan Baumgartner
895fe26bc9 adds code injection admin frontend implementation, handlebar helpers + settings
escaping handlebars
2014-12-04 04:16:08 +00:00
Matt Enlow
e66e012cae Merge pull request #4564 from Gargol/issue-4517
Tag Settings Menu Autosave
2014-12-03 14:29:42 -07:00
Nazar Gargol
a31902024b Tag Settings Menu Autosave
closes #4517

- adds autosave to name/slug/description fields in TMS
- adds nprogress indicator when saving
2014-12-03 19:15:59 +01:00
Felix Rieseberg
85677984d3 PSM: Reset 'Published Date'
Closes #4557
- The underlying issue is that the PSM is already loaded when Ember
routes from an existing post to a new post. Instead of resetting the
‘Published Date’ value manually (with jQuery), I’m using Ember’s
computed property setter to ‘refresh’ the cache for that property. I
believe that this Ember solution is better than manually going in and
resetting it with jQuery.
2014-12-01 11:57:47 -08:00
cobbspur
920e36f8e0 Move ugly debug to Settings Labs
closes #4534

- Adds new Labs route
- Wires route in settings page
- Move and rename debug templates and logic to labs
- Redirect /debug to settings/labs
2014-12-01 19:19:08 +00:00
Jason Williams
42d8e82c13 Prevent silent failures and recover after error.
Refs #4543
- Alway return model out of save handler so sub-classes which
  call this._super() on save have a model on success and failure.
- Always return resolved promise out of post slug generator.
- Test the errors object in the error notification helper to avoid
  throwing an unhandled exception and silently failing.
- Consider a post model "dirty" if it is in an error state.
2014-11-30 20:38:24 +00:00
Jason Williams
d196b87f1b Miscellaneous client cleanup
No issue
- Consolidate extension of Ember.Router.
- Remove unneeded local jshint flags and '_' as a global.
- Cleanup client README.md.
- Fix error message.
2014-11-29 02:42:08 +00:00
Hannah Wolfe
a1ab6b4a13 Merge pull request #4502 from felixrieseberg/iss4431
Ensure Post Image Uploader Reset
2014-11-25 19:07:32 +00:00
Felix Rieseberg
634a095711 Ensure Post Image Uploader Reset
Closes #4431

- The PSM does not reset on a transition from editor (existing post) to
editor (new post). If the existing post had a cover image, the image
uploader would not be reset during the transition and appear slightly
broken in the editor for the new post.
- In this PR: A reference to the uploader is saved, allowing the route
for editor/new to instruct the PSM controller to have the uploader
reset.
2014-11-24 09:43:17 -08:00
Matt Enlow
26268d7667 Tags management api hookup
Ref #4248
- Added tags settings menu
- Added basic new, edit, delete, and save actions
- Show actionable edit buttons dynamically based on tag state
- Infinite scroll
- Closing the tag settings menu rollbacks your changes
- Removed not-yet-implementable code
2014-11-21 16:24:28 -07:00
Jason Williams
0a23fa90ed Fix post tags input.
Closes #4378. Closes #4455.
- Trim whitespace from tag names on entry.
- Prevent duplicate tags in suggestion list.
- Fix unhandled exception that happens when backspace is pressed in
  an empty tags input box.
2014-11-15 04:45:36 +00:00
Felix Rieseberg
543cb4dac3 Reset slugValue when the user changes
Closes #4411
- Previously, saving the user’s slug would lead to the slug value being
‘stuck’ on that saved value, even if one navigated to a different
user’s profile settings.
2014-11-10 13:31:11 -08:00
Jason Williams
f86847171e Remove image related text from meta description.
Closes #4408
2014-11-07 05:22:34 +00:00
cobbspur
b04068d9b9 Create Tags Management Stubs for Ember
closes #4260

- Adds "tags" route inside of the settings routes.
- Adds this route to router.js
- Links the route from the settings.hbs template
- Adds demo tags html in tag.hbs template
- Adds flag for tagsUI
2014-11-04 15:50:41 +00:00
Jason Williams
c2e35f9a9b Update Ember to 1.8.0.
Closes #4316
- Ember@1.8.0.
- Ember-Data@1.0.0-beta.11.
- Change templates to use new Ember.Select syntax and other minor
  cleanup.
- Adjust functional tests.
2014-10-30 06:01:22 +00:00
Matt Enlow
9cff617899 Go between post list / post content with keyboard
Closes #3940
- Pushing left/right changes the "focus" of the posts screen to the list / content, respectively
- Once one of these has been focused, up/down keyboards work on that section in particular
- By default, the post list is selected
- Using the keyboard to focus one of the two makes it go "poof" to let you know you changed stuff
2014-10-27 09:41:13 -06:00
Jason Williams
395ff627c9 Fix up title/slug handling on posts.
Refs #4323
- Remove any titleScratch observers that may be hanging
  around on the post-settings-menu controller from previous posts.
- Change logic around when to regenerate slugs on posts that are
  "(Untitled)" so that slug generation continues after slug no
  longer resembles "untitled."
2014-10-25 23:35:50 +00:00
Jason Williams
0e9d4e6792 Enable JSCS checking on client.
Refs #4001
- grunt-jscs@0.8.1 which provides ES6 support.
2014-10-25 16:13:04 +00:00
Jason Williams
b4e3ac34cd Fix up PR #3491, remove lodash from admin
Refs #3491
2014-10-23 19:44:53 +00:00
Robert Jackson
936acdb693 Remove lodash from admin client.
* Adds `bind`, `isFinite`, and `isNumber` utility functions from lodash.
* Use new util funtions instead of lodash throughout the codebase.
* Remove lodash from vendor builds.
2014-10-23 18:27:09 +00:00
Jason Williams
6b09117861 Change slug and date placeholders to values
Closes #4121
2014-10-22 16:49:13 +00:00
Paul Adam Davis
20c11e563f Move unrelated editor cover code to the right place
Closes #4106

Moved the `.editor-close` styles to `post-settings-menu.scss`
2014-10-21 13:14:07 +01:00
Jason Williams
108622d4ed Ensure slug generation has completed prior to save
Refs #4307 Refs #4259
- Make sure that a slug has been generated prior to the first
  save that occurs on a post.
- Wait on in-flight slug generation requests before saving.
2014-10-20 19:15:01 +00:00
Hannah Wolfe
768e335735 More autosave improvements
issue #4305, issue #4259, issue #1413

- change new->edit transitionToRoute to be replaceRoute
- auto focus in the editor on transition to the edit route
- change the one-time autosave to happen on codemirror focusin instead of title focusout
- re-add removed tests, and reorder broken test
2014-10-18 17:27:05 +02:00