Commit Graph

2013 Commits

Author SHA1 Message Date
Lev Gimelfarb
a0ace7a324 Fixing 404 on page view when using PostgreSQL
closes #1801
- adding fixBools method to `server/models/base.js` to convert bools to 1/0 to be consistent with MySQL & sqlite3 data providers (based on @ErisDS recommendation)
- this in turn fixes the check in `server/controllers/frontend.js`, which does an explicit `post.page === 0` comparison (in pgsql this is a `boolean`, since the schema declares it as "bool" in `server/data/schema.js`, but MySQL/sqlite3 don't have concept of Boolean, only an integer or bit)
- any model retrieved from persistence will pass through this (possible future refactoring is to combine fixBools & fixDates into one "canonicalize()" to have a single loop pass)
2014-01-05 10:10:43 -05:00
Hannah Wolfe
b9a221a2be Merge pull request #1850 from hswolff/fix-throttle-behavior
Remove successful login connections from the auth throttle list
2014-01-05 05:03:03 -08:00
Hannah Wolfe
97d7b01463 Merge pull request #1848 from schneidmaster/fix-1846
Updated Casper to latest version
2014-01-05 02:33:29 -08:00
Harry Wolff
09b64c82df Remove successful login connections from the auth
throttle list

- once a user has successfully logged into ghost
they no longer are a malicious user and as such
their IP address should be removed from the
array of login attempts

- should also reduce the memory usage of Ghost
as the loginSecurity array gets pruned upon
every successful login

- this also fixes a race condition i was experiencing
during functional tests wherein i would receive
the login throttle message during regular testing.
Seems my machine is able to run casper fast enough
that it could complete each test under an amount
of time that tripped the login throttle message.
2014-01-04 21:52:54 -05:00
Zach Schneider
9f2b9c9824 Updated Casper to latest version
Fixes #1846
2014-01-04 17:18:47 -05:00
Hannah Wolfe
3937c1bf0e Merge pull request #1821 from schneidmaster/fix-1791
Modified github.js to ensure __ is not escaped at the beginning of a line
2014-01-04 11:13:37 -08:00
Hannah Wolfe
d51e63c7b7 Merge pull request #1840 from hswolff/fix-content-helper
Fix {{content words=“0”}} to actually return 0 words
2014-01-04 08:45:26 -08:00
Hannah Wolfe
9f17361bf5 Merge pull request #1831 from schneidmaster/fix-1827
Added handling for undefined errors and test coverage
2014-01-04 08:42:02 -08:00
Hannah Wolfe
762f3c06ac Remove express server from grunt test-coverage
- currently the coverage report only runs for unit & integration tests, and these don't need the express server.
2014-01-04 14:09:59 +00:00
Harry Wolff
0a2c8248b9 Fix {{content words=“0”}} to actually return 0 words
fixes #1796

- adds in a workaround to the weirdness that currently
exists in downsize module
- adds tests
2014-01-04 00:30:52 -05:00
Hannah Wolfe
74217e72c4 Merge pull request #1819 from hswolff/quick-edit-post-redirect
Adds ability to quickly get to post’s edit page
2014-01-03 16:10:15 -08:00
Harry Wolff
ab80a132f3 Adds ability to quickly get to post’s edit page
fixes #1810

- updates frontend.single route to accept ‘edit’
as the last param

- updates controller.frontend to handle redirection
only when we would otherwise have rendered the page

- added unit tests for this behavior
2014-01-03 18:16:00 -05:00
John O'Nolan
38c62141cf Disabled styles for disabled buttons
Duh
2014-01-03 22:13:02 +01:00
John O'Nolan
c17271a4c4 Merge pull request #1828 from ddoolin/fix-tag-suggestion-and-padding
Fixes showing tag suggestions and tag container padding
2014-01-03 13:04:16 -08:00
Hannah Wolfe
77ad3c0288 Merge pull request #1814 from cobbspur/uploadsave
disable save button during image uploads
2014-01-03 12:49:40 -08:00
Zach Schneider
044af51267 Added handling for undefined errors and test coverage
Fixes #1827
2014-01-03 15:07:08 -05:00
Zach Schneider
a79597d8b3 Modified github.js to ensure __ isn't escaped at beginning of line
fixes #1791
2014-01-03 09:45:40 -05:00
Hannah Wolfe
bad2a307ae Merge pull request #1826 from demesne/patch-2
Update CONTRIBUTING.md
2014-01-03 01:54:47 -08:00
Kumar Abhinav
fedaa6862c Update CONTRIBUTING.md
fixing the doc as per discussed in the comments for pr/1824
2014-01-03 17:51:07 +08:00
Devin Doolin
5f5bbbfda1 Fixes showing tag suggestions and tag container padding
fixes #1774
- Delayed showing the tag suggestions popup unless matching tags were found
- Changed the padding-left on the added tag container to 8px from 20px to fall in line with the left shadow overlay
2014-01-03 04:42:59 -05:00
Hannah Wolfe
a50f5e1b9d Merge pull request #1815 from ErisDS/more-tests
Error handling simplification & test improvements
2014-01-02 18:13:27 -08:00
Hannah Wolfe
029a01f3dd Merge pull request #1816 from hswolff/fix-admin-session-test
Fixes admin session cookie test
2014-01-02 18:13:17 -08:00
Harry Wolff
20055157ef Fixes admin session cookie test
- Currently the test is taking the response date
which is in UTC and passes it through moment()
which by default parses input as local time.  We
then add 12 hours to this now local time
and when compared against the response set-cookie
header the time spread is wrong.

- To fix we’re parsing the response date with
moment.utc which parses the date in UTC.
2014-01-02 21:06:23 -05:00
cobbspur
b1d88a9c9a disable save button during image uploads
closes #1661

- disables save button at beginning of image upload
- enable save button at image upload fail, at image upload and download success and also at dropzone init
2014-01-02 21:32:23 +00:00
Hannah Wolfe
495b7b7f05 Error handling simplification & test improvements
fixes #1266

- simplifies the check for if a theme has an error template
- adds more / better tests for error handling
2014-01-02 21:03:37 +00:00
Hannah Wolfe
75b261cd69 Merge pull request #1813 from ErisDS/path-change
Move config path.update to config.load
2014-01-02 13:01:14 -08:00
Hannah Wolfe
73275d760f Move config path.update to config.load
issue #1789

- we can do this step a bit earlier and it aids with neatness
- also means for tests that config.load() is enough to get config & paths initialised
2014-01-02 20:29:49 +00:00
Hannah Wolfe
b955f13cc7 Merge pull request #1798 from ErisDS/cache-control
Cache control headers & query string asset management
2014-01-02 12:20:47 -08:00
Hannah Wolfe
1925fa0196 Cache control headers & query string asset management
closes #1470
issue #1405

- added cache control middleware
- added defaults for all routes, assets, etc
- updated asset helper to add a query string with a timestamp hash to all assets
- added unit tests for asset and ghostScriptTags helpers
- added cache-control checks to route tests
2014-01-02 12:14:33 +00:00
Hannah Wolfe
ea21d259c3 Update CONTRIBUTING.md 2014-01-02 10:26:38 +00:00
Hannah Wolfe
422e27a58d Merge pull request #1806 from ErisDS/issue-1778
Fix gravatar retrieval
2014-01-01 11:24:09 -08:00
Hannah Wolfe
4bac1e3672 Fix gravatar retrieval
fixes #1778

- use http for initial request, store url with no schema
2014-01-01 18:10:55 +00:00
Hannah Wolfe
16acba5628 Merge pull request #1805 from ErisDS/route-tests
Route tests
2014-01-01 09:05:21 -08:00
Hannah Wolfe
a697a631c2 Route tests
issue #1773

- Adds functional tests for frontend routing
- Tests the request-response contract
- Requires db access at the moment
- Tests #1790
2014-01-01 16:18:03 +00:00
Hannah Wolfe
7ff191c661 Merge pull request #1804 from ErisDS/issue-1803
Date permalinks use published date
2014-01-01 08:13:32 -08:00
Hannah Wolfe
834cb73613 Date permalinks use published date
fixes #1803

- switches date permalinks from created_at to published_at
- enforces that the post will ONLY render if the date is valid and correct
2014-01-01 15:28:59 +00:00
Hannah Wolfe
a2a606a920 Functional test debugging & improvements
issue #1702
2014-01-01 14:52:49 +00:00
Hannah Wolfe
835f7184c6 Update Casper version on Travis 2014-01-01 13:31:55 +00:00
Hannah Wolfe
dd17b8c552 Merge pull request #1802 from ErisDS/issue-1800
Enforce 2-digit dates in permalinks
2014-01-01 05:31:05 -08:00
Hannah Wolfe
bfe80da54a Enforce 2-digit dates in permalinks
fixes #1800

- changed permalink regex to require 4/2/2/slug
- changed url helper to enforce the same
- changed permalink toggle to set a specific state, this means the
  functional tests are independent again
- chnaged permalink toggle to wait for the settings page to load
- change as many frontend tests to not login as possible
2014-01-01 11:39:19 +00:00
Hannah Wolfe
c7c73ef7d9 Merge pull request #1797 from tomgillett/socket-permissions
Changed socket permissions
2013-12-31 12:50:34 -08:00
Tom Gillett
ba1047b938 Switched Socket permissions to 660.
This adds write permissions for groups and is
more security conscious globally.
2013-12-31 20:09:36 +00:00
Hannah Wolfe
e53148ec2e Update grunt-update-submodules to 0.2.1
issue #1787

- hopefully resolves problems with some versions of npm
2013-12-31 11:20:35 +00:00
Hannah Wolfe
5ef399faee Merge pull request #1790 from ErisDS/issue-1776
Ensure that RSS doesn't 404 when there is no user
2013-12-31 03:03:05 -08:00
Hannah Wolfe
8281d5a21c Merge pull request #1793 from hswolff/fix-post-and-page-routing
Fix routing of posts and static pages
2013-12-30 04:21:40 -08:00
Hannah Wolfe
c295864970 Update connect-slashes to version 1.2.0 2013-12-30 09:25:21 +00:00
Harry Wolff
91ca4a43e5 Fix routing of posts and static pages
closes #1757 and #1773

- switches routes.frontend for posts and pages
to use a regex with two capturing groups.  This removes
the need to dynamically remove an express route at a
later point, leaving the decision making to frontend
controller.

- added unit tests for all routing conditions that 
can arise for posts and pages.

- updated functional tests to also test for same thing
in unit tests

- removes old code from server/api/index that used
to fix this issue, but is no longer needed

- removed some un-needed require statements in routes/admin
2013-12-30 02:04:46 -05:00
Hannah Wolfe
f3a8073653 Merge pull request #1781 from ErisDS/issue-1755
Don't allow /ghost/ subdir
2013-12-29 17:11:54 -08:00
Hannah Wolfe
e2325dc969 Don't allow a subdirectory called Ghost
fixes #1755

- adds extra validation to config loader
- adds tests for config loader and validation
2013-12-30 01:04:29 +00:00
Hannah Wolfe
7f1609ee78 Ensure that RSS doesn't 404 when there is no user
fixes #1776

- could really do with adding a test for this
2013-12-30 01:03:30 +00:00