9 Commits

Author	SHA1	Message	Date
Kevin Ansfield	48e3bf003d	ESLint: Consistent ember property/method ordering ... no issue - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-components.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-controllers.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-routes.md	2018-01-12 12:17:56 +00:00
Kevin Ansfield	fda94fedab	ESLint: Alias model in controllers ... no issue - https://github.com/ember-cli/eslint-plugin-ember/blob/HEAD/docs/rules/alias-model-in-controller.md - replace `model` with a meaningful property name everywhere possible - refactor `design` and `general` settings controllers to use a directly injected settings service rather than passing it in as a "model" to be more explicit	2018-01-12 12:17:56 +00:00
Kevin Ansfield	f25624234f	Avoid leaking state in Ember objects ... no issue - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/avoid-leaking-state-in-ember-objects.md	2017-11-25 09:49:49 +00:00
Kevin Ansfield	983110d931	Switched from ember-cli-shims to new module imports (#779) ... no issue - add eslint-plugin-ember, configure no-old-shims rule - run `eslint --fix` on `app`, `lib`, `mirage`, and `tests` to move imports to the new module imports - further cleanup of Ember globals usage - remove event-dispatcher initializer now that `canDispatchToEventManager` is deprecated	2017-08-22 14:53:26 +07:00
Kevin Ansfield	f8f09dab05	🐛 fix missing meta description preview (#719) ... refs #718, refs https://github.com/TryGhost/Ghost/pull/8305 - meta description preview in the PSM was relying on the `html` field which is no longer queried - see #718 and https://github.com/TryGhost/Ghost/pull/8305 - restores live preview that was in LTS but removed whilst implementing mobiledoc because we had no quick way of rendering mobiledoc->text - adds a boolean argument to the `formatMarkdown` util that can disable the replacement of `<script>` and `<iframe>` tags so that the inserted text isn't rendered when converting HTML to text	2017-05-30 15:07:12 +02:00
Kevin Ansfield	cb59388c5b	💄🐷 sort-imports eslint rule (#712) ... no issue - adds `eslint-plugin-sort-imports-es6-autofix` dependency - implements ESLint's base `sort-imports` rule but has a distinction in that `import {foo} from 'bar';` is considered `multiple` rather than `single` - fixes ESLint's autofix behaviour so `eslint --fix` will actually fix the sort order - updates all unordered import rules by using `eslint --fix` With the increased number of `import` statements since Ember+ecosystem started moving towards es6 modules I've found it frustrating at times trying to search through randomly ordered import statements. Recently I've been sorting imports manually when I've added new code or touched old code so I thought I'd add an ESLint rule to codify it.	2017-05-29 20:50:03 +02:00
Kevin Ansfield	c3b49b45cf	🎨 synchronous settings service ... no issue - adds `settings` service that acts as a proxy to the singular settings model with methods to fetch and reload, also prevents accidentally loading only some settings types which has caused problems in the past - updates app boot, signin, and signup processes to fetch settings ensuring that any part of the app can grab settings synchronously if needed - removes `timeZone` service, it's no longer needed as we can grab `settings.activeTimezone` directly - replaces all store queries for the settings model with appropriate `settings` methods - refactors `apps/*` routes/controllers, they had become a little convoluted with the way they were dealing with settings and the new service helped to clean that up	2017-03-20 07:43:49 -05:00
Kevin Ansfield	1b4db78eae	👷 skip PSM unit tests until converted to integration tests	2017-03-14 10:12:06 +00:00
Austin Burdine	ab287848d4	🎨 convert post-settings-menu into a component (#137) ... no issue - cleans up some of the render code - aligns things with the "ember way" - move metaTitleScratch and metaDescriptionScratch bindings to post model	2017-03-10 14:30:01 +00:00