TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-20 01:03:23 +03:00
Code Issues Projects Releases Wiki Activity
34,872 Commits 248 Branches 1,686 Tags 377 MiB
db0081ccaf
Commit Graph

315 Commits

Author SHA1 Message Date
Ronald Langeveld
998708c81a
🐛 Fixed empty icon crashing signup embed preview (#17022) 
closes https://github.com/TryGhost/Team/issues/3471

- after adding and removing an icon, icon settings passed an undefined
icon to the signup form's all-in-one style. The AIO conditions didn't
take that into account and caused the entire component to crash.

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 9e1aea3</samp>

Fix signup form embed code generation when icon is not set. Add a check
for `this.settings.icon` in `signup-form-embed.js` before replacing
image path.
 2023-06-14 15:13:49 +02:00
Simon Backx
ffa6c9c5f8 Added width:100% to minimal signup form CSS 
no issue

Otherwise the auto margin would cause issues in a grid or flex container.
 2023-06-09 11:08:14 +02:00
Simon Backx
12f7fd0153 Updated minimal signup form to be centered by default 
no issue

Added `margin: 0 auto;` css by default.
 2023-06-09 10:47:51 +02:00
Simon Backx
66ca072055 Moved maximum width and centering outside minimal signup form 
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1686299301740999

- Easier to customize: easy to choose between centering and left alignment
- Fixes issue with centering error message
 2023-06-09 10:42:24 +02:00
Sanne de Vries
e74b38ac93
Updated color picker in signup form modal (#16971) 
Refs https://github.com/TryGhost/Team/issues/3407

---------

Co-authored-by: Simon Backx <simon@ghost.org>
 2023-06-09 08:55:35 +02:00
Sanne de Vries
1e7b332b7f Updated signup form embed settings copy 
No ref
 2023-06-09 08:26:21 +02:00
Simon Backx
c5fbd8bae6 Added Plausible events when copying the signup form embed code 
fixes https://github.com/TryGhost/Team/issues/3389
 2023-06-08 15:51:32 +02:00
Simon Backx
5658f4b627 Fixed admin failing tests 
no issue

renderInPlace broke tests because expected dropdown changed place in the DOM
 2023-06-08 13:38:13 +02:00
Simon Backx
a68ac4b688 Renamed data-logo to data-icon in signup embed attributes 
fixes https://github.com/TryGhost/Team/issues/3401
 2023-06-08 13:23:38 +02:00
Simon Backx
f0518bc76a Increased signup form embed icon resolution to 192px 
no issue

Optimal resolution for @3x devices
 2023-06-06 09:42:42 +02:00
Simon Backx
fc89ad22fc Prevented setting signup form embed locale when feature flag is disabled 
fixes https://github.com/TryGhost/Team/issues/3385
 2023-06-06 09:40:47 +02:00
Simon Backx
ab0c33346d Fixed signup form minimal width in preview 
no issue
 2023-06-05 18:10:19 +02:00
Simon Backx
1e7b658148 Updated sign up form to use resized version of icon 
fixes https://github.com/TryGhost/Team/issues/3345

The icon is now served as a 128x128px version
 2023-06-05 17:59:18 +02:00
Simon Backx
9aef897936 Increased virtual iframe width of minimal signup form preview 
no issue

Because the signup form is responsive, it is displayed too small in the preview. To counteract this, the width of the iframe is increased to 200%, and clipped to make it larger.
 2023-06-05 17:37:43 +02:00
Simon Backx
22f4d55f75 Added throttling and animation when updating signup form preview 
fixes https://github.com/TryGhost/Team/issues/3378
 2023-06-05 15:24:59 +02:00
Simon Backx
d4f82f8b88 Added copy on click to textarea in signup form embed modal 
no issue
 2023-06-02 16:31:30 +02:00
Simon Backx
fc5af7e7f8 Removed notification when copying signup form embed code 2023-06-02 16:21:20 +02:00
Simon Backx
ff28e1c94f Added fixed order in data attributes for signup form embed script 
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1685711310532969
 2023-06-02 16:13:42 +02:00
Sanne de Vries
8833ec03de
Updated signup form modal (#16925) 
Refs https://github.com/TryGhost/Team/issues/3340

---------

Co-authored-by: Simon Backx <simon@ghost.org>
 2023-06-02 16:07:30 +02:00
Simon Backx
258dc2f8f2 Added locale data option to signup form script 
refs https://github.com/TryGhost/Team/issues/3307
 2023-06-02 14:36:17 +02:00
Simon Backx
c27b488f3d Added async attribute to signup form script tag 2023-06-02 13:59:49 +02:00
Simon Backx
806abf28e4 Added placeholder to member label input for signup form embed modal 
refs https://github.com/TryGhost/Team/issues/3340
 2023-06-02 12:28:58 +02:00
Simon Backx
9ff9906670 Added transparent background pattern to minimal signup form preview 
refs https://github.com/TryGhost/Team/issues/3340
 2023-06-02 09:48:25 +02:00
Simon Backx
5152e0e042 Moved signup form embed to a modal 
refs https://github.com/TryGhost/Team/issues/3340
 2023-06-02 09:31:38 +02:00
Michael Barrett
83847bf22c
Added emailCustomization flag and removed makeItRain flag (#16903) 
refs https://github.com/TryGhost/Team/issues/3337

Moved current email customization functionality that is behind the
`makeItRain` to its own flag (`emailCustomization`) and removed the now
redundant `makeItRain` flag
 2023-06-01 12:32:37 +01:00
Chris Raible
3d785e4d95 Fixed restoring post revision not creating a new revision 
refs TryGhost/Team#3109
 2023-04-21 16:37:49 +01:00
Michael Barrett
49eac033a3
Added confirmation modal when restoring a post revision (#16689) 
no issue

Added confirmation modal when restoring a post revision
 2023-04-20 17:01:17 +01:00
Simon Backx
ec40484983
Reverted "✨ Added email design customization" (#16570) 2023-04-05 15:28:20 +02:00
Simon Backx
4639514a3b ✨ Added email design customization 
fixes https://github.com/TryGhost/Team/issues/2671

Co-authored-by: Fabien 'egg' O'Carroll <fabien@allou.is>
Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
 2023-04-05 11:13:48 +02:00
Simon Backx
108ccd7fb6 Updated newsletter background preset color to lightgrey 
no issue
 2023-04-05 10:00:47 +02:00
Simon Backx
3885cab977 Reduced color picker delay 2023-04-04 18:05:16 +02:00
Sanne de Vries
ae2622af6c Updated email preview in Newsletter settings 
Closes https://github.com/TryGhost/Team/issues/2830
 2023-04-04 13:40:06 +02:00
Simon Backx
aee909b054 Improved newsletter color picker in admin 
refs https://github.com/TryGhost/Team/issues/2830

- Colors stay in the same order
- Auto color changes faster because direct usage of preset colors and no longer uses ordered colors
 2023-04-03 14:18:50 +02:00
Simon Backx
33237c4df7 Added newsletter auto border color and dynamic color picker 
fixes https://github.com/TryGhost/Team/issues/2879
fixes https://github.com/TryGhost/Team/issues/2880

- Replaced black border color with 'auto' based on background color.
- When a color is 'auto', the color that are visible in the UI (color pciker) will be dynamic based on the background color.
 2023-04-03 11:27:57 +02:00
Sanne de Vries
b8a8b7fd19 Updated newsletter footer section headings to use titleColor 
Refs https://github.com/TryGhost/Team/issues/2830
 2023-04-03 10:17:51 +02:00
Sanne de Vries
8eefaee591 Implemented newsletter customisation in admin preview 
Refs https://github.com/TryGhost/Team/issues/2846
 2023-03-30 17:34:01 +02:00
Fabien 'egg' O'Carroll
c9752c773a
Added newsletter customisation data to the preview template (#16527) 
refs https://github.com/TryGhost/Team/issues/2846

In order to render the preview correctly and use the new design settings
we need to expose them to the template. Unfortuantely we've had to
duplicate all of the code from the backend here, long term we should try
and pull the newsletter email rendering into a component that can be
shared between the server & client.
 2023-03-30 13:18:39 +07:00
Simon Backx
90a96978b0 Updated default color picker color to #999999 
refs https://github.com/TryGhost/Team/issues/2830
 2023-03-29 17:22:52 +02:00
Simon Backx
5a41717384 Improved color picker to show color wheel again 
refs https://github.com/TryGhost/Team/issues/2830

After selecting a custom color, and deselecting it. It will show the color wheel again on the next hover.
 2023-03-29 17:20:57 +02:00
Simon Backx
73d823ad6a Improved color picker 
refs https://github.com/TryGhost/Team/issues/2830

Only update the order of the colors on mouseleave (+ after the animation). This also includes some minor changes to the CSS files to remove glitches in the animation. I temporarily removed the border of the colors because they keep taking up space when the colors are hidden. Ideally we want to move those borders to :before or :after, that will also be better for the animation.
 2023-03-29 16:59:58 +02:00
Simon Backx
fbd46e7688 Added automatic switch between light/dark for heading color 'auto' 
refs https://github.com/TryGhost/Team/issues/2830
 2023-03-29 12:12:12 +02:00
Simon Backx
675e7ed7cc Implemented custom color selection for newsletter colors 
refs https://github.com/TryGhost/Team/issues/2830
 2023-03-29 12:03:45 +02:00
Sanne de Vries
fe7d0620a5 Updated color swatches in email design settings 
Refs https://github.com/TryGhost/Team/issues/2830
 2023-03-28 18:50:39 +02:00
Simon Backx
986aa38903 Implemented basic color picker in newsletter settings 
refs https://github.com/TryGhost/Team/issues/2830

Allows to change the colors, but not yet allows to select custom colors.
 2023-03-28 14:24:04 +02:00
Sanne de Vries
4cebceb0d8 Added transitions to newsletter color pickers 
Refs https://github.com/TryGhost/Team/issues/2830
 2023-03-28 12:39:33 +02:00
Sanne de Vries
7928b53fbd Updated color settings UI in email newsletter 
Refs https://github.com/TryGhost/Team/issues/2830
 2023-03-27 16:00:24 +02:00
Sanne de Vries
11656ea696 Added UI for changing newsletter colors to email settings 
Refs https://github.com/TryGhost/Team/issues/2830
 2023-03-27 13:15:51 +02:00
Simon Backx
317b9aee20 Copied over preview labs change 
no refs

Change should be applied for labs and no labs preview page.
 2023-03-24 11:00:52 +01:00
Simon Backx
104a81d8c3 ✨ Added latests posts to newsletters 
fixes https://github.com/TryGhost/Team/issues/2675

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
 2023-03-24 10:54:45 +01:00
Sanne de Vries
cd7f4bdb09 Fixed sans-serif body font not displaying correctly in email preview 
No ref
 2023-03-24 10:53:37 +01:00