Commit Graph

5785 Commits

Author SHA1 Message Date
Hannah Wolfe
65fcd53f33 Merge pull request #6143 from acburdine/remove-casper
Remove casperjs from travis setup
2015-12-01 14:33:18 +08:00
Hannah Wolfe
8dbef11bc5 Updated node version text in README.md
no issue

- update README to match the new version support
2015-12-01 14:09:16 +08:00
Hannah Wolfe
395079cd2f Unify code for picking a template to render with
refs #5091

- 100% coverage for new frontend/templates file
- new module handles the logic for determining which template to render with
2015-12-01 12:05:46 +08:00
Gary Cao
e4c10c9688 Properly binds "this" in uploader.js
closes #6146
2015-12-01 12:50:31 +09:00
Austin Burdine
366e2fe3da deps: ember/ember-data@2.2.0 2015-11-30 12:23:47 -06:00
Kevin Ansfield
c884e67090 Merge pull request #6113 from acburdine/ember-cli-1.13.12
Update Ember-CLI to 1.13.13
2015-11-30 18:01:14 +00:00
Austin Burdine
ea64e5f8b6 remove casperjs from travis setup 2015-11-30 11:23:09 -06:00
Austin Burdine
7cbe7281a8 deps: ember-cli@1.13.13 2015-11-30 11:21:39 -06:00
Hannah Wolfe
8d5d89fb4a Merge pull request #6074 from kevinansfield/separate-travis-suites
Separate the client/server test suites on Travis
2015-11-30 23:46:52 +08:00
Kevin Ansfield
a102eff0ed Separate the server/client/lint test suites on Travis
no issue
- add separate grunt tasks for validating all/client/server test suites
- modify `grunt validate` to respect the `TEST_SUITE` env var if present
- default to `TEST_SUITE=server` on Travis
- add an individual builds to the Travis matrix that test the client and run linting as separate jobs
- don't run `ensureConfig` task if we're performing client-only tests

Previously we were duplicating the client tests and linting for every node and database version in our build matrix. Duplicating those tasks a waste of time/resources as the client tests are now completely isolated from the server and so different node/database versions have no effect. This PR is an attempt at removing the duplication to speed up our Travis runs.
2015-11-30 15:21:08 +00:00
Sebastian Gierlinger
fc9d9096aa Merge pull request #6078 from kevinansfield/always-call-super
Always call `_super` when using Ember hooks
2015-11-30 14:12:31 +01:00
Kevin Ansfield
571b9e783a Always call _super when using Ember hooks
no issue
- review use of Ember core hooks and add a call to `this._super` if missing
- fix a few occurrences of using the wrong component lifecycle hooks that could result in multiple/duplicate event handlers being attached

`_super` should always be called when overriding Ember's base hooks so that core functionality or app functionality added through extensions, mixins or addons is not lost. This is important as it guards against issues arising from later refactorings or core changes.

As example of lost functionality, there were a number of routes that extended from `AuthenticatedRoute` but then overrode the `beforeModel` hook without calling `_super` which meant that the route was no longer treated as authenticated.
2015-11-30 12:45:37 +00:00
Sebastian Gierlinger
e5d9865792 Merge pull request #6020 from kevinansfield/suave
Use ember-suave and standardise client's es6 usage
2015-11-30 12:46:39 +01:00
Kevin Ansfield
3d6856614f Use es6 across client and add ember-suave to enforce rules
no issue
- add ember-suave dependency
- upgrade grunt-jscs dependency
- add a new .jscsrc for the client's tests directory that extends from client's base .jscsrc
- separate client tests in Gruntfile jscs task so they pick up the test's .jscsrc
- standardize es6 usage across client
2015-11-30 10:41:01 +00:00
Kevin Ansfield
9437b8eeef Merge pull request #6108 from mixonic/no-rerender-selectors
Unify mobile state in JS, drop resize
2015-11-30 08:45:03 +00:00
Hannah Wolfe
1ce7f2251a Merge pull request #6136 from bhops/remove-405-test
Remove unused base_test.js
2015-11-30 10:06:26 +08:00
Brandon Hops
0a06af02d5 Remove unused base_test.js 2015-11-28 18:46:13 -08:00
Hannah Wolfe
55045ae784 Version bump to 0.7.2 2015-11-27 13:13:25 +08:00
Hannah Wolfe
2ea4f67dd4 Merge pull request #6131 from sebgie/issue#6106-1
Origin Header revisited
2015-11-27 00:32:51 +08:00
Hannah Wolfe
a8d13dd332 Merge pull request #6129 from kevinansfield/invalid-origin-errors
Display error message on setup if origin doesn't match config.js url
2015-11-27 00:25:57 +08:00
Hannah Wolfe
cd5188a32a Merge pull request #6130 from kevinansfield/missing-signin-error
Fix missing error on signin when server has gone away
2015-11-26 23:07:44 +08:00
Sebastian Gierlinger
245095c199 Origin Header revisited
closes #6106
- added override for my-ghost-blog.com
- added local IP addresses to be allowed
- changed localhost/127.0.0.1 to be allowed in production
2015-11-26 13:11:31 +01:00
Kevin Ansfield
0462dfed39 Display error message on setup if origin doesn't match config.js url
refs #6106
- add error handler for authentication step of blog setup
- move setup acceptance test out of 'settings' folder
2015-11-26 11:22:16 +00:00
Kevin Ansfield
f2c7e34c3f Fix missing error on signin when server has gone away
no issue
- `session.authenticate` calls out to jQuery for the ajax request which then raises it's own error but returns nothing when the server is not reachable. This is a quick fix so that we don't error and can pass through to the default error handler in the authentication step.
2015-11-26 11:15:17 +00:00
Sebastian Gierlinger
03760c3674 Merge pull request #6128 from ErisDS/startup-check
Docs link & unique error codes for startup checks
2015-11-26 10:32:22 +01:00
Hannah Wolfe
f25039c4b9 Docs link & unique error codes for startup checks
refs #5821, #6063

- switch out help test to go to a comprehensive doc
- change error codes from 1 to unique codes
2015-11-26 16:20:11 +08:00
Hannah Wolfe
34d329ef56 Upgrading Casper to 1.2.6 2015-11-26 09:33:40 +08:00
Matthew Beale
402b27c7e9 Unify mobile state in JS, drop resize
In `gh-content-view-container` the visibility of another DOM node was
being used to detect if a given view was mobile or not. This means the
UI needed to have layout forced (and DOM rendered) before the content
view container would render a second time. This is slow interaction with
the DOM (forcing layout) and slow for Ember's renderer (it needs to
render the container once with a default, then again when the value
changes).

Additionally there were two ways resize was being observed. The
`Window.matchMedia` API was used for some styles and the `ember-resize`
addon used to detect other changes. Here I've unified around just the
`Window.matcheMedia` API but abstracted it behind a service.

Sizes are exposed as properties that can be bound to or used directly in
templates.
2015-11-25 11:54:08 -05:00
Sebastian Gierlinger
014e2c88dd Restore options
refs #6122
- restore original options after delete
- this is a fix for one use case, long term we should aim to leave
options untouched and execute special queries with temporary data
2015-11-25 09:59:27 +01:00
Sebastian Gierlinger
787554bdbb Merge pull request #6123 from kevinansfield/fix-bower
Specify full SHAs when importing packages in bower.json
2015-11-24 19:36:35 +01:00
Kevin Ansfield
2b1f784d91 Add count.posts support to user model on client
no issue
- moves adapter tests from unit to integration as we are not testing them in isolation
- add test for querying user's by slug with `include=count.posts`
- add `count` attribute to User model
2015-11-24 17:11:35 +00:00
Kevin Ansfield
18472d7b33 Specify full SHAs when importing packages in bower.json
no issue
- removes warning: `bower password-generator#49accd7    short-sha Consider using longer commit SHA to avoid conflicts`
- fixes error: `bower jqueryui-touch-punch#*    error key must be a string or number. undefined`
2015-11-24 16:39:14 +00:00
Sebastian Gierlinger
a156a1ed08 Merge pull request #6117 from ErisDS/node-v4
Adding node 4.2 LTS to engines
2015-11-24 11:14:16 +01:00
Sebastian Gierlinger
ac53fc9c3f Merge pull request #6119 from boennemann/chore-grunt-release
Dynamically build file patterns for release task
2015-11-24 11:14:08 +01:00
Hannah Wolfe
d758acd4d0 Merge pull request #6118 from kevinansfield/rename-post_count
Update client for tag.post_count -> tag.count.posts rename
2015-11-24 06:42:37 +00:00
Stephan Bönnemann
c22c866e93 Dynamically build file patterns for release task
- converted release task to function task
- dynamically setting config for copy task by reading `.npmignore` on demand
- speeds up all other tasks because `.npmignore` is no longer read from filesystem
2015-11-23 22:45:48 +01:00
Kevin Ansfield
161591fc3d Update client for tag.post_count -> tag.count.posts rename
refs #6105
- adds `raw` ember-data transform to handle standard JSON `count` attribute
- update mirage factory to return correct `count.posts` format
- rename all uses of `post_count` to `count.posts`
2015-11-23 19:57:56 +00:00
Hannah Wolfe
059e19ee63 Adding node 4.2 LTS to engines
closes #5821
2015-11-23 18:56:13 +00:00
Hannah Wolfe
904620ac23 Merge pull request #6116 from sebgie/issue#6106
Handling Origin Header
2015-11-23 17:46:20 +00:00
Sebastian Gierlinger
8c50609491 Handling Origin Header
closes #6106
- added better error message for client and console
- added exclusion of localhost/127.0.0.1 for dev mode
2015-11-23 18:21:19 +01:00
Kevin Ansfield
431ccb16c9 Merge pull request #6099 from acburdine/user-adapter
Implement custom user adapter to pull users by slug
2015-11-23 14:52:01 +00:00
Sebastian Gierlinger
98e802c8ec Merge pull request #6115 from ErisDS/sqlite-update
deps:sqlite3@3.1.1
2015-11-23 15:09:34 +01:00
Austin Burdine
1f834521b6 implement custom user adapter to pull users by slug
closes #6095
- implements custom user adapter for the `/team/:slug/` route
- abstracts slug-url behavior into a mixin (used in /settings/tags/ as well)
- adds unit tests for both tag and user adapters
2015-11-23 07:48:08 -06:00
Hannah Wolfe
649b558969 deps:sqlite3@3.1.1 2015-11-23 10:23:09 +00:00
Hannah Wolfe
8f620b6dce Merge pull request #6063 from jgillich/version-check
Enable Node 4.2 testing
2015-11-23 09:56:27 +00:00
Jakob Gillich
faa1655a50 Enable Node 4.2 testing
* Do not error when node unsupported if GHOST_NODE_VERSION_CHECK=false is set
* Run engine check in preinstall script
* Add 4.2 to travis

issue #5821
2015-11-23 06:45:40 +01:00
Sebastian Gierlinger
8d414880f4 Merge pull request #6109 from ErisDS/count-order
Support ordering by count
2015-11-22 18:31:06 +01:00
Hannah Wolfe
d4c8b69673 Support ordering by count
refs #6009

- super quick and dirty way to support ordering by counts
- @TODO refactor :)
2015-11-22 17:18:30 +00:00
Sebastian Gierlinger
0be7513eff Merge pull request #6105 from ErisDS/count-rename
Rename post_count to count.posts
2015-11-22 18:10:00 +01:00
Kevin Ansfield
cda3a52f54 Merge pull request #6107 from mixonic/no-rerender-plz
Minimize rerender warnings
2015-11-21 15:22:29 +00:00