6 Commits

Author	SHA1	Message	Date
Kevin Ansfield	4d5c43305b	Removed deprecated usage of this.$() in components ... no issue - converted remaining uses of `this.$()` that I could find over to native DOM - deprecation is still silenced for now because both `liquid-fire` and `liquid-wormhole` trigger it	2020-01-10 15:12:39 +00:00
Kevin Ansfield	352c4af1d7	Refactored usage of .get('property') with es5 getters ... no issue - ran [es5-getter-ember-codemod](https://github.com/rondale-sc/es5-getter-ember-codemod) - [es5 getters RFC](https://github.com/emberjs/rfcs/blob/master/text/0281-es5-getters.md) - updates the majority of `object.get('property')` with `object.property` with exceptions: - `.get('nested.property')` - it's not possible to determine if this is relying on "safe" path chaining for when `nested` doesn't exist - `.get('config.x')` and `.get('settings.x')` - both our `config` and `settings` services are proxy objects which do not support es5 getters - this PR is not exhaustive, there are still a number of places where `.get('service.foo')` and similar could be replaced but it gets us a long way there in a quick and automated fashion	2019-03-06 13:54:14 +00:00
Kevin Ansfield	48e3bf003d	ESLint: Consistent ember property/method ordering ... no issue - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-components.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-controllers.md - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/order-in-routes.md	2018-01-12 12:17:56 +00:00
Kevin Ansfield	f9d30ff9c8	Use computed property brace expansion ... no issue - https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/use-brace-expansion.md	2017-11-25 09:49:49 +00:00
Kevin Ansfield	9adbcd1fd0	Match service/controller import to ember-modules-codemod style for consistency ... no issue Automated tools, code generators, and editor integrations are increasingly standardising on the import style used in `ember-modules-codemod`. Our import style differed a little with regards to service/controller injection imports which meant we were starting to see inconsistent naming.	2017-10-30 09:38:01 +00:00
Kevin Ansfield	9ed5aad186	Flatten nested components (#854) ... no issue - the upcoming Module Unification re-organisation in Ember will no longer support nested components - this PR pre-emptively moves our usage of nested components into a flat file structure	2017-09-11 14:41:17 +07:00