mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-25 19:48:50 +03:00
f054205e58
ref https://linear.app/tryghost/issue/ONC-323 - our fallback 404 error handler assumed we always had a transition along with the error - this wasn't a bad assumption, it should be very unlikely that we see a 404 outside of navigating to a non-existent/deleted resource - unfortunately we weren't handling the error thrown by our error handler which meant the error was silent as far as the user was concerned - having a silent error meant that in very rare circumstances the editor could get into a state where saving was failing but there was no indication of that - updated the fallback 404 error handler to only do something when navigation was occurring in which case it transitions to the 404 screen, otherwise let the error continue to our generic API error handling which will stay on the current screen but show an error alert - adjusted the editor saving to actually trigger autosave-after-change when testing (albeit with 100ms wait compared to 3s) so the tests better reflect actual behaviour |
||
|---|---|---|
| .. | ||
| editor.js | ||
| file-upload.js | ||
| forms.js | ||
| labs-flag.js | ||
| login-as-role.js | ||
| mailgun.js | ||
| members.js | ||
| newsletters.js | ||
| stripe.js | ||
| visit.js | ||