mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-25 09:03:12 +03:00
459a2c553e
ref https://linear.app/tryghost/issue/ONC-323 When the store gets into a bad state for new posts that causes saves to fail we can detect that by looking at the `model.isNew` property. Currently our best approach to fix this state is to restart the app. - added a `didTransition()` hook to our `lexical-edit.new` route - detects the bad state, logs the error, and triggers a browser refresh - logs with a `recreatedPostIsGood` property that will let us know if we could instead just try recreating the post and avoiding a full refresh (so far we have no reproduction case so we need to learn what we can) - added `sinon-chai` dependency for better assertions on spies/stubs - added `sentry-testkit` dependency so we can test our Sentry integration calls - we can't use sinon for these calls because of the way Sentry's es6 imports work - extracted our full Sentry config object generation to a util function so it can be re-used in unit tests - updated our integrations list to disable the default `dedupe` integration because it can cause very unexpected/difficult to debug test failures when you're asserting using `sentry-testkit`
268 lines
8.4 KiB
JavaScript
268 lines
8.4 KiB
JavaScript
/* eslint-env node */
|
|
'use strict';
|
|
|
|
const EmberApp = require('ember-cli/lib/broccoli/ember-app');
|
|
const concat = require('broccoli-concat');
|
|
const mergeTrees = require('broccoli-merge-trees');
|
|
const Terser = require('broccoli-terser-sourcemap');
|
|
const Funnel = require('broccoli-funnel');
|
|
const webpack = require('webpack');
|
|
const environment = EmberApp.env();
|
|
const isDevelopment = environment === 'development';
|
|
const isProduction = environment === 'production';
|
|
const isTesting = environment === 'test';
|
|
|
|
const postcssImport = require('postcss-import');
|
|
const postcssCustomProperties = require('postcss-custom-properties');
|
|
const postcssColorModFunction = require('postcss-color-mod-function');
|
|
const postcssCustomMedia = require('postcss-custom-media');
|
|
const autoprefixer = require('autoprefixer');
|
|
const cssnano = require('cssnano');
|
|
|
|
const codemirrorAssets = function () {
|
|
let codemirrorFiles = [
|
|
'lib/codemirror.js',
|
|
'mode/htmlmixed/htmlmixed.js',
|
|
'mode/xml/xml.js',
|
|
'mode/css/css.js',
|
|
'mode/javascript/javascript.js'
|
|
];
|
|
|
|
if (environment === 'test') {
|
|
return {import: codemirrorFiles};
|
|
}
|
|
|
|
let config = {};
|
|
|
|
config.public = {
|
|
include: codemirrorFiles,
|
|
destDir: '/',
|
|
processTree(tree) {
|
|
let jsTree = concat(tree, {
|
|
outputFile: 'assets/codemirror/codemirror.js',
|
|
headerFiles: ['lib/codemirror.js'],
|
|
inputFiles: ['mode/**/*'],
|
|
sourceMapConfig: {enabled: false}
|
|
});
|
|
|
|
if (isProduction) {
|
|
jsTree = new Terser(jsTree);
|
|
}
|
|
|
|
let mergedTree = mergeTrees([tree, jsTree]);
|
|
return new Funnel(mergedTree, {include: ['assets/**/*', 'theme/**/*']});
|
|
}
|
|
};
|
|
|
|
// put the files in vendor ready for importing into the test-support file
|
|
if (environment === 'development') {
|
|
config.vendor = codemirrorFiles;
|
|
}
|
|
|
|
return config;
|
|
};
|
|
|
|
let denylist = [];
|
|
if (process.env.CI) {
|
|
denylist.push('ember-cli-eslint');
|
|
}
|
|
|
|
let publicAssetURL;
|
|
|
|
if (isTesting) {
|
|
publicAssetURL = undefined;
|
|
} else if (process.env.GHOST_CDN_URL) {
|
|
publicAssetURL = process.env.GHOST_CDN_URL + 'assets/';
|
|
} else {
|
|
publicAssetURL = 'assets/';
|
|
}
|
|
|
|
module.exports = function (defaults) {
|
|
let app = new EmberApp(defaults, {
|
|
addons: {denylist},
|
|
babel: {
|
|
plugins: [
|
|
require.resolve('babel-plugin-transform-react-jsx')
|
|
]
|
|
},
|
|
'ember-cli-babel': {
|
|
optional: ['es6.spec.symbols'],
|
|
includePolyfill: false
|
|
},
|
|
'ember-composable-helpers': {
|
|
only: ['join', 'optional', 'pick', 'toggle', 'toggle-action', 'compute']
|
|
},
|
|
'ember-promise-modals': {
|
|
excludeCSS: true
|
|
},
|
|
outputPaths: {
|
|
app: {
|
|
js: 'assets/ghost.js',
|
|
css: {
|
|
app: 'assets/ghost.css',
|
|
// TODO: find a way to use the .min file with the lazyLoader
|
|
'app-dark': 'assets/ghost-dark.css'
|
|
}
|
|
}
|
|
},
|
|
fingerprint: {
|
|
enabled: isProduction,
|
|
prepend: process.env.GHOST_CDN_URL || '',
|
|
extensions: [
|
|
'js',
|
|
'css',
|
|
'png',
|
|
'jpg',
|
|
'jpeg',
|
|
'gif',
|
|
'map',
|
|
'svg',
|
|
'ttf',
|
|
'woff2',
|
|
'mp4',
|
|
'ico'
|
|
],
|
|
exclude: ['**/chunk*.map']
|
|
},
|
|
minifyJS: {
|
|
options: {
|
|
output: {
|
|
semicolons: true
|
|
}
|
|
}
|
|
},
|
|
minifyCSS: {
|
|
// postcss already handles minification and this was stripping required CSS
|
|
enabled: false
|
|
},
|
|
nodeAssets: {
|
|
codemirror: codemirrorAssets()
|
|
},
|
|
postcssOptions: {
|
|
compile: {
|
|
enabled: true,
|
|
plugins: [
|
|
{
|
|
module: postcssImport,
|
|
options: {
|
|
path: ['app/styles']
|
|
}
|
|
},
|
|
{
|
|
module: postcssCustomProperties,
|
|
options: {
|
|
preserve: false
|
|
}
|
|
},
|
|
{
|
|
module: postcssColorModFunction
|
|
},
|
|
{
|
|
module: postcssCustomMedia
|
|
},
|
|
{
|
|
module: autoprefixer
|
|
},
|
|
{
|
|
module: cssnano,
|
|
options: {
|
|
zindex: false,
|
|
// cssnano sometimes minifies animations incorrectly causing them to break
|
|
// See: https://github.com/ben-eb/gulp-cssnano/issues/33#issuecomment-210518957
|
|
reduceIdents: {
|
|
keyframes: false
|
|
},
|
|
discardUnused: {
|
|
keyframes: false
|
|
}
|
|
}
|
|
}
|
|
]
|
|
}
|
|
},
|
|
sourcemaps: {enabled: true},
|
|
svgJar: {
|
|
strategy: 'inline',
|
|
stripPath: false,
|
|
sourceDirs: [
|
|
'public/assets/icons'
|
|
],
|
|
optimizer: {
|
|
plugins: [
|
|
{prefixIds: true},
|
|
{cleanupIds: false},
|
|
{removeDimensions: true},
|
|
{removeTitle: !isDevelopment},
|
|
{removeXMLNS: true},
|
|
// Transforms on groups are necessary to work around Firefox
|
|
// not supporting transform-origin on line/path elements.
|
|
{convertPathData: {
|
|
applyTransforms: false
|
|
}},
|
|
{moveGroupAttrsToElems: false}
|
|
]
|
|
}
|
|
},
|
|
autoImport: {
|
|
publicAssetURL,
|
|
alias: {
|
|
'sentry-testkit/browser': 'sentry-testkit/dist/browser'
|
|
},
|
|
webpack: {
|
|
devtool: 'source-map',
|
|
resolve: {
|
|
fallback: {
|
|
util: require.resolve('util'),
|
|
path: require.resolve('path-browserify'),
|
|
fs: false
|
|
}
|
|
},
|
|
...(isDevelopment && {
|
|
cache: {
|
|
type: 'filesystem',
|
|
buildDependencies: {
|
|
config: [__filename]
|
|
}
|
|
}
|
|
}),
|
|
plugins: [
|
|
new webpack.ProvidePlugin({
|
|
process: 'process/browser'
|
|
})
|
|
]
|
|
}
|
|
},
|
|
'ember-test-selectors': {
|
|
strip: false
|
|
}
|
|
});
|
|
|
|
// Stop: Normalize
|
|
app.import('node_modules/normalize.css/normalize.css');
|
|
|
|
// 'dem Styles
|
|
// import codemirror styles rather than lazy-loading so that
|
|
// our overrides work correctly
|
|
app.import('node_modules/codemirror/lib/codemirror.css');
|
|
app.import('node_modules/codemirror/theme/xq-light.css');
|
|
|
|
// 'dem Scripts
|
|
app.import('node_modules/google-caja-bower/html-css-sanitizer-bundle.js');
|
|
app.import('node_modules/keymaster/keymaster.js');
|
|
app.import('node_modules/reframe.js/dist/noframe.js');
|
|
|
|
// pull things we rely on via lazy-loading into the test-support.js file so
|
|
// that tests don't break when running via http://localhost:4200/tests
|
|
if (app.env === 'development') {
|
|
app.import('vendor/codemirror/lib/codemirror.js', {type: 'test'});
|
|
}
|
|
|
|
if (app.env === 'development' || app.env === 'test') {
|
|
// pull dynamic imports into the assets folder so that they can be lazy-loaded in tests
|
|
// also done in development env so http://localhost:4200/tests works
|
|
app.import('node_modules/@tryghost/koenig-lexical/dist/koenig-lexical.umd.js', {outputFile: 'ghost/assets/koenig-lexical/koenig-lexical.umd.js'});
|
|
}
|
|
|
|
return app.toTree();
|
|
};
|