TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-20 09:22:49 +03:00
Code Issues Projects Releases Wiki Activity
034812ac02
Ghost/ghost/staff-service
History
Simon Backx 2e85ae98be
🐛 Fixed sending emails from email domain that includes www subdomain (#15348) 
fixes https://github.com/TryGhost/Team/issues/1855
fixes https://github.com/TryGhost/Team/issues/1866

This commit moves all duplicate methods to get the support email address to a single location. Also methods to get the default email domain are moved.

For the location, I initially wanted to put it at the settings service. But that service doesn't feel like the right place. Instead I created a new settings helpers service. This service takes the settingsCache, urlUtils and config and calculates some special 'calculated' settings based on those:

- Support email methods
- Stripe (active) keys / stripe connected (also removed some duplicate code that calculated the keys in a couple of places)
- All the calculated settings are moved to the settings helpers

I'm not 100% confident in whether this is the right place to put the helpers. Suggestions are welcome.
2022-09-02 16:57:59 +02:00
..
lib 🐛 Fixed sending emails from email domain that includes www subdomain (#15348) 2022-09-02 16:57:59 +02:00
test 🐛 Fixed sending emails from email domain that includes www subdomain (#15348) 2022-09-02 16:57:59 +02:00
.eslintrc.js Added staff service to manage email alert notifications 2022-08-25 18:01:52 +05:30
index.js Added staff service to manage email alert notifications 2022-08-25 18:01:52 +05:30
package.json Added staff service to manage email alert notifications 2022-08-25 18:01:52 +05:30
README.md Added staff service to manage email alert notifications 2022-08-25 18:01:52 +05:30

README.md

Staff Service

Usage

Develop

This is a monorepo package.

Follow the instructions for the top-level repo.

  1. git clone this repo & cd into it as usual
  2. Run yarn to install top-level dependencies.

Test

  • yarn lint run just eslint
  • yarn test run lint and tests