mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 10:59:30 +03:00

History

Kevin Ansfield 03defc274e 🐛 Fixed Admin crash when member filters were focused+blurred without entering a filter value closes https://github.com/TryGhost/Team/issues/1309 closes https://github.com/TryGhost/Team/issues/1336 - the error occurred because the `<Members::FilterValue>` component detaches it's value from the passed in value it was initialized with. Due to the detached handling, after changing the filter type away from the default label filter to a text input based filter, the internal value stayed as `[]` even though the filter type's value was changed. When the blur event was triggered in that state the internal `[]` value was used to update the filter resulting in an invalid filter string - added a quick-fix of assigning the input's value in the blur event handler meaning we get the expected `''` value - allows for passing tests to be created ready for a deeper fix/refactor later - added `nql` dependency and used it in the `GET /members` API mock to match members against the filter param so behaviour matches the real API - tested increase in code size - dev build increased by ~180KB, no difference in prod - added acceptance tests for all current filters and search		2022-02-15 21:38:57 +00:00
..
.github	[chore] adds ember-template-lint and fixes all fixable issues (#2238 )	2022-02-02 16:09:43 +00:00
app	🐛 Fixed Admin crash when member filters were focused+blurred without entering a filter value	2022-02-15 21:38:57 +00:00
config	Removed deprecated ember-keyboard options	2022-01-17 17:38:24 +00:00
lib	Resolved linter errors in `koenig-toolbar.hbs`	2022-02-15 13:46:49 +00:00
mirage	🐛 Fixed Admin crash when member filters were focused+blurred without entering a filter value	2022-02-15 21:38:57 +00:00
public/assets	Replaced icon for changed subscription event in Activity Feed	2022-02-15 17:03:35 +00:00
tests	🐛 Fixed Admin crash when member filters were focused+blurred without entering a filter value	2022-02-15 21:38:57 +00:00
.csscomb.json
.editorconfig
.ember-cli
.eslintignore	Updated Ember dependencies to 3.24 (#2221 )	2022-01-22 11:24:26 +00:00
.eslintrc.js	[chore] migrate to eslint@8 and run --fix (#2256 )	2022-02-10 10:41:36 +00:00
.gitignore	Updated Ember dependencies to 3.24 (#2221 )	2022-01-22 11:24:26 +00:00
.lint-todo	Resolved linter errors in `koenig-toolbar.hbs`	2022-02-15 13:46:49 +00:00
.template-lintrc.js	Disabled linting rule that forbids use of `<style>` elements	2022-02-07 15:22:32 +00:00
.watchmanconfig
ember-cli-build.js	Initial ember-promise-modals implementation	2021-09-13 13:01:12 +01:00
ember-cli-update.json
Gruntfile.js
LICENSE	2022	2022-01-05 12:41:56 +00:00
package.json	🐛 Fixed Admin crash when member filters were focused+blurred without entering a filter value	2022-02-15 21:38:57 +00:00
README.md	2022	2022-01-05 12:41:56 +00:00
renovate.json	Added `faker` to ignored deps in Renovate config	2022-01-06 10:59:24 +00:00
SECURITY.md	Updated links to ghost.org sites	2021-01-19 13:18:59 +13:00
testem.js
yarn.lock	🐛 Fixed Admin crash when member filters were focused+blurred without entering a filter value	2022-02-15 21:38:57 +00:00

README.md

Ghost-Admin

This is the home of Ember.js based admin client that ships with Ghost.

Do you want to set up a Ghost blog? Check the getting started guide

Do you want to modify or contribute to Ghost-Admin? Please read how to install from source and swing by our forum if you need any help 😄

Have a bug or issue?

Bugs and issues (even if they only affect the admin client) should be opened on the core Ghost repository.

Copyright & License

Copyright (c) 2013-2022 Ghost Foundation - Released under the MIT license. Ghost and the Ghost Logo are trademarks of Ghost Foundation Ltd. Please see our trademark policy for info on acceptable usage.