mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-22 02:11:44 +03:00
6161f94910
refs: https://github.com/TryGhost/Toolbox/issues/595 We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default. This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results: - Url matching needs to be done on `url.href` seeaa58b354a4- Null and undefined are not the same thing, there were a few cases of this being confused - Particularly questionable changes in [PostExporter tests](c1a468744b) tracked [here](https://github.com/TryGhost/Team/issues/3505). - A typo seeeaac9c293aMoving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
17 lines
647 B
JavaScript
17 lines
647 B
JavaScript
const assert = require('assert/strict');
|
|
const ObjectID = require('bson-objectid').default;
|
|
const EmailDeliveredEvent = require('../../lib/EmailDeliveredEvent');
|
|
|
|
describe('EmailDeliveredEvent', function () {
|
|
it('exports a static create method to create instances', function () {
|
|
const event = EmailDeliveredEvent.create({
|
|
email: 'test@test.test',
|
|
memberId: new ObjectID().toHexString(),
|
|
emailId: new ObjectID().toHexString(),
|
|
emailRecipientId: new ObjectID().toHexString(),
|
|
timestamp: new Date()
|
|
});
|
|
assert(event instanceof EmailDeliveredEvent);
|
|
});
|
|
});
|