mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-17 05:21:36 +03:00
0e13ef8767
* 🎨 rotation config - every parameter is configureable - increase default number of files to 100 * 🎨 ghost.log location - example: content/logs/http___my_ghost_blog_com_ghost.log - user can change the path to something custom by setting logging.path * 🛠 add response-time as dependency * 🎨 readable PrettyStream - tidy up - generic handling (was important to support more use cases, for example: logging.info({ anyKey: anyValue })) - common log format - less code 🕵🏻 * 🎨 GhostLogger cleanup - remove setLoggers -> this function had too much of redundant code - instead: add smart this.log function - remove logging.request (---> GhostLogger just forwards the values, it doesn't matter if that is a request or not a request) - make .warn .debug .info .error small and smart * 🎨 app.js: add response time as middleware and remove logging.request * 🎨 setStdoutStream and setFileStream - redesign GhostLogger to add CustomLoggers very easily ----> Example CustomLogger function CustomLogger(options) { // Base iterates over defined transports // EXAMPLE: ['stdout', 'elasticsearch'] Base.call(this, options); } util.inherits(...); // OVERRIDE default stdout stream and your own!!! CustomLogger.prototype.setStdoutStream = function() {} // add a new stream // get's called automatically when transport elasticsearch is defined CustomLogger.prototype.setElasticsearchStream = function() {} * 🎨 log into multiple file by default - content/logs/domain.error.log --> contains only the errors - content/logs/domain.log --> contains everything - rotation for both files * 🔥 remove logging.debug and use npm debug only * ✨ shortcuts for mode and level * 🎨 jshint/jscs * 🎨 stdout as much as possible for an error * 🎨 fix tests * 🎨 remove req.ip from log output, remove response-time dependency * 🎨 create middleware for logging - added TODO to move logging middleware to ignition
31 lines
800 B
JavaScript
31 lines
800 B
JavaScript
var uuid = require('node-uuid'),
|
|
logging = require('../logging');
|
|
|
|
/**
|
|
* @TODO:
|
|
* - move middleware to ignition?
|
|
*/
|
|
module.exports = function logRequest(req, res, next) {
|
|
var startTime = Date.now(),
|
|
requestId = uuid.v1();
|
|
|
|
function logResponse() {
|
|
res.responseTime = (Date.now() - startTime) + 'ms';
|
|
req.requestId = requestId;
|
|
req.userId = req.user ? (req.user.id ? req.user.id : req.user) : null;
|
|
|
|
if (req.err) {
|
|
logging.error({req: req, res: res, err: req.err});
|
|
} else {
|
|
logging.info({req: req, res: res});
|
|
}
|
|
|
|
res.removeListener('finish', logResponse);
|
|
res.removeListener('close', logResponse);
|
|
}
|
|
|
|
res.on('finish', logResponse);
|
|
res.on('close', logResponse);
|
|
next();
|
|
};
|