Ghost/ghost/admin/app/components/modals/newsletters
Kevin Ansfield 060d791a63 Removed need for .get() with settings service
no issue

The `settings` service has been a source of confusion when writing with modern Ember patterns because it's use of the deprecated `ProxyMixin` forced all property access/setting to go via `.get()` and `.set()` whereas the rest of the system has mostly (there are a few other uses of ProxyObjects remaining) eliminated the use of the non-native get/set methods.

- removed use of `ProxyMixin` in the `settings` service by grabbing the attributes off the setting model after fetching and using `Object.defineProperty()` to add native getters/setters that pass through to the model's getters/setters. Ember's autotracking automatically works across the native getters/setters so we can then use the service as if it was any other native object
- updated all code to use `settings.{attrName}` directly for getting/setting instead of `.get()` and `.set()`
- removed use of observer in the `customViews` service because it was being set up before the native properties had been added on the settings service meaning autotracking wasn't able to set up properly
2022-10-07 16:14:57 +01:00
..
edit Removed need for .get() with settings service 2022-10-07 16:14:57 +01:00
confirm-archive.hbs Added newsletter archiving tests 2022-06-02 10:39:17 +02:00
confirm-newsletter-email.hbs Added tests for editing newsletters 2022-05-18 13:14:38 +02:00
confirm-unarchive.hbs Added newsletter archiving tests 2022-06-02 10:39:17 +02:00
edit.hbs Added tests for unsaved newsletter changes 2022-05-18 15:57:02 +02:00
edit.js Open first section by default in email settings 2022-08-17 11:42:35 +02:00
new.hbs Added basic newsletter creation test 2022-04-28 10:50:27 +02:00
new.js Fixed subscribe count on adding new newsletter (#2402) 2022-05-18 20:44:42 +05:30
verify-newsletter-email.hbs Updated copy for newsletter email verification popup 2022-09-16 13:40:44 +05:30
verify-newsletter-email.js Switched to a minimal form when creating a newsletter (#2356) 2022-04-27 10:36:43 +01:00