mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-15 19:52:01 +03:00
060d791a63
no issue
The `settings` service has been a source of confusion when writing with modern Ember patterns because it's use of the deprecated `ProxyMixin` forced all property access/setting to go via `.get()` and `.set()` whereas the rest of the system has mostly (there are a few other uses of ProxyObjects remaining) eliminated the use of the non-native get/set methods.
- removed use of `ProxyMixin` in the `settings` service by grabbing the attributes off the setting model after fetching and using `Object.defineProperty()` to add native getters/setters that pass through to the model's getters/setters. Ember's autotracking automatically works across the native getters/setters so we can then use the service as if it was any other native object
- updated all code to use `settings.{attrName}` directly for getting/setting instead of `.get()` and `.set()`
- removed use of observer in the `customViews` service because it was being set up before the native properties had been added on the settings service meaning autotracking wasn't able to set up properly
|
||
|---|---|---|
| .. | ||
| design | ||
| integration/webhooks | ||
| integrations | ||
| newsletters | ||
| staff | ||
| code-injection.js | ||
| design.js | ||
| general.js | ||
| history.js | ||
| integration.js | ||
| integrations.js | ||
| labs.js | ||
| members-email.js | ||
| membership.js | ||
| navigation.js | ||
| newsletters.js | ||
| theme-install.js | ||