mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-23 22:11:09 +03:00
6161f94910
refs: https://github.com/TryGhost/Toolbox/issues/595 We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default. This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results: - Url matching needs to be done on `url.href` seeaa58b354a4- Null and undefined are not the same thing, there were a few cases of this being confused - Particularly questionable changes in [PostExporter tests](c1a468744b) tracked [here](https://github.com/TryGhost/Team/issues/3505). - A typo seeeaac9c293aMoving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
49 lines
1.4 KiB
JavaScript
49 lines
1.4 KiB
JavaScript
const assert = require('assert/strict');
|
|
const extractApiKey = require('../index');
|
|
|
|
describe('Extract API Key', function () {
|
|
it('Returns nulls for a request without any key', function () {
|
|
const {key, type} = extractApiKey({
|
|
query: {
|
|
filter: 'status:active'
|
|
}
|
|
});
|
|
|
|
assert.equal(key, null);
|
|
assert.equal(type, null);
|
|
});
|
|
|
|
it('Extracts Content API key from the request', function () {
|
|
const {key, type} = extractApiKey({
|
|
query: {
|
|
key: '123thekey'
|
|
}
|
|
});
|
|
|
|
assert.equal(key, '123thekey');
|
|
assert.equal(type, 'content');
|
|
});
|
|
|
|
it('Extracts Admin API key from the request', function () {
|
|
const {key, type} = extractApiKey({
|
|
headers: {
|
|
authorization: 'Ghost eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCIsImtpZCI6IjYyNzM4MjQzNDZiZjUxZjNhYWI5OTA5OSJ9.eyJpYXQiOjE2NTIxNjUyNDQsImV4cCI6MTY1MjE2NTU0NCwiYXVkIjoiL3YyL2FkbWluLyJ9.VdPOZ4XffgYd8qn_46zlJR3jW_rPZTw70COkG5IYIuU'
|
|
}
|
|
});
|
|
|
|
assert.equal(key, '6273824346bf51f3aab99099');
|
|
assert.equal(type, 'admin');
|
|
});
|
|
|
|
it('Returns null if malformatted Admin API Key', function () {
|
|
const {key, type} = extractApiKey({
|
|
headers: {
|
|
authorization: 'Ghost incorrectformat'
|
|
}
|
|
});
|
|
|
|
assert.equal(key, null);
|
|
assert.equal(type, 'admin');
|
|
});
|
|
});
|