mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-02 08:13:34 +03:00
b4cdc85a59
refs https://github.com/TryGhost/Ghost/issues/6949 Handle version mismatch errors by: - displaying an alert asking the user to copy any data and refresh - disabling navigation so that unsaved data is not accidentally lost Detailed changes: - add `error` action to application route for global route-based error handling - remove 404-handler mixin, move logic into app route error handler - update `.catch` in validation-engine so that promises are rejected with the original error objects - add `VersionMismatchError` and `isVersionMismatchError` to ajax service - add `upgrade-status` service - has a method to trigger the alert and toggle the "upgrade required" mode - is injected into all routes by default so that it can be checked before transitioning - add `Route` override - updates the `willTransition` hook to check the `upgrade-status` service and abort the transition if we're in "upgrade required" mode - update notifications `showAPIError` method to handle version mismatch errors - update any areas where we were catching ajax errors manually so that the version mismatch error handling is obeyed - fix redirect tests in editor acceptance test - fix mirage's handling of 404s for unknown posts in get post requests - adjust alert z-index to to appear above modal backgrounds
192 lines
7.7 KiB
JavaScript
192 lines
7.7 KiB
JavaScript
/* jshint expr:true */
|
|
import { expect, assert } from 'chai';
|
|
import { describeModule, it } from 'ember-mocha';
|
|
import Ember from 'ember';
|
|
import NavItem from 'ghost-admin/models/navigation-item';
|
|
|
|
const {
|
|
run,
|
|
Object: EmberObject
|
|
} = Ember;
|
|
|
|
const navSettingJSON = `[
|
|
{"label":"Home","url":"/"},
|
|
{"label":"JS Test","url":"javascript:alert('hello');"},
|
|
{"label":"About","url":"/about"},
|
|
{"label":"Sub Folder","url":"/blah/blah"},
|
|
{"label":"Telephone","url":"tel:01234-567890"},
|
|
{"label":"Mailto","url":"mailto:test@example.com"},
|
|
{"label":"External","url":"https://example.com/testing?query=test#anchor"},
|
|
{"label":"No Protocol","url":"//example.com"}
|
|
]`;
|
|
|
|
describeModule(
|
|
'controller:settings/navigation',
|
|
'Unit: Controller: settings/navigation',
|
|
{
|
|
// Specify the other units that are required for this test.
|
|
needs: [
|
|
'service:config',
|
|
'service:notifications',
|
|
'model:navigation-item',
|
|
'service:ajax',
|
|
'service:ghostPaths',
|
|
'service:upgrade-status'
|
|
]
|
|
},
|
|
function () {
|
|
it('blogUrl: captures config and ensures trailing slash', function () {
|
|
let ctrl = this.subject();
|
|
ctrl.set('config.blogUrl', 'http://localhost:2368/blog');
|
|
expect(ctrl.get('blogUrl')).to.equal('http://localhost:2368/blog/');
|
|
});
|
|
|
|
it('init: creates a new navigation item', function () {
|
|
let ctrl = this.subject();
|
|
|
|
run(() => {
|
|
expect(ctrl.get('newNavItem')).to.exist;
|
|
expect(ctrl.get('newNavItem.isNew')).to.be.true;
|
|
});
|
|
});
|
|
|
|
it('blogUrl: captures config and ensures trailing slash', function () {
|
|
let ctrl = this.subject();
|
|
ctrl.set('config.blogUrl', 'http://localhost:2368/blog');
|
|
expect(ctrl.get('blogUrl')).to.equal('http://localhost:2368/blog/');
|
|
});
|
|
|
|
it('save: validates nav items', function (done) {
|
|
let ctrl = this.subject();
|
|
|
|
run(() => {
|
|
ctrl.set('model', EmberObject.create({navigation: [
|
|
NavItem.create({label: 'First', url: '/'}),
|
|
NavItem.create({label: '', url: '/second'}),
|
|
NavItem.create({label: 'Third', url: ''})
|
|
]}));
|
|
// blank item won't get added because the last item is incomplete
|
|
expect(ctrl.get('model.navigation.length')).to.equal(3);
|
|
|
|
ctrl.save().then(function passedValidation() {
|
|
assert(false, 'navigationItems weren\'t validated on save');
|
|
done();
|
|
}).catch(function failedValidation() {
|
|
let navItems = ctrl.get('model.navigation');
|
|
expect(navItems[0].get('errors').toArray()).to.be.empty;
|
|
expect(navItems[1].get('errors.firstObject.attribute')).to.equal('label');
|
|
expect(navItems[2].get('errors.firstObject.attribute')).to.equal('url');
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
|
|
it('save: ignores blank last item when saving', function (done) {
|
|
let ctrl = this.subject();
|
|
|
|
run(() => {
|
|
ctrl.set('model', EmberObject.create({navigation: [
|
|
NavItem.create({label: 'First', url: '/'}),
|
|
NavItem.create({label: '', url: ''})
|
|
]}));
|
|
|
|
expect(ctrl.get('model.navigation.length')).to.equal(2);
|
|
|
|
ctrl.save().then(function passedValidation() {
|
|
assert(false, 'navigationItems weren\'t validated on save');
|
|
done();
|
|
}).catch(function failedValidation() {
|
|
let navItems = ctrl.get('model.navigation');
|
|
expect(navItems[0].get('errors').toArray()).to.be.empty;
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
|
|
it('action - addItem: adds item to navigationItems', function () {
|
|
let ctrl = this.subject();
|
|
|
|
run(() => {
|
|
ctrl.set('model', EmberObject.create({navigation: [
|
|
NavItem.create({label: 'First', url: '/first', last: true})
|
|
]}));
|
|
});
|
|
|
|
expect(ctrl.get('model.navigation.length')).to.equal(1);
|
|
|
|
ctrl.set('newNavItem.label', 'New');
|
|
ctrl.set('newNavItem.url', '/new');
|
|
|
|
run(() => {
|
|
ctrl.send('addItem');
|
|
});
|
|
|
|
expect(ctrl.get('model.navigation.length')).to.equal(2);
|
|
expect(ctrl.get('model.navigation.lastObject.label')).to.equal('New');
|
|
expect(ctrl.get('model.navigation.lastObject.url')).to.equal('/new');
|
|
expect(ctrl.get('model.navigation.lastObject.isNew')).to.be.false;
|
|
expect(ctrl.get('newNavItem.label')).to.be.blank;
|
|
expect(ctrl.get('newNavItem.url')).to.be.blank;
|
|
expect(ctrl.get('newNavItem.isNew')).to.be.true;
|
|
});
|
|
|
|
it('action - addItem: doesn\'t insert new item if last object is incomplete', function () {
|
|
let ctrl = this.subject();
|
|
|
|
run(() => {
|
|
ctrl.set('model', EmberObject.create({navigation: [
|
|
NavItem.create({label: '', url: '', last: true})
|
|
]}));
|
|
expect(ctrl.get('model.navigation.length')).to.equal(1);
|
|
ctrl.send('addItem');
|
|
expect(ctrl.get('model.navigation.length')).to.equal(1);
|
|
});
|
|
});
|
|
|
|
it('action - deleteItem: removes item from navigationItems', function () {
|
|
let ctrl = this.subject();
|
|
let navItems = [
|
|
NavItem.create({label: 'First', url: '/first'}),
|
|
NavItem.create({label: 'Second', url: '/second', last: true})
|
|
];
|
|
|
|
run(() => {
|
|
ctrl.set('model', EmberObject.create({navigation: navItems}));
|
|
expect(ctrl.get('model.navigation').mapBy('label')).to.deep.equal(['First', 'Second']);
|
|
ctrl.send('deleteItem', ctrl.get('model.navigation.firstObject'));
|
|
expect(ctrl.get('model.navigation').mapBy('label')).to.deep.equal(['Second']);
|
|
});
|
|
});
|
|
|
|
it('action - reorderItems: updates navigationItems list', function () {
|
|
let ctrl = this.subject();
|
|
let navItems = [
|
|
NavItem.create({label: 'First', url: '/first'}),
|
|
NavItem.create({label: 'Second', url: '/second', last: true})
|
|
];
|
|
|
|
run(() => {
|
|
ctrl.set('model', EmberObject.create({navigation: navItems}));
|
|
expect(ctrl.get('model.navigation').mapBy('label')).to.deep.equal(['First', 'Second']);
|
|
ctrl.send('reorderItems', navItems.reverseObjects());
|
|
expect(ctrl.get('model.navigation').mapBy('label')).to.deep.equal(['Second', 'First']);
|
|
});
|
|
});
|
|
|
|
it('action - updateUrl: updates URL on navigationItem', function () {
|
|
let ctrl = this.subject();
|
|
let navItems = [
|
|
NavItem.create({label: 'First', url: '/first'}),
|
|
NavItem.create({label: 'Second', url: '/second', last: true})
|
|
];
|
|
|
|
run(() => {
|
|
ctrl.set('model', EmberObject.create({navigation: navItems}));
|
|
expect(ctrl.get('model.navigation').mapBy('url')).to.deep.equal(['/first', '/second']);
|
|
ctrl.send('updateUrl', '/new', ctrl.get('model.navigation.firstObject'));
|
|
expect(ctrl.get('model.navigation').mapBy('url')).to.deep.equal(['/new', '/second']);
|
|
});
|
|
});
|
|
}
|
|
);
|