mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-06 19:07:37 +03:00
0aff9f33d9
refs https://github.com/TryGhost/Ghost/issues/3658 - the `validateSchema` helper was a bit broken - if you add a user without email, you will receive a database error - but the validation error should catch that email is passed with null - it was broken, because: - A: it called `toJSON` -> this can remove properties from the output (e.g. password) - B: we only validated fields, which were part of the JSON data (model.hasOwnProperty) - we now differentiate between schema validation for update and insert - fixed one broken import test - if you import a post without a status, it should not error - it falls back to the default value - removed user model `onValidate` - the user model added a custom implementation of `onValidate`, because of a bug which we experienced (see https://github.com/TryGhost/Ghost/issues/3638) - with the refactoring this is no longer required - we only validate fields which have changed when updating resources - also, removed extra safe catch when logging in (no longer needed - unit tested) - add lot's of unit tests to proof the code change - always call the base class, except you have a good reason |
||
|---|---|---|
| .. | ||
| adapters | ||
| api | ||
| apps | ||
| config | ||
| controllers | ||
| data | ||
| helpers | ||
| lib | ||
| models | ||
| public | ||
| services | ||
| web | ||
| filters_spec.js | ||