mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-21 01:41:46 +03:00
0c54541b4d
closes #8808 Problem: - In certain cases, particularly in production mode, errors would be hidden - E.g. fatal theme errors could not be seen, users instead saw "Failed to lookup view 'error' in views directory" - This is extremely unhelpful, particularly for people upgrading from 1.0.0 or 1.0.1 where the disqus rule was added afterwards and modified casper would error Solution: - Ensure that we properly setup handlebars when we throw an error - If engines is not set, set all the view engine related properties
131 lines
4.3 KiB
JavaScript
131 lines
4.3 KiB
JavaScript
var _ = require('lodash'),
|
|
hbs = require('express-hbs'),
|
|
config = require('../config'),
|
|
errors = require('../errors'),
|
|
i18n = require('../i18n'),
|
|
templates = require('../controllers/frontend/templates'),
|
|
escapeExpression = hbs.Utils.escapeExpression,
|
|
_private = {},
|
|
errorHandler = {};
|
|
|
|
/**
|
|
* This is a bare minimum setup, which allows us to render the error page
|
|
* It uses the {{asset}} helper, and nothing more
|
|
*/
|
|
_private.createHbsEngine = function createHbsEngine() {
|
|
var engine = hbs.create();
|
|
engine.registerHelper('asset', require('../helpers/asset'));
|
|
|
|
return engine.express4();
|
|
};
|
|
|
|
/**
|
|
* Get an error ready to be shown the the user
|
|
*
|
|
* @TODO: support multiple errors within one single error, see https://github.com/TryGhost/Ghost/issues/7116#issuecomment-252231809
|
|
*/
|
|
_private.prepareError = function prepareError(err, req, res, next) {
|
|
if (_.isArray(err)) {
|
|
err = err[0];
|
|
}
|
|
|
|
if (!errors.utils.isIgnitionError(err)) {
|
|
// We need a special case for 404 errors
|
|
// @TODO look at adding this to the GhostError class
|
|
if (err.statusCode && err.statusCode === 404) {
|
|
err = new errors.NotFoundError({
|
|
err: err
|
|
});
|
|
} else {
|
|
err = new errors.GhostError({
|
|
err: err,
|
|
message: err.message,
|
|
statusCode: err.statusCode
|
|
});
|
|
}
|
|
}
|
|
|
|
// used for express logging middleware see core/server/app.js
|
|
req.err = err;
|
|
|
|
// alternative for res.status();
|
|
res.statusCode = err.statusCode;
|
|
|
|
// never cache errors
|
|
res.set({
|
|
'Cache-Control': 'no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0'
|
|
});
|
|
|
|
next(err);
|
|
};
|
|
|
|
_private.JSONErrorRenderer = function JSONErrorRenderer(err, req, res, /*jshint unused:false */ next) {
|
|
// @TODO: jsonapi errors format (http://jsonapi.org/format/#error-objects)
|
|
res.json({
|
|
errors: [{
|
|
message: err.message,
|
|
context: err.context,
|
|
errorType: err.errorType,
|
|
errorDetails: err.errorDetails
|
|
}]
|
|
});
|
|
};
|
|
|
|
_private.HTMLErrorRenderer = function HTMLErrorRender(err, req, res, /*jshint unused:false */ next) {
|
|
var templateData = {
|
|
message: err.message,
|
|
code: err.statusCode,
|
|
errorDetails: err.errorDetails || []
|
|
};
|
|
|
|
// It can be that something went wrong with the theme or otherwise loading handlebars
|
|
// This ensures that no matter what res.render will work here
|
|
if (_.isEmpty(req.app.engines)) {
|
|
req.app.engine('hbs', _private.createHbsEngine());
|
|
req.app.set('view engine', 'hbs');
|
|
req.app.set('views', config.get('paths').defaultViews);
|
|
}
|
|
|
|
res.render(templates.error(err.statusCode), templateData, function renderResponse(err, html) {
|
|
if (!err) {
|
|
return res.send(html);
|
|
}
|
|
|
|
// And then try to explain things to the user...
|
|
// Cheat and output the error using handlebars escapeExpression
|
|
return res.status(500).send(
|
|
'<h1>' + i18n.t('errors.errors.oopsErrorTemplateHasError') + '</h1>' +
|
|
'<p>' + i18n.t('errors.errors.encounteredError') + '</p>' +
|
|
'<pre>' + escapeExpression(err.message || err) + '</pre>' +
|
|
'<br ><p>' + i18n.t('errors.errors.whilstTryingToRender') + '</p>' +
|
|
err.statusCode + ' ' + '<pre>' + escapeExpression(err.message || err) + '</pre>'
|
|
);
|
|
});
|
|
};
|
|
|
|
errorHandler.resourceNotFound = function resourceNotFound(req, res, next) {
|
|
// TODO, handle unknown resources & methods differently, so that we can also produce
|
|
// 405 Method Not Allowed
|
|
next(new errors.NotFoundError({message: i18n.t('errors.errors.resourceNotFound')}));
|
|
};
|
|
|
|
errorHandler.pageNotFound = function pageNotFound(req, res, next) {
|
|
next(new errors.NotFoundError({message: i18n.t('errors.errors.pageNotFound')}));
|
|
};
|
|
|
|
errorHandler.handleJSONResponse = [
|
|
// Make sure the error can be served
|
|
_private.prepareError,
|
|
// Render the error using JSON format
|
|
_private.JSONErrorRenderer
|
|
];
|
|
|
|
errorHandler.handleHTMLResponse = [
|
|
// Make sure the error can be served
|
|
_private.prepareError,
|
|
// Render the error using HTML format
|
|
_private.HTMLErrorRenderer
|
|
];
|
|
|
|
module.exports = errorHandler;
|