TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-01 05:50:35 +03:00
Code Issues Projects Releases Wiki Activity
0c743d67af
Ghost/ghost
History
Rishabh Garg 0c743d67af
🐛 Fixed member newsletter subscription not saving in Admin (#16490) 
fixes https://github.com/TryGhost/Team/issues/2783 
refs cb05fae5a3

The root cause of the issue was the fact we no longer checked for lack of `newsletters` property on member data before checking its `subscribed` property which is now deprecated. This caused a cascading effect where `subscribed:false` property on a member overrides the value for `newsletters` data. The check was accidentally removed in a previous bug fix.

So for members that were not subscribed to any newsletters, saving a newsletter subscription failed as they had their `subscribed` set to `false`, and it was resetting the newsletter subscription to empty always.
2023-03-24 23:29:49 +05:30
..
adapter-cache-memory-ttl Update dependency @isaacs/ttlcache to v1.2.2 2023-03-23 20:20:25 +00:00
adapter-cache-redis Update Test & linting packages 2023-03-13 02:36:20 +00:00
adapter-manager Update Test & linting packages 2023-03-13 02:36:20 +00:00
admin v5.40.0 2023-03-24 16:03:04 +00:00
api-framework Update Test & linting packages 2023-03-13 02:36:20 +00:00
api-version-compatibility-service Update Test & linting packages 2023-03-13 02:36:20 +00:00
audience-feedback Update Test & linting packages 2023-03-13 02:36:20 +00:00
bootstrap-socket Update Test & linting packages 2023-03-13 02:36:20 +00:00
constants Update Test & linting packages 2023-03-13 02:36:20 +00:00
core 🐛 Fixed member newsletter subscription not saving in Admin (#16490) 2023-03-24 23:29:49 +05:30
custom-theme-settings-service Update Test & linting packages 2023-03-13 02:36:20 +00:00
data-generator Fixed the reply-to address for newsletters in data generator 2023-03-22 14:56:51 +00:00
domain-events Update @tryghost 2023-03-02 09:47:02 +01:00
dynamic-routing-events Update Test & linting packages 2023-03-13 02:36:20 +00:00
email-analytics-provider-mailgun Update Test & linting packages 2023-03-13 02:36:20 +00:00
email-analytics-service Update Test & linting packages 2023-03-13 02:36:20 +00:00
email-content-generator Update dependency fs-extra to v11.1.1 2023-03-21 07:35:30 +01:00
email-events Update Test & linting packages 2023-03-13 02:36:20 +00:00
email-service Fixed issue with email template in Outlook (#16486) 2023-03-24 14:54:16 +01:00
email-suppression-list Update Test & linting packages 2023-03-13 02:36:20 +00:00
event-aware-cache-wrapper Update Test & linting packages 2023-03-13 02:36:20 +00:00
express-dynamic-redirects Update dependency c8 to v7.13.0 2023-02-16 22:15:50 +00:00
external-media-inliner Update Test & linting packages 2023-03-13 02:36:20 +00:00
extract-api-key Fixed full Admin test suite running during unit tests 2022-08-15 15:34:52 +02:00
html-to-plaintext Update dependency c8 to v7.13.0 2023-02-16 22:15:50 +00:00
i18n Add i18n context 2023-03-23 12:07:12 -04:00
importer-handler-content-files Fixed root zip media/files copying during import 2023-03-16 22:48:57 +01:00
importer-revue Fixed random unit test failure for revue importer 2023-03-21 10:46:13 +01:00
job-manager Update Test & linting packages 2023-03-13 02:36:20 +00:00
link-redirects Update Test & linting packages 2023-03-13 02:36:20 +00:00
link-replacer Update Test & linting packages 2023-03-13 02:36:20 +00:00
link-tracking Update Test & linting packages 2023-03-13 02:36:20 +00:00
magic-link Update Test & linting packages 2023-03-13 02:36:20 +00:00
mailgun-client Update Test & linting packages 2023-03-13 02:36:20 +00:00
member-attribution Fixed incorrect newsletter ref for internal links 2023-03-17 20:55:52 +05:30
member-events Removed circular dependency definition 2023-03-23 08:58:59 +01:00
members-api 🐛 Fixed member newsletter subscription not saving in Admin (#16490) 2023-03-24 23:29:49 +05:30
members-csv Update dependency fs-extra to v11.1.1 2023-03-21 07:35:30 +01:00
members-events-service Update Test & linting packages 2023-03-13 02:36:20 +00:00
members-importer Update dependency fs-extra to v11.1.1 2023-03-21 07:35:30 +01:00
members-ssr Update Test & linting packages 2023-03-13 02:36:20 +00:00
mentions-email-report Update Test & linting packages 2023-03-15 21:52:02 +00:00
milestones Added handling for initial and skipped Milestones (#16405) 2023-03-13 19:01:11 +02:00
minifier Update Test & linting packages 2023-03-13 02:36:20 +00:00
mw-api-version-mismatch Update Test & linting packages 2023-03-13 02:36:20 +00:00
mw-cache-control Update Test & linting packages 2023-03-13 02:36:20 +00:00
mw-error-handler Update Test & linting packages 2023-03-13 02:36:20 +00:00
mw-session-from-token Update Test & linting packages 2023-03-13 02:36:20 +00:00
mw-update-user-last-seen Update Test & linting packages 2023-03-13 02:36:20 +00:00
mw-version-match Update Test & linting packages 2023-03-13 02:36:20 +00:00
mw-vhost Update dependency c8 to v7.13.0 2023-02-16 22:15:50 +00:00
oembed-service Disabled got retries in testing environment 2023-03-24 11:55:57 +01:00
offers Update Test & linting packages 2023-03-13 02:36:20 +00:00
package-json Update dependency fs-extra to v11.1.1 2023-03-21 07:35:30 +01:00
payments Update Test & linting packages 2023-03-13 02:36:20 +00:00
portal Update sentry-javascript monorepo to v7.44.2 2023-03-21 15:10:15 +01:00
posts-service Added posts exporter implementation (#16467) 2023-03-22 09:08:35 +01:00
referrers Update Test & linting packages 2023-03-13 02:36:20 +00:00
security Update Test & linting packages 2023-03-13 02:36:20 +00:00
session-service Update Test & linting packages 2023-03-13 02:36:20 +00:00
settings-path-manager Update Test & linting packages 2023-03-13 02:36:20 +00:00
slack-notifications Disabled got retries in testing environment 2023-03-24 11:55:57 +01:00
sodo-search Update dependency @testing-library/react to v12.1.5 2023-03-17 23:38:13 +00:00
staff-service ✨ Moved Milestone emails to GA 2023-03-23 17:35:23 +00:00
stats-service Update dependency sqlite3 to v5.1.6 2023-03-15 07:51:08 +01:00
stripe Update Test & linting packages 2023-03-13 02:36:20 +00:00
tiers Update @tryghost 2023-03-10 09:52:02 +01:00
update-check-service Update Test & linting packages 2023-03-13 02:36:20 +00:00
verification-trigger Prevent errors during the verification trigger tests 2023-03-24 12:32:28 +00:00
version-notifications-data-service Update Test & linting packages 2023-03-13 02:36:20 +00:00
webmentions Updated fallback for storing source site title 2023-03-21 16:09:21 +05:30