Kevin Ansfield 060d791a63 Removed need for .get() with settings service ... no issue The `settings` service has been a source of confusion when writing with modern Ember patterns because it's use of the deprecated `ProxyMixin` forced all property access/setting to go via `.get()` and `.set()` whereas the rest of the system has mostly (there are a few other uses of ProxyObjects remaining) eliminated the use of the non-native get/set methods. - removed use of `ProxyMixin` in the `settings` service by grabbing the attributes off the setting model after fetching and using `Object.defineProperty()` to add native getters/setters that pass through to the model's getters/setters. Ember's autotracking automatically works across the native getters/setters so we can then use the service as if it was any other native object - updated all code to use `settings.{attrName}` directly for getting/setting instead of `.get()` and `.set()` - removed use of observer in the `customViews` service because it was being set up before the native properties had been added on the settings service meaning autotracking wasn't able to set up properly		2022-10-07 16:14:57 +01:00
..
amp.js	Removed need for .get() with settings service	2022-10-07 16:14:57 +01:00
firstpromoter.js	Removed need for .get() with settings service	2022-10-07 16:14:57 +01:00
slack.js	Removed need for .get() with settings service	2022-10-07 16:14:57 +01:00
unsplash.js	Removed need for .get() with settings service	2022-10-07 16:14:57 +01:00
zapier.js	[chore] migrate to eslint@8 and run --fix (#2256)	2022-02-10 10:41:36 +00:00