mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-23 10:53:34 +03:00
7b443d4b63
no issue
The `config` service has been a source of confusion when writing with modern Ember patterns because it's use of the deprecated `ProxyMixin` forced all property access/setting to go via `.get()` and `.set()` whereas the rest of the system has mostly (there are a few other uses of ProxyObjects remaining) eliminated the use of the non-native get/set methods.
- removed use of `ProxyMixin` in the `config` service by grabbing the API response after fetching and using `Object.defineProperty()` to add native getters/setters that pass through to a tracked object holding the API response data. Ember's autotracking automatically works across the native getters/setters so we can then use the service as if it was any other native object
- updated all code to use `config.{attrName}` directly for getting/setting instead of `.get()` and `.set()`
- removed unnecessary async around `config.availableTimezones` which wasn't making any async calls
52 lines
1.6 KiB
JavaScript
52 lines
1.6 KiB
JavaScript
import Controller from '@ember/controller';
|
|
import {inject as service} from '@ember/service';
|
|
import {task} from 'ember-concurrency';
|
|
|
|
export default class IntegrationsController extends Controller {
|
|
@service settings;
|
|
@service store;
|
|
@service config;
|
|
|
|
_allIntegrations = this.store.peekAll('integration');
|
|
|
|
get zapierDisabled() {
|
|
return this.config.hostSettings?.limits?.customIntegrations?.disabled;
|
|
}
|
|
|
|
// filter over the live query so that the list is automatically updated
|
|
// as integrations are added/removed
|
|
get integrations() {
|
|
return this._allIntegrations.reject((integration) => {
|
|
return integration.isNew || integration.type !== 'custom';
|
|
});
|
|
}
|
|
|
|
// use ember-concurrency so that we can use the derived state to show
|
|
// a spinner only in the integrations list and avoid delaying the whole
|
|
// screen display
|
|
@task
|
|
*fetchIntegrations() {
|
|
return yield this.store.findAll('integration');
|
|
}
|
|
|
|
// used by individual integration routes' `model` hooks
|
|
integrationModelHook(prop, value, route, transition) {
|
|
let preloadedIntegration = this.store.peekAll('integration').findBy(prop, value);
|
|
|
|
if (preloadedIntegration) {
|
|
return preloadedIntegration;
|
|
}
|
|
|
|
return this.fetchIntegrations.perform().then((integrations) => {
|
|
let integration = integrations.findBy(prop, value);
|
|
|
|
if (!integration) {
|
|
let path = transition.intent.url.replace(/^\//, '');
|
|
return route.replaceWith('error404', {path, status: 404});
|
|
}
|
|
|
|
return integration;
|
|
});
|
|
}
|
|
}
|