TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-26 04:13:30 +03:00
Code Issues Projects Releases Wiki Activity
0fb0c6c2b5
Ghost/ghost/recommendations
History
Daniel Lockyer dea639e3f6 🐛 Fixed returning HTTP 500 response when recommendations check fails 
ref ENG-737
ref https://linear.app/tryghost/issue/ENG-737/http-500-errors-from-recommendations-check-endpoint

- it's still possible for `this.#externalRequest.get` to throw, like if
  DNS resolution fails
- we want to try-catch this so we don't throw from this function and
  return a HTTP 500 to the user
- instead, we can just return `undefined`, which is the fallback
- adds a breaking test too
2024-03-12 12:31:44 +01:00
..
src 🐛 Fixed returning HTTP 500 response when recommendations check fails 2024-03-12 12:31:44 +01:00
test 🐛 Fixed returning HTTP 500 response when recommendations check fails 2024-03-12 12:31:44 +01:00
.eslintrc.js Added recommendations CRUD api (#17845) 2023-08-29 15:06:57 +00:00
package.json Updated @tryghost/errors dependency 2024-03-11 17:33:51 +01:00
README.md Added recommendations CRUD api (#17845) 2023-08-29 15:06:57 +00:00
tsconfig.json Added recommendations CRUD api (#17845) 2023-08-29 15:06:57 +00:00

README.md

Recommendations

Usage

Develop

This is a monorepo package.

Follow the instructions for the top-level repo.

  1. git clone this repo & cd into it as usual
  2. Run yarn to install top-level dependencies.

Test

  • yarn lint run just eslint
  • yarn test run lint and tests