mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-29 15:12:58 +03:00
14d762ddc9
no issue - I apparently never added @tryghost/metrics-server as a dependency to ghost/core/package.json. It worked in most cases as a 'phantom dependency' — yarn installs all node_modules in a flat structure, so even though it wasn't a dependency in package.json, it still resolved to the correct package, as long as the typescript packages were all built first. - This passed CI because we explicitly run ts:build on all packages before running tests, and it worked in production because we build the TS packages as part of the docker build. However, when trying to run tests locally, it would sometimes fail unless you explicitly ran nx run-many -t build:ts at the top level before running the tests. - Adding it as a dependency in package.json fixes this problem. |
||
|---|---|---|
| .. | ||
| content | ||
| core | ||
| test | ||
| .c8rc.e2e.json | ||
| .c8rc.json | ||
| .eslintignore | ||
| .eslintrc.js | ||
| .npmignore | ||
| config.development.json | ||
| ghost.js | ||
| index.js | ||
| jsconfig.json | ||
| loggingrc.js | ||
| MigratorConfig.js | ||
| monobundle.js | ||
| package.json | ||
| playwright.config.js | ||