mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-11 09:53:32 +03:00
1882278b5b
- 🛠 add bunyan and prettyjson, remove morgan - ✨ add logging module - GhostLogger class that handles setup of bunyan - PrettyStream for stdout - ✨ config for logging - @TODO: testing level fatal? - ✨ log each request via GhostLogger (express middleware) - @TODO: add errors to output - 🔥 remove errors.updateActiveTheme - we can read the value from config - 🔥 remove 15 helper functions in core/server/errors/index.js - all these functions get replaced by modules: 1. logging 2. error middleware handling for html/json 3. error creation (which will be part of PR #7477) - ✨ add express error handler for html/json - one true error handler for express responses - contains still some TODO's, but they are not high priority for first implementation/integration - this middleware only takes responsibility of either rendering html responses or return json error responses - 🎨 use new express error handler in middleware/index - 404 and 500 handling - 🎨 return error instead of error message in permissions/index.js - the rule for error handling should be: if you call a unit, this unit should return a custom Ghost error - 🎨 wrap serve static module - rule: if you call a module/unit, you should always wrap this error - it's always the same rule - so the caller never has to worry about what comes back - it's always a clear error instance - in this case: we return our notfounderror if serve static does not find the resource - this avoid having checks everywhere - 🎨 replace usages of errors/index.js functions and adapt tests - use logging.error, logging.warn - make tests green - remove some usages of logging and throwing api errors -> because when a request is involved, logging happens automatically - 🐛 return errorDetails to Ghost-Admin - errorDetails is used for Theme error handling - 🎨 use 500er error for theme is missing error in theme-handler - 🎨 extend file rotation to 1w
131 lines
4.4 KiB
JavaScript
131 lines
4.4 KiB
JavaScript
var passport = require('passport'),
|
|
errors = require('../errors'),
|
|
events = require('../events'),
|
|
i18n = require('../i18n'),
|
|
authenticate;
|
|
|
|
function isBearerAutorizationHeader(req) {
|
|
var parts,
|
|
scheme,
|
|
credentials;
|
|
|
|
if (req.headers && req.headers.authorization) {
|
|
parts = req.headers.authorization.split(' ');
|
|
} else if (req.query && req.query.access_token) {
|
|
return true;
|
|
} else {
|
|
return false;
|
|
}
|
|
|
|
if (parts.length === 2) {
|
|
scheme = parts[0];
|
|
credentials = parts[1];
|
|
if (/^Bearer$/i.test(scheme)) {
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
authenticate = {
|
|
// ### Authenticate Client Middleware
|
|
authenticateClient: function authenticateClient(req, res, next) {
|
|
// skip client authentication if bearer token is present
|
|
if (isBearerAutorizationHeader(req)) {
|
|
return next();
|
|
}
|
|
|
|
if (req.query && req.query.client_id) {
|
|
req.body.client_id = req.query.client_id;
|
|
}
|
|
|
|
if (req.query && req.query.client_secret) {
|
|
req.body.client_secret = req.query.client_secret;
|
|
}
|
|
|
|
if (!req.body.client_id || !req.body.client_secret) {
|
|
return next(new errors.UnauthorizedError(
|
|
i18n.t('errors.middleware.auth.accessDenied')),
|
|
i18n.t('errors.middleware.auth.clientCredentialsNotProvided'),
|
|
i18n.t('errors.middleware.auth.forInformationRead', {url: 'http://api.ghost.org/docs/client-authentication'})
|
|
);
|
|
}
|
|
|
|
return passport.authenticate(['oauth2-client-password'], {session: false, failWithError: false},
|
|
function authenticate(err, client) {
|
|
if (err) {
|
|
return next(err); // will generate a 500 error
|
|
}
|
|
|
|
// req.body needs to be null for GET requests to build options correctly
|
|
delete req.body.client_id;
|
|
delete req.body.client_secret;
|
|
|
|
if (!client) {
|
|
return next(new errors.UnauthorizedError(
|
|
i18n.t('errors.middleware.auth.accessDenied')),
|
|
i18n.t('errors.middleware.auth.clientCredentialsNotValid'),
|
|
i18n.t('errors.middleware.auth.forInformationRead', {url: 'http://api.ghost.org/docs/client-authentication'})
|
|
);
|
|
}
|
|
|
|
req.client = client;
|
|
|
|
events.emit('client.authenticated', client);
|
|
return next(null, client);
|
|
}
|
|
)(req, res, next);
|
|
},
|
|
|
|
// ### Authenticate User Middleware
|
|
authenticateUser: function authenticateUser(req, res, next) {
|
|
return passport.authenticate('bearer', {session: false, failWithError: false},
|
|
function authenticate(err, user, info) {
|
|
if (err) {
|
|
return next(err); // will generate a 500 error
|
|
}
|
|
|
|
if (user) {
|
|
req.authInfo = info;
|
|
req.user = user;
|
|
|
|
events.emit('user.authenticated', user);
|
|
return next(null, user, info);
|
|
} else if (isBearerAutorizationHeader(req)) {
|
|
return next(new errors.UnauthorizedError(i18n.t('errors.middleware.auth.accessDenied')));
|
|
} else if (req.client) {
|
|
req.user = {id: 0};
|
|
return next();
|
|
}
|
|
|
|
return next(new errors.UnauthorizedError(i18n.t('errors.middleware.auth.accessDenied')));
|
|
}
|
|
)(req, res, next);
|
|
},
|
|
|
|
// ### Authenticate Ghost.org User
|
|
authenticateGhostUser: function authenticateGhostUser(req, res, next) {
|
|
req.query.code = req.body.authorizationCode;
|
|
|
|
if (!req.query.code) {
|
|
return next(new errors.UnauthorizedError(i18n.t('errors.middleware.auth.accessDenied')));
|
|
}
|
|
|
|
passport.authenticate('ghost', {session: false, failWithError: false}, function authenticate(err, user, info) {
|
|
if (err) {
|
|
return next(err);
|
|
}
|
|
|
|
if (!user) {
|
|
return next(new errors.UnauthorizedError(i18n.t('errors.middleware.auth.accessDenied')));
|
|
}
|
|
|
|
req.authInfo = info;
|
|
req.user = user;
|
|
next();
|
|
})(req, res, next);
|
|
}
|
|
};
|
|
|
|
module.exports = authenticate;
|