mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-22 10:21:36 +03:00
1882278b5b
- 🛠 add bunyan and prettyjson, remove morgan - ✨ add logging module - GhostLogger class that handles setup of bunyan - PrettyStream for stdout - ✨ config for logging - @TODO: testing level fatal? - ✨ log each request via GhostLogger (express middleware) - @TODO: add errors to output - 🔥 remove errors.updateActiveTheme - we can read the value from config - 🔥 remove 15 helper functions in core/server/errors/index.js - all these functions get replaced by modules: 1. logging 2. error middleware handling for html/json 3. error creation (which will be part of PR #7477) - ✨ add express error handler for html/json - one true error handler for express responses - contains still some TODO's, but they are not high priority for first implementation/integration - this middleware only takes responsibility of either rendering html responses or return json error responses - 🎨 use new express error handler in middleware/index - 404 and 500 handling - 🎨 return error instead of error message in permissions/index.js - the rule for error handling should be: if you call a unit, this unit should return a custom Ghost error - 🎨 wrap serve static module - rule: if you call a module/unit, you should always wrap this error - it's always the same rule - so the caller never has to worry about what comes back - it's always a clear error instance - in this case: we return our notfounderror if serve static does not find the resource - this avoid having checks everywhere - 🎨 replace usages of errors/index.js functions and adapt tests - use logging.error, logging.warn - make tests green - remove some usages of logging and throwing api errors -> because when a request is involved, logging happens automatically - 🐛 return errorDetails to Ghost-Admin - errorDetails is used for Theme error handling - 🎨 use 500er error for theme is missing error in theme-handler - 🎨 extend file rotation to 1w
90 lines
2.3 KiB
JavaScript
90 lines
2.3 KiB
JavaScript
var _ = require('lodash'),
|
|
http = require('http'),
|
|
xml = require('xml'),
|
|
config = require('../../config'),
|
|
utils = require('../../utils'),
|
|
logging = require('../../logging'),
|
|
events = require('../../events'),
|
|
i18n = require('../../i18n'),
|
|
pingList;
|
|
|
|
// ToDo: Make this configurable
|
|
pingList = [{
|
|
host: 'blogsearch.google.com',
|
|
path: '/ping/RPC2'
|
|
}, {
|
|
host: 'rpc.pingomatic.com',
|
|
path: '/'
|
|
}];
|
|
|
|
function ping(post) {
|
|
var pingXML,
|
|
title = post.title,
|
|
url = utils.url.urlFor('post', {post: post}, true);
|
|
|
|
// Only ping when in production and not a page
|
|
if (process.env.NODE_ENV !== 'production' || post.page || config.isPrivacyDisabled('useRpcPing')) {
|
|
return;
|
|
}
|
|
|
|
// Don't ping for the welcome to ghost post.
|
|
// This also handles the case where during ghost's first run
|
|
// models.init() inserts this post but permissions.init() hasn't
|
|
// (can't) run yet.
|
|
if (post.slug === 'welcome-to-ghost') {
|
|
return;
|
|
}
|
|
|
|
// Build XML object.
|
|
pingXML = xml({
|
|
methodCall: [{
|
|
methodName: 'weblogUpdate.ping'
|
|
}, {
|
|
params: [{
|
|
param: [{
|
|
value: [{
|
|
string: title
|
|
}]
|
|
}]
|
|
}, {
|
|
param: [{
|
|
value: [{
|
|
string: url
|
|
}]
|
|
}]
|
|
}]
|
|
}]
|
|
}, {declaration: true});
|
|
|
|
// Ping each of the defined services.
|
|
_.each(pingList, function (pingHost) {
|
|
var options = {
|
|
hostname: pingHost.host,
|
|
path: pingHost.path,
|
|
method: 'POST'
|
|
},
|
|
req;
|
|
|
|
req = http.request(options);
|
|
req.write(pingXML);
|
|
req.on('error', function handleError(err) {
|
|
err.context = i18n.t('errors.data.xml.xmlrpc.pingUpdateFailed.error');
|
|
err.help = i18n.t('errors.data.xml.xmlrpc.pingUpdateFailed.help', {url: 'http://support.ghost.org'});
|
|
logging.error(err);
|
|
});
|
|
req.end();
|
|
});
|
|
}
|
|
|
|
function listener(model) {
|
|
ping(model.toJSON());
|
|
}
|
|
|
|
function listen() {
|
|
events.on('post.published', listener);
|
|
}
|
|
|
|
module.exports = {
|
|
listen: listen
|
|
};
|