mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-29 15:12:58 +03:00
1882278b5b
- 🛠 add bunyan and prettyjson, remove morgan - ✨ add logging module - GhostLogger class that handles setup of bunyan - PrettyStream for stdout - ✨ config for logging - @TODO: testing level fatal? - ✨ log each request via GhostLogger (express middleware) - @TODO: add errors to output - 🔥 remove errors.updateActiveTheme - we can read the value from config - 🔥 remove 15 helper functions in core/server/errors/index.js - all these functions get replaced by modules: 1. logging 2. error middleware handling for html/json 3. error creation (which will be part of PR #7477) - ✨ add express error handler for html/json - one true error handler for express responses - contains still some TODO's, but they are not high priority for first implementation/integration - this middleware only takes responsibility of either rendering html responses or return json error responses - 🎨 use new express error handler in middleware/index - 404 and 500 handling - 🎨 return error instead of error message in permissions/index.js - the rule for error handling should be: if you call a unit, this unit should return a custom Ghost error - 🎨 wrap serve static module - rule: if you call a module/unit, you should always wrap this error - it's always the same rule - so the caller never has to worry about what comes back - it's always a clear error instance - in this case: we return our notfounderror if serve static does not find the resource - this avoid having checks everywhere - 🎨 replace usages of errors/index.js functions and adapt tests - use logging.error, logging.warn - make tests green - remove some usages of logging and throwing api errors -> because when a request is involved, logging happens automatically - 🐛 return errorDetails to Ghost-Admin - errorDetails is used for Theme error handling - 🎨 use 500er error for theme is missing error in theme-handler - 🎨 extend file rotation to 1w
33 lines
1.3 KiB
JavaScript
33 lines
1.3 KiB
JavaScript
// # Plural Helper
|
|
// Usage: `{{plural 0 empty='No posts' singular='% post' plural='% posts'}}`
|
|
//
|
|
// pluralises strings depending on item count
|
|
//
|
|
// The 1st argument is the numeric variable which the helper operates on
|
|
// The 2nd argument is the string that will be output if the variable's value is 0
|
|
// The 3rd argument is the string that will be output if the variable's value is 1
|
|
// The 4th argument is the string that will be output if the variable's value is 2+
|
|
|
|
var hbs = require('express-hbs'),
|
|
errors = require('../errors'),
|
|
_ = require('lodash'),
|
|
i18n = require('../i18n'),
|
|
plural;
|
|
|
|
plural = function (number, options) {
|
|
if (_.isUndefined(options.hash) || _.isUndefined(options.hash.empty) ||
|
|
_.isUndefined(options.hash.singular) || _.isUndefined(options.hash.plural)) {
|
|
throw new errors.IncorrectUsage(i18n.t('warnings.helpers.plural.valuesMustBeDefined'));
|
|
}
|
|
|
|
if (number === 0) {
|
|
return new hbs.handlebars.SafeString(options.hash.empty.replace('%', number));
|
|
} else if (number === 1) {
|
|
return new hbs.handlebars.SafeString(options.hash.singular.replace('%', number));
|
|
} else if (number >= 2) {
|
|
return new hbs.handlebars.SafeString(options.hash.plural.replace('%', number));
|
|
}
|
|
};
|
|
|
|
module.exports = plural;
|