TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-20 09:22:49 +03:00
Code Issues Projects Releases Wiki Activity
18e3d38bb0
Ghost/ghost/admin/app
History
Kevin Ansfield a67cb265fc 🐛 Fixed error preventing publish for non-Admin staff users 
refs e3db911108

Contributors/Authors/Editors do not have permissions to fetch members so the request to fetch a member count when checking member host limits fails and blocked publishing because it was treated like a failed limit check.

- prevented the up-front limit check from running for non-Admin staff users. Publishing will still fail for other users if the site is over the hosting plan members limit but the error will be shown later in the flow when the actual publish request is made.
2022-09-27 13:19:02 +01:00
..
adapters Fixed post/page API requests having incorrect ?include= params 2022-09-16 12:54:50 +01:00
authenticators Made session.user a synchronous property rather than a promise 2021-07-08 14:54:31 +01:00
components Added lexical editor design sandbox route 2022-09-27 13:00:16 +01:00
controllers Switched delete snippet modal to new modal pattern (#15468) 2022-09-25 10:54:07 +01:00
errors Improved validation process for members CSV import 2020-07-07 00:28:30 +12:00
helpers Tweaks to how click events are handled based on feedback 2022-09-27 12:29:08 +01:00
initializers Resolved ember-simple-auth deprecations 2022-01-22 00:30:56 +00:00
mixins Fixed invalid shortcuts imports 2022-09-24 13:28:30 +02:00
models Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
modifiers Updated modifiers to resolve ember-modifier@4.x deprecations 2022-08-02 16:54:34 +01:00
routes Deleted unused files 2022-09-24 13:27:54 +02:00
serializers Fixed odd behavior with saving complimentary members 2022-08-17 20:53:34 +05:30
services Merged v5.16.1 into main 2022-09-27 11:21:48 +07:00
session-stores Migrated session-store to native class syntax 2022-02-02 18:41:16 +00:00
styles Removed dots from modal sources table 2022-09-27 13:54:27 +02:00
templates Added lexical editor design sandbox route 2022-09-27 13:00:16 +01:00
transforms Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils 🐛 Fixed error preventing publish for non-Admin staff users 2022-09-27 13:19:02 +01:00
validators Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
app.js Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
index.html Updated loading animation 2022-09-16 13:44:58 +02:00
README.md Renamed "client" references to "admin" 2022-05-17 09:09:14 +01:00
router.js Added lexical editor design sandbox route 2022-09-27 13:00:16 +01:00
transitions.js Removed tour feature 2021-03-02 14:29:26 +00:00

README.md

Ghost Admin App

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)