TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-22 02:11:44 +03:00
Code Issues Projects Releases Wiki Activity
19b8bd2b50
Ghost/ghost/admin-x-settings
History
Hannah Wolfe 6161f94910
Updated to use assert/strict everywhere (#17047) 
refs: https://github.com/TryGhost/Toolbox/issues/595

We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default.

This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results:
- Url matching needs to be done on `url.href` see aa58b354a4
- Null and undefined are not the same thing,  there were a few cases of this being confused
- Particularly questionable changes in [PostExporter tests](c1a468744b) tracked [here](https://github.com/TryGhost/Team/issues/3505).
- A typo see eaac9c293a

Moving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
2023-06-21 09:56:59 +01:00
..
.storybook Added page header component in AdminX 2023-06-14 09:13:00 +02:00
public Updated dev. env. setup for Admin X Settings 2023-05-17 07:47:10 +02:00
src Improved naming in AdminX dirty state handling 2023-06-20 19:59:47 +10:00
test Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
.eslintrc.cjs Removed eslint-plugin-react from AdminX 2023-06-16 15:21:19 +05:30
.yarnrc Updated publish config for admin-x settings 2023-05-16 12:33:37 +05:30
index.html Added new package for admin-x settings 2023-05-16 12:23:24 +05:30
package.json Update dependency @storybook/testing-library to v0.2.0 2023-06-21 08:12:26 +02:00
playwright.config.ts Added playwright config to admin-x-settings (#16941) 2023-06-06 11:29:28 +12:00
postcss.config.cjs Updated dev. env. setup for Admin X Settings 2023-05-17 07:47:10 +02:00
README.md Added --adminX functionality to yarn dev 2023-05-19 10:34:06 +02:00
tailwind.config.cjs Refined official theme list in AdminX 2023-06-14 08:04:57 +02:00
tsconfig.json Added new package for admin-x settings 2023-05-16 12:23:24 +05:30
tsconfig.node.json Added new package for admin-x settings 2023-05-16 12:23:24 +05:30
vite.config.ts Added --adminX functionality to yarn dev 2023-05-19 10:34:06 +02:00

README.md

Admin X Settings

Experimental re-write of Ghost Admin Settings in React

Development

Pre-requisites

  • Run yarn in Ghost monorepo root
  • Run yarn in this directory

Running the development version

Run yarn dev to start the development server to test/develop the settings standalone. This will generate a demo site from the index.html file which renders the app and makes it available on http://localhost:5173

Running inside Admin

Run yarn dev from the top-level repo with --adminX

Develop

This is a monorepo package.

Follow the instructions for the top-level repo.

  1. git clone this repo & cd into it as usual
  2. Run yarn to install top-level dependencies.

Test

  • yarn lint run just eslint
  • yarn test run lint and tests