mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-30 14:22:07 +03:00
e30b9735fa
refs: https://github.com/TryGhost/Team/issues/510 - In the case that host config is provided, keep staff users within the limiti - The definition of a staff user is a user with a role other than Contributor, and whose status is not inactive - Contributors don't count - Suspended (status inactive) users don't count - Locked users DO count - Invited users DO count - You can't invite more staff users whilst there are pending invites - You can't unsuspend a user, or change the role on a user in such a way as will take you over your limit - You can't import staff users - all imported users are automatically set to Contributors - As part of this work, we are changing the default Ghost user to a Contributor otherwise it uses up a staff user Note: there is one known active bug with this commit. - Assume you have one remaining user within your limit. You send an invite, this works. - You cannot "resend" that invite, it will think you're sending a new invite and hit the limit - You must "revoke" that invite first, and create a new one - This bug exists because the resend function uses the add endpoint & does a delete+add, but this hits the permission check before the delete
116 lines
4.0 KiB
JavaScript
116 lines
4.0 KiB
JavaScript
const Promise = require('bluebird');
|
|
const _ = require('lodash');
|
|
const {i18n} = require('../lib/common');
|
|
const errors = require('@tryghost/errors');
|
|
const constants = require('@tryghost/constants');
|
|
const security = require('@tryghost/security');
|
|
const settingsCache = require('../services/settings/cache');
|
|
const limitService = require('../services/limits');
|
|
const ghostBookshelf = require('./base');
|
|
|
|
let Invite;
|
|
let Invites;
|
|
|
|
Invite = ghostBookshelf.Model.extend({
|
|
tableName: 'invites',
|
|
|
|
toJSON: function (unfilteredOptions) {
|
|
const options = Invite.filterOptions(unfilteredOptions, 'toJSON');
|
|
const attrs = ghostBookshelf.Model.prototype.toJSON.call(this, options);
|
|
|
|
delete attrs.token;
|
|
return attrs;
|
|
}
|
|
}, {
|
|
orderDefaultOptions: function orderDefaultOptions() {
|
|
return {};
|
|
},
|
|
|
|
add: function add(data, unfilteredOptions) {
|
|
const options = Invite.filterOptions(unfilteredOptions, 'add');
|
|
data = data || {};
|
|
|
|
if (!options.context || !options.context.internal) {
|
|
data.status = 'pending';
|
|
}
|
|
|
|
data.expires = Date.now() + constants.ONE_WEEK_MS;
|
|
data.token = security.tokens.generateFromEmail({
|
|
email: data.email,
|
|
expires: data.expires,
|
|
secret: settingsCache.get('db_hash')
|
|
});
|
|
|
|
return ghostBookshelf.Model.add.call(this, data, options);
|
|
},
|
|
|
|
async permissible(inviteModel, action, context, unsafeAttrs, loadedPermissions, hasUserPermission, hasApiKeyPermission) {
|
|
const isAdd = (action === 'add');
|
|
|
|
if (isAdd && limitService.isLimited('staff')) {
|
|
// CASE: if your site is limited to a certain number of staff users
|
|
// Inviting a new user requires we check we won't go over the limit
|
|
await limitService.errorIfWouldGoOverLimit('staff');
|
|
}
|
|
|
|
if (!isAdd) {
|
|
if (hasUserPermission && hasApiKeyPermission) {
|
|
return Promise.resolve();
|
|
}
|
|
|
|
return Promise.reject(new errors.NoPermissionError({
|
|
message: i18n.t('errors.models.invite.notEnoughPermission')
|
|
}));
|
|
}
|
|
|
|
// CASE: make sure user is allowed to add a user with this role
|
|
return ghostBookshelf.model('Role')
|
|
.findOne({id: unsafeAttrs.role_id})
|
|
.then((roleToInvite) => {
|
|
if (!roleToInvite) {
|
|
return Promise.reject(new errors.NotFoundError({
|
|
message: i18n.t('errors.api.invites.roleNotFound')
|
|
}));
|
|
}
|
|
|
|
if (roleToInvite.get('name') === 'Owner') {
|
|
return Promise.reject(new errors.NoPermissionError({
|
|
message: i18n.t('errors.api.invites.notAllowedToInviteOwner')
|
|
}));
|
|
}
|
|
|
|
let allowed = [];
|
|
|
|
if (_.some(loadedPermissions.user.roles, {name: 'Owner'}) ||
|
|
_.some(loadedPermissions.user.roles, {name: 'Administrator'})) {
|
|
allowed = ['Administrator', 'Editor', 'Author', 'Contributor'];
|
|
} else if (_.some(loadedPermissions.user.roles, {name: 'Editor'})) {
|
|
allowed = ['Author', 'Contributor'];
|
|
}
|
|
|
|
if (allowed.indexOf(roleToInvite.get('name')) === -1) {
|
|
throw new errors.NoPermissionError({
|
|
message: i18n.t('errors.api.invites.notAllowedToInvite')
|
|
});
|
|
}
|
|
|
|
if (hasUserPermission && hasApiKeyPermission) {
|
|
return Promise.resolve();
|
|
}
|
|
|
|
return Promise.reject(new errors.NoPermissionError({
|
|
message: i18n.t('errors.models.invite.notEnoughPermission')
|
|
}));
|
|
});
|
|
}
|
|
});
|
|
|
|
Invites = ghostBookshelf.Collection.extend({
|
|
model: Invite
|
|
});
|
|
|
|
module.exports = {
|
|
Invite: ghostBookshelf.model('Invite', Invite),
|
|
Invites: ghostBookshelf.collection('Invites', Invites)
|
|
};
|