Ghost/test/unit/server/services/webhooks/webhook-service.test.js
Daniel Lockyer 1a3aa69c68 Re-throw error when attempting to create webhooks
- we catch error arising from creating webhooks and check for specific codes
- if our error does not match one of those codes, we don't propagate the
  error up
- this becomes a problem if saving a webhook fails for some other reason
  because upstream code assumes we return an error or model
- this commit re-throws the error and adds a test that would have caught
  this
2022-03-07 13:54:00 +00:00

38 lines
1.1 KiB
JavaScript

const errors = require('@tryghost/errors');
const should = require('should');
const sinon = require('sinon');
const createWebhookService = require('../../../../../core/server/services/webhooks/webhooks-service');
const models = require('../../../../../core/server/models');
describe('Webhook Service', function () {
before(models.init);
afterEach(function () {
sinon.restore();
});
it('re-throws any unhandled errors', async function () {
sinon.stub(models.Webhook, 'getByEventAndTarget').resolves(null);
sinon.stub(models.Webhook, 'add').throws('CustomTestError');
const webhookService = createWebhookService({WebhookModel: models.Webhook});
const fakeWebhook = {
webhooks: [
{
event: 'post.published',
target_url: 'http://example.com/webhook'
}
]
};
try {
await webhookService.add(fakeWebhook, {});
should.fail('should have thrown');
} catch (err) {
err.name.should.equal('CustomTestError');
}
});
});