mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-12 06:25:51 +03:00
6161f94910
refs: https://github.com/TryGhost/Toolbox/issues/595 We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default. This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results: - Url matching needs to be done on `url.href` seeaa58b354a4- Null and undefined are not the same thing, there were a few cases of this being confused - Particularly questionable changes in [PostExporter tests](c1a468744b) tracked [here](https://github.com/TryGhost/Team/issues/3505). - A typo seeeaac9c293aMoving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
46 lines
1.9 KiB
JavaScript
46 lines
1.9 KiB
JavaScript
const assert = require('assert/strict');
|
|
const {AudienceFeedbackService} = require('../index');
|
|
|
|
describe('audienceFeedbackService', function () {
|
|
it('exported', function () {
|
|
assert.equal(require('../index').AudienceFeedbackService, AudienceFeedbackService);
|
|
});
|
|
|
|
const mockData = {
|
|
uuid: '7b11de3c-dff9-4563-82ae-a281122d201d',
|
|
postId: '634fc3901e0a291855d8b135',
|
|
postTitle: 'somepost',
|
|
score: 1
|
|
};
|
|
|
|
describe('build link', function () {
|
|
it('Can build link to post', async function () {
|
|
const instance = new AudienceFeedbackService({
|
|
urlService: {
|
|
getUrlByResourceId: () => `https://localhost:2368/${mockData.postTitle}/`
|
|
},
|
|
config: {
|
|
baseURL: new URL('https://localhost:2368')
|
|
}
|
|
});
|
|
const link = instance.buildLink(mockData.uuid, mockData.postId, mockData.score);
|
|
const expectedLink = `https://localhost:2368/${mockData.postTitle}/#/feedback/${mockData.postId}/${mockData.score}/?uuid=${mockData.uuid}`;
|
|
assert.equal(link.href, expectedLink);
|
|
});
|
|
|
|
it('Can build link to home page if post wasn\'t published', async function () {
|
|
const instance = new AudienceFeedbackService({
|
|
urlService: {
|
|
getUrlByResourceId: () => `https://localhost:2368/${mockData.postTitle}/404/`
|
|
},
|
|
config: {
|
|
baseURL: new URL('https://localhost:2368')
|
|
}
|
|
});
|
|
const link = instance.buildLink(mockData.uuid, mockData.postId, mockData.score);
|
|
const expectedLink = `https://localhost:2368/#/feedback/${mockData.postId}/${mockData.score}/?uuid=${mockData.uuid}`;
|
|
assert.equal(link.href, expectedLink);
|
|
});
|
|
});
|
|
});
|