mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-18 16:01:40 +03:00
1bce363bd3
refs https://github.com/TryGhost/Toolbox/issues/602 - the new regex allows for the filename to contain seconds, which would have helped prevent a bug we had with migrations being in the wrong order - mentioned filename ordering in the migration review comment to bring that to the forefront of the mind
56 lines
2.1 KiB
YAML
56 lines
2.1 KiB
YAML
name: Migration Review
|
|
on:
|
|
pull_request_target:
|
|
types: [opened]
|
|
paths:
|
|
- 'ghost/core/core/server/data/schema/**'
|
|
- 'ghost/core/core/server/data/migrations/versions/**'
|
|
jobs:
|
|
createComment:
|
|
runs-on: ubuntu-latest
|
|
if: github.repository_owner == 'TryGhost'
|
|
name: Add migration review requirements
|
|
steps:
|
|
- uses: actions/github-script@v6
|
|
with:
|
|
script: |
|
|
github.rest.issues.addLabels({
|
|
issue_number: context.issue.number,
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
labels: ["migration"]
|
|
})
|
|
|
|
- uses: peter-evans/create-or-update-comment@c470f6fd6d4e4aa68bdf7d16e7b5935bde5d01b5
|
|
with:
|
|
issue-number: ${{ github.event.pull_request.number }}
|
|
body: |
|
|
It looks like this PR contains a migration 👀
|
|
Here's the checklist for reviewing migrations:
|
|
|
|
### General requirements
|
|
|
|
- [ ] Satisfies idempotency requirement (both `up()` and `down()`)
|
|
- [ ] Does not reference models
|
|
- [ ] Filename is in the correct format (and correctly ordered)
|
|
- [ ] Targets the next minor version
|
|
- [ ] All code paths have appropriate log messages
|
|
- [ ] Uses the correct utils
|
|
- [ ] Contains a minimal changeset
|
|
- [ ] Does not mix DDL/DML operations
|
|
|
|
### Schema changes
|
|
|
|
- [ ] Both schema change and related migration have been implemented
|
|
- [ ] For index changes: has been performance tested for large tables
|
|
- [ ] For new tables/columns: fields use the appropriate predefined field lengths
|
|
- [ ] For new tables/columns: field names follow the appropriate conventions
|
|
- [ ] Does not drop a non-alpha table outside of a major version
|
|
|
|
### Data changes
|
|
|
|
- [ ] Mass updates/inserts are batched appropriately
|
|
- [ ] Does not loop over large tables/datasets
|
|
- [ ] Defends against missing or invalid data
|
|
- [ ] For settings updates: follows the appropriate guidelines
|