Ghost/ghost/admin/app/components/gh-dropdown.js
Rishabh 9b5cd1ac8b Refined close filter dropdown behavior
closes https://github.com/TryGhost/Team/issues/976

Dropdown's `onClose` action was previously fired from the `close` function instead of when the actual close happened when animation ended for dropdown close. Also, the `close` action of dropdown is fired irrespective of dropdown is open, as we close all dropdowns and menus whenever a new transition happens, so it caused flicker on the screen.
2021-09-06 12:42:43 +05:30

97 lines
2.7 KiB
JavaScript

import Component from '@ember/component';
import DropdownMixin from 'ghost-admin/mixins/dropdown-mixin';
import {computed} from '@ember/object';
import {run} from '@ember/runloop';
import {inject as service} from '@ember/service';
export default Component.extend(DropdownMixin, {
dropdown: service(),
classNames: 'dropdown',
classNameBindings: ['fadeIn:fade-in-scale:fade-out', 'isOpen:open:closed'],
name: null,
closeOnClick: false,
// Helps track the user re-opening the menu while it's fading out.
closing: false,
// Helps track whether the dropdown is open or closes, or in a transition to either
isOpen: false,
onClose() {},
// Managed the toggle between the fade-in and fade-out classes
fadeIn: computed('isOpen', 'closing', function () {
return this.isOpen && !this.closing;
}),
didInsertElement() {
this._super(...arguments);
let dropdownService = this.dropdown;
dropdownService.on('close', this, this.close);
dropdownService.on('toggle', this, this.toggle);
this._animationEndHandler = run.bind(this, function (event) {
if (event.animationName === 'fade-out' && this.closing) {
this.set('isOpen', false);
this.set('closing', false);
this.onClose?.();
}
});
this.element.addEventListener('animationend', this._animationEndHandler);
},
willDestroyElement() {
this._super(...arguments);
let dropdownService = this.dropdown;
dropdownService.off('close', this, this.close);
dropdownService.off('toggle', this, this.toggle);
this.element.removeEventListener('animationend', this._animationEndHandler);
},
open() {
this.set('isOpen', true);
this.set('closing', false);
this.set('button.isOpen', true);
},
close() {
this.set('closing', true);
if (this.button) {
this.set('button.isOpen', false);
}
},
// Called by the dropdown service when any dropdown button is clicked.
toggle(options) {
let isClosing = this.closing;
let isOpen = this.isOpen;
let name = this.name;
let targetDropdownName = options.target;
let button = this.button;
if (name === targetDropdownName && (!isOpen || isClosing)) {
if (!button) {
button = options.button;
this.set('button', button);
}
this.open();
} else if (isOpen) {
this.close();
}
},
click(event) {
this._super(event);
if (this.closeOnClick) {
return this.close();
}
}
});