mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-22 10:21:36 +03:00
f8b498d6e7
no issue 🎨 Switch themes API to use config.availableThemes - this gets rid of the only places where settings.availableThemes are used 🔥 Get rid of settings.availableThemes - this is no longer used anywhere - also get rid of every related call to updateSettingsCache 🔥 Replace config.availableThemes with theme cache - Creates a tailor-made in-memory cache for themes inside the theme module - Add methods for getting & setting items on the cache - Move all references to config.availableThemes to use the new cache - This can be abstracted later to support other kinds of caches? 🎨 Start improving theme lib's API Still TODO: simplifying/clarifying: - what is the structure of the internal list - what is the difference between a package list, and a theme list? - what is the difference between reading a theme and loading it? - how do we update the theme list (add/remove) - how do we refresh the theme list? (hot reload?!) - how do we get from an internal list, to one that is sent as part of the API? - how are we going to handle theme storage: read/write, such that the path is configurable 🎨 Use themeList consistently 🎨 Update list after storage
22 lines
983 B
JavaScript
22 lines
983 B
JavaScript
var Promise = require('bluebird'),
|
|
errors = require('../errors'),
|
|
i18n = require('../i18n'),
|
|
themeList = require('./list'),
|
|
validateActiveTheme;
|
|
|
|
// @TODO replace this with something PROPER - we should probably attempt to read the theme from the
|
|
// File system at this point and validate the theme using gscan rather than just checking if it's in a cache object
|
|
validateActiveTheme = function validateActiveTheme(themeName) {
|
|
if (!themeList.getAll() || Object.keys(themeList.getAll()).length === 0) {
|
|
// We haven't yet loaded all themes, this is probably being called early?
|
|
return Promise.resolve();
|
|
}
|
|
|
|
// Else, if we have a list, check if the theme is in it
|
|
if (!themeList.get(themeName)) {
|
|
return Promise.reject(new errors.ValidationError({message: i18n.t('notices.data.validation.index.themeCannotBeActivated', {themeName: themeName}), context: 'activeTheme'}));
|
|
}
|
|
};
|
|
|
|
module.exports.activeTheme = validateActiveTheme;
|