mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-26 12:21:36 +03:00
26b0bbc623
refs https://github.com/TryGhost/Toolbox/issues/461 - The codebase has ambiguous behavior with OPTIONS request. Adding tests covering edge cases for all possible variations of OPTIONS responses is the first step to solving cahceability of these requests. - The obvious question if you look into the changeset itself would also be: "WTF did you do with test suite naming? What are these changes in admin and click tracking suites? You having a bad day Naz?". The answer is "yes" (╯°□°)╯︵ ┻━┻ - On a serious note. I've introduced multiple hacks here that should be fixed: 1. Forced test suite execution order for options request - extreme blasphemy. This was last resort decision. I went deep into trying to fixup the server shutdown in the "admin" test suite, which cascaded into failing "click tracking" suite, which has shortcomings on it's own (see notes left in that suite) 2. Exposed "ghostServer" from the e2e-framework's "getAgentsWithFrontend" method. Exposing ghostServer to be able to shut it down (or do other manipulations) was one of the pitfalls we had in the previous test utils, which ended up plaguing the test codebase. Ideally the framework should only be exposing the agents and the rest would happen behind the scenes. - To fix the hacks above I've raised a cleanup issue (https://github.com/TryGhost/Toolbox/issues/471). I'm very sorry for this mess. The issue at hand has very little to do with fixing the e2e framework, so leaving things "as is". |
||
|---|---|---|
| .. | ||
| adapter-manager | ||
| admin | ||
| api-framework | ||
| api-version-compatibility-service | ||
| audience-feedback | ||
| bootstrap-socket | ||
| constants | ||
| core | ||
| custom-theme-settings-service | ||
| data-generator | ||
| domain-events | ||
| email-analytics-provider-mailgun | ||
| email-analytics-service | ||
| email-content-generator | ||
| express-dynamic-redirects | ||
| extract-api-key | ||
| html-to-plaintext | ||
| job-manager | ||
| link-redirects | ||
| link-replacer | ||
| link-tracking | ||
| magic-link | ||
| mailgun-client | ||
| member-analytics-service | ||
| member-attribution | ||
| member-events | ||
| members-analytics-ingress | ||
| members-api | ||
| members-csv | ||
| members-events-service | ||
| members-importer | ||
| members-ssr | ||
| minifier | ||
| mw-api-version-mismatch | ||
| mw-cache-control | ||
| mw-error-handler | ||
| mw-session-from-token | ||
| mw-update-user-last-seen | ||
| mw-vhost | ||
| oembed-service | ||
| offers | ||
| package-json | ||
| payments | ||
| portal | ||
| referrers | ||
| security | ||
| session-service | ||
| settings-path-manager | ||
| staff-service | ||
| stats-service | ||
| stripe | ||
| tiers | ||
| update-check-service | ||
| verification-trigger | ||
| version-notifications-data-service | ||