mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-18 16:01:40 +03:00
48f9485f46
no issue - When we receive an email failure with an empty message, the saving of the model would fail because of schema validation that requires strings to be non-empty. - This adds more logging to the email analytics service to help debug future issues - Performance improvement to storing delivered, opened and failed emails by replacing COALESCE with WHERE X IS NULL (tested and should give a decent performance boost locally).
137 lines
4.8 KiB
JavaScript
137 lines
4.8 KiB
JavaScript
const moment = require('moment-timezone');
|
|
const logging = require('@tryghost/logging');
|
|
|
|
class EmailEventStorage {
|
|
#db;
|
|
#membersRepository;
|
|
#models;
|
|
|
|
constructor({db, models, membersRepository}) {
|
|
this.#db = db;
|
|
this.#models = models;
|
|
this.#membersRepository = membersRepository;
|
|
}
|
|
|
|
async handleDelivered(event) {
|
|
// To properly handle events that are received out of order (this happens because of polling)
|
|
// only set if delivered_at is null
|
|
await this.#db.knex('email_recipients')
|
|
.where('id', '=', event.emailRecipientId)
|
|
.whereNull('delivered_at')
|
|
.update({
|
|
delivered_at: moment.utc(event.timestamp).format('YYYY-MM-DD HH:mm:ss')
|
|
});
|
|
}
|
|
|
|
async handleOpened(event) {
|
|
// To properly handle events that are received out of order (this happens because of polling)
|
|
// only set if opened_at is null
|
|
await this.#db.knex('email_recipients')
|
|
.where('id', '=', event.emailRecipientId)
|
|
.whereNull('opened_at')
|
|
.update({
|
|
opened_at: moment.utc(event.timestamp).format('YYYY-MM-DD HH:mm:ss')
|
|
});
|
|
}
|
|
|
|
async handlePermanentFailed(event) {
|
|
// To properly handle events that are received out of order (this happens because of polling)
|
|
// only set if failed_at is null
|
|
await this.#db.knex('email_recipients')
|
|
.where('id', '=', event.emailRecipientId)
|
|
.whereNull('failed_at')
|
|
.update({
|
|
failed_at: moment.utc(event.timestamp).format('YYYY-MM-DD HH:mm:ss')
|
|
});
|
|
await this.saveFailure('permanent', event);
|
|
}
|
|
|
|
async handleTemporaryFailed(event) {
|
|
await this.saveFailure('temporary', event);
|
|
}
|
|
|
|
/**
|
|
* @private
|
|
* @param {'temporary'|'permanent'} severity
|
|
* @param {import('@tryghost/email-events').EmailTemporaryBouncedEvent|import('@tryghost/email-events').EmailBouncedEvent} event
|
|
* @param {{transacting?: any}} options
|
|
* @returns
|
|
*/
|
|
async saveFailure(severity, event, options = {}) {
|
|
if (!event.error) {
|
|
logging.warn(`Missing error information provided for ${severity} failure event with id ${event.id}`);
|
|
return;
|
|
}
|
|
|
|
if (!options || !options.transacting) {
|
|
return await this.#models.EmailRecipientFailure.transaction(async (transacting) => {
|
|
await this.saveFailure(severity, event, {transacting});
|
|
});
|
|
}
|
|
|
|
// Create a forUpdate transaction
|
|
const existing = await this.#models.EmailRecipientFailure.findOne({
|
|
email_recipient_id: event.emailRecipientId
|
|
}, {...options, require: false, forUpdate: true});
|
|
|
|
if (!existing) {
|
|
// Create a new failure
|
|
await this.#models.EmailRecipientFailure.add({
|
|
email_id: event.emailId,
|
|
member_id: event.memberId,
|
|
email_recipient_id: event.emailRecipientId,
|
|
severity,
|
|
message: event.error.message || `Error ${event.error.enhancedCode ?? event.error.code}`,
|
|
code: event.error.code,
|
|
enhanced_code: event.error.enhancedCode,
|
|
failed_at: event.timestamp,
|
|
event_id: event.id
|
|
}, options);
|
|
} else {
|
|
if (existing.get('severity') === 'permanent') {
|
|
// Already marked as failed, no need to change anything here
|
|
return;
|
|
}
|
|
|
|
if (existing.get('failed_at') > event.timestamp) {
|
|
/// We can get events out of order, so only save the last one
|
|
return;
|
|
}
|
|
|
|
// Update the existing failure
|
|
await existing.save({
|
|
severity,
|
|
message: event.error.message || `Error ${event.error.enhancedCode ?? event.error.code}`,
|
|
code: event.error.code,
|
|
enhanced_code: event.error.enhancedCode ?? null,
|
|
failed_at: event.timestamp,
|
|
event_id: event.id
|
|
}, {...options, patch: true, autoRefresh: false});
|
|
}
|
|
}
|
|
|
|
async handleUnsubscribed(event) {
|
|
return this.unsubscribeFromNewsletters(event);
|
|
}
|
|
|
|
async handleComplained(event) {
|
|
try {
|
|
await this.#models.EmailSpamComplaintEvent.add({
|
|
member_id: event.memberId,
|
|
email_id: event.emailId,
|
|
email_address: event.email
|
|
});
|
|
} catch (err) {
|
|
if (err.code !== 'ER_DUP_ENTRY' && err.code !== 'SQLITE_CONSTRAINT') {
|
|
logging.error(err);
|
|
}
|
|
}
|
|
}
|
|
|
|
async unsubscribeFromNewsletters(event) {
|
|
await this.#membersRepository.update({newsletters: []}, {id: event.memberId});
|
|
}
|
|
}
|
|
|
|
module.exports = EmailEventStorage;
|