mirror of
https://github.com/TryGhost/Ghost.git
synced 2025-01-04 17:04:59 +03:00
822cb2d9f6
Ref #2059 - Refactor appProxy into class that is instantiated per App - Check for permissions before doing proxied filter/helper calls - Add all currently existing api methods, let api check for permissions - Basic unit tests for filter and helper register/deregister - Adjusted proxy api method existence unit tests
84 lines
3.0 KiB
JavaScript
84 lines
3.0 KiB
JavaScript
var _ = require('lodash'),
|
|
api = require('../api'),
|
|
helpers = require('../helpers'),
|
|
filters = require('../filters');
|
|
|
|
var generateProxyFunctions = function (name, permissions) {
|
|
var getPermission = function (perm) {
|
|
return permissions[perm];
|
|
},
|
|
getPermissionToMethod = function (perm, method) {
|
|
var perms = getPermission(perm);
|
|
|
|
if (!perms) {
|
|
return false;
|
|
}
|
|
|
|
return _.find(perms, function (name) {
|
|
return name === method;
|
|
});
|
|
},
|
|
runIfPermissionToMethod = function (perm, method, wrappedFunc, context, args) {
|
|
var permValue = getPermissionToMethod(perm, method);
|
|
|
|
if (!permValue) {
|
|
throw new Error('The App "' + name + '" attempted to perform an action or access a resource (' + perm + '.' + method + ') without permission.');
|
|
}
|
|
|
|
return wrappedFunc.apply(context, args);
|
|
},
|
|
checkRegisterPermissions = function (perm, registerMethod) {
|
|
return _.wrap(registerMethod, function (origRegister, name) {
|
|
return runIfPermissionToMethod(perm, name, origRegister, this, _.toArray(arguments).slice(1));
|
|
});
|
|
},
|
|
passThruAppContextToApi = function (perm, apiMethods) {
|
|
var appContext = {
|
|
app: name
|
|
};
|
|
|
|
return _.reduce(apiMethods, function (memo, apiMethod, methodName) {
|
|
memo[methodName] = function () {
|
|
return apiMethod.apply(_.clone(appContext), _.toArray(arguments));
|
|
};
|
|
|
|
return memo;
|
|
}, {});
|
|
},
|
|
proxy;
|
|
|
|
proxy = {
|
|
filters: {
|
|
register: checkRegisterPermissions('filters', filters.registerFilter.bind(filters)),
|
|
deregister: checkRegisterPermissions('filters', filters.deregisterFilter.bind(filters))
|
|
},
|
|
helpers: {
|
|
register: checkRegisterPermissions('helpers', helpers.registerThemeHelper.bind(helpers)),
|
|
registerAsync: checkRegisterPermissions('helpers', helpers.registerAsyncThemeHelper.bind(helpers))
|
|
},
|
|
api: {
|
|
posts: passThruAppContextToApi('posts', _.pick(api.posts, 'browse', 'read', 'edit', 'add', 'destroy')),
|
|
tags: passThruAppContextToApi('tags', _.pick(api.tags, 'browse')),
|
|
notifications: passThruAppContextToApi('notifications', _.pick(api.notifications, 'browse', 'add', 'destroy')),
|
|
settings: passThruAppContextToApi('settings', _.pick(api.settings, 'browse', 'read', 'edit'))
|
|
}
|
|
};
|
|
|
|
return proxy;
|
|
};
|
|
|
|
function AppProxy(options) {
|
|
|
|
if (!options.name) {
|
|
throw new Error('Must provide an app name for api context');
|
|
}
|
|
|
|
if (!options.permissions) {
|
|
throw new Error('Must provide app permissions');
|
|
}
|
|
|
|
_.extend(this, generateProxyFunctions(options.name, options.permissions));
|
|
}
|
|
|
|
module.exports = AppProxy;
|