Ghost/ghost/admin/app
Ronald Langeveld 29f98104df
Fixed icon not updating on Ember from AdminX (#18374)
refs
https://www.notion.so/ghost/df5bdea8f7ea4aca9d25eceb6a1bf34c?v=be2f15b6b58b4c27a0e11374282bead0&p=bafc80a9ad644fb18fe338f89500ff36&pm=s

- we now reload ember's settings data when settings data updated, to
keep certain data synced, such as the icon in the sidebar.

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 572a569</samp>

Refactor settings component to use Ember Octane and reload settings
model after saving. This improves the UI and code quality of the
`admin-x` component.
2023-09-27 09:36:45 +07:00
..
adapters Added feature to convert and open mobiledoc posts in the lexical editor (#17453) 2023-08-08 15:44:54 -07:00
authenticators Made session.user a synchronous property rather than a promise 2021-07-08 14:54:31 +01:00
components Fixed icon not updating on Ember from AdminX (#18374) 2023-09-27 09:36:45 +07:00
controllers Prevented background click closing members import modal (#18296) 2023-09-22 12:01:34 +00:00
decorators Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
errors Improved validation process for members CSV import 2020-07-07 00:28:30 +12:00
helpers Added donation events to activity feeds (#17632) 2023-08-10 09:16:47 +02:00
initializers Resolved ember-simple-auth deprecations 2022-01-22 00:30:56 +00:00
instance-initializers Fixed hosting management screen not loading after sign-in process (#15763) 2022-11-03 11:14:36 +00:00
mixins Added collections CRUD UI 2023-05-23 17:26:47 +07:00
models Ensure hidden settings return falsy when used with the @custom helper (#17920) 2023-09-13 08:38:31 +01:00
modifiers Updated AdminX to be preloaded to improve perceived speed (#18059) 2023-09-11 10:55:12 +01:00
routes Updated Admin-X bundling process 2023-09-19 11:31:55 +02:00
serializers Updated AdminX to sync data changes to Ember (#18327) 2023-09-25 17:29:09 +01:00
services Fixed ForceUpgrade state not working with Explore 2023-09-25 12:56:04 +01:00
session-stores Migrated session-store to native class syntax 2022-02-02 18:41:16 +00:00
styles AdminX settings GA design refinements (#18332) 2023-09-25 17:49:12 +02:00
templates Updated links to old settings to link to AdminX (#18352) 2023-09-26 10:33:00 +00:00
transforms Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils Updated Admin-X bundling process 2023-09-19 11:31:55 +02:00
validators Added collections CRUD UI 2023-05-23 17:26:47 +07:00
app.js Dropped ember-cli-moment-shim dependency 2022-09-24 13:28:23 +02:00
index.html Fixed loading animation for Safari 2022-10-17 10:11:07 +02:00
README.md Renamed "client" references to "admin" 2022-05-17 09:09:14 +01:00
router.js Added /collections/slug/:slug Admin API endpoint 2023-07-24 14:27:17 +08:00
transitions.js Removed tour feature 2021-03-02 14:29:26 +00:00

Ghost Admin App

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)