mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-25 03:44:29 +03:00
8a7c7f08e9
refs https://github.com/nodeca/probe-image-size/blob/master/CHANGELOG.md#600---2020-11-04 - `probe-image-size` v6 now supports `.ico` files so we can allow probing of dimensions via this library rather than falling back to downloading the entire image via `image-size` - also updates a test because .ico files no longer use the internal request lib, which simplifies things a little bit
759 lines
32 KiB
JavaScript
759 lines
32 KiB
JavaScript
const should = require('should');
|
|
const sinon = require('sinon');
|
|
const nock = require('nock');
|
|
const path = require('path');
|
|
const errors = require('@tryghost/errors');
|
|
const fs = require('fs');
|
|
const ImageSize = require('../../../../../core/server/lib/image/image-size');
|
|
|
|
describe('lib/image: image size', function () {
|
|
// use a 1x1 gif in nock responses because it's really small and easy to work with
|
|
const GIF1x1 = Buffer.from('R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==', 'base64');
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
nock.cleanAll();
|
|
});
|
|
|
|
it('[success] should have an image size function', function () {
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {}, validator: {}, urlUtils: {}, request: {}});
|
|
should.exist(imageSize.getImageSizeFromUrl);
|
|
should.exist(imageSize.getImageSizeFromStoragePath);
|
|
});
|
|
|
|
describe('getImageSizeFromUrl', function () {
|
|
it('[success] should return image dimensions from probe request for probe-supported extension', function (done) {
|
|
const url = 'http://img.stockfresh.com/files/f/feedough/x/11/1540353_20925115.jpg';
|
|
const expectedImageObject = {
|
|
height: 1,
|
|
url: 'http://img.stockfresh.com/files/f/feedough/x/11/1540353_20925115.jpg',
|
|
width: 1
|
|
};
|
|
|
|
const requestMock = nock('http://img.stockfresh.com')
|
|
.get('/files/f/feedough/x/11/1540353_20925115.jpg')
|
|
.reply(200, GIF1x1);
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => true
|
|
}, urlUtils: {}, request: {}});
|
|
|
|
imageSize.getImageSizeFromUrl(url).then(function (res) {
|
|
requestMock.isDone().should.be.true();
|
|
should.exist(res);
|
|
res.width.should.be.equal(expectedImageObject.width);
|
|
res.height.should.be.equal(expectedImageObject.height);
|
|
res.url.should.be.equal(expectedImageObject.url);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[success] should return image dimensions from fetch request for non-probe-supported extension', function (done) {
|
|
const url = 'https://static.wixstatic.com/media/355241_d31358572a2542c5a44738ddcb59e7ea.cur';
|
|
const expectedImageObject = {
|
|
height: 1,
|
|
url: 'https://static.wixstatic.com/media/355241_d31358572a2542c5a44738ddcb59e7ea.cur',
|
|
width: 1
|
|
};
|
|
|
|
const requestMock = nock('https://static.wixstatic.com').get('/random-path').reply(404);
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => true
|
|
}, urlUtils: {}, request: (requestUrl) => {
|
|
if (requestUrl === url) {
|
|
return Promise.resolve({
|
|
body: GIF1x1
|
|
});
|
|
}
|
|
return Promise.reject();
|
|
}});
|
|
|
|
imageSize.getImageSizeFromUrl(url).then(function (res) {
|
|
requestMock.isDone().should.be.false();
|
|
should.exist(res);
|
|
res.width.should.be.equal(expectedImageObject.width);
|
|
res.height.should.be.equal(expectedImageObject.height);
|
|
res.url.should.be.equal(expectedImageObject.url);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[success] should return image dimensions when no image extension given', function (done) {
|
|
const url = 'https://www.zomato.com/logo/18163505/minilogo';
|
|
const expectedImageObject = {
|
|
height: 1,
|
|
url: 'https://www.zomato.com/logo/18163505/minilogo',
|
|
width: 1
|
|
};
|
|
|
|
const requestMock = nock('https://www.zomato.com')
|
|
.get('/logo/18163505/minilogo')
|
|
.reply(200, GIF1x1);
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => true
|
|
}, urlUtils: {}, request: {}});
|
|
|
|
imageSize.getImageSizeFromUrl(url).then(function (res) {
|
|
requestMock.isDone().should.be.true();
|
|
should.exist(res);
|
|
res.width.should.be.equal(expectedImageObject.width);
|
|
res.height.should.be.equal(expectedImageObject.height);
|
|
res.url.should.be.equal(expectedImageObject.url);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[success] should returns largest image value for .ico files', function (done) {
|
|
const url = 'https://super-website.com/media/icon.ico';
|
|
const expectedImageObject = {
|
|
height: 64,
|
|
url: 'https://super-website.com/media/icon.ico',
|
|
width: 64
|
|
};
|
|
|
|
const requestMock = nock('https://super-website.com')
|
|
.get('/media/icon.ico')
|
|
.replyWithFile(200, path.join(__dirname, '../../../../utils/fixtures/images/favicon_multi_sizes.ico'));
|
|
const requestMockNotFound = nock('https://super-website.com').get('/random-path').reply(404);
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => true
|
|
}, urlUtils: {}, request: {}});
|
|
|
|
imageSize.getImageSizeFromUrl(url).then(function (res) {
|
|
requestMockNotFound.isDone().should.be.false();
|
|
requestMock.isDone().should.be.true();
|
|
should.exist(res);
|
|
res.width.should.be.equal(expectedImageObject.width);
|
|
res.height.should.be.equal(expectedImageObject.height);
|
|
res.url.should.be.equal(expectedImageObject.url);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[success] should return image dimensions asset path images', function (done) {
|
|
const url = '/assets/img/logo.png?v=d30c3d1e41';
|
|
const expectedImageObject = {
|
|
height: 1,
|
|
url: 'http://myblog.com/assets/img/logo.png?v=d30c3d1e41',
|
|
width: 1
|
|
};
|
|
|
|
const urlForStub = sinon.stub().withArgs('home').returns('http://myblog.com/');
|
|
const urlGetSubdirStub = sinon.stub().returns('');
|
|
|
|
const requestMock = nock('http://myblog.com')
|
|
.get('/assets/img/logo.png?v=d30c3d1e41')
|
|
.reply(200, GIF1x1);
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => true
|
|
}, urlUtils: {
|
|
urlFor: urlForStub,
|
|
getSubdir: urlGetSubdirStub,
|
|
urlJoin: function () {
|
|
if ([...arguments].join('') === 'http://myblog.com///assets/img/logo.png?v=d30c3d1e41') {
|
|
return expectedImageObject.url;
|
|
}
|
|
return '';
|
|
}
|
|
}, request: (requestUrl) => {
|
|
if (requestUrl === url) {
|
|
return Promise.resolve({
|
|
body: GIF1x1
|
|
});
|
|
}
|
|
return Promise.reject();
|
|
}});
|
|
|
|
imageSize.getImageSizeFromUrl(url).then(function (res) {
|
|
requestMock.isDone().should.be.true();
|
|
should.exist(res);
|
|
res.width.should.be.equal(expectedImageObject.width);
|
|
res.height.should.be.equal(expectedImageObject.height);
|
|
res.url.should.be.equal(expectedImageObject.url);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[success] should return image dimensions for gravatar images request', function (done) {
|
|
const url = '//www.gravatar.com/avatar/ef6dcde5c99bb8f685dd451ccc3e050a?s=250&d=mm&r=x';
|
|
const expectedImageObject = {
|
|
height: 1,
|
|
url: '//www.gravatar.com/avatar/ef6dcde5c99bb8f685dd451ccc3e050a?s=250&d=mm&r=x',
|
|
width: 1
|
|
};
|
|
|
|
const requestMock = nock('http://www.gravatar.com')
|
|
.get('/avatar/ef6dcde5c99bb8f685dd451ccc3e050a?s=250&d=mm&r=x')
|
|
.reply(200, GIF1x1);
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => true
|
|
}, urlUtils: {}, request: {}});
|
|
|
|
imageSize.getImageSizeFromUrl(url).then(function (res) {
|
|
requestMock.isDone().should.be.true();
|
|
should.exist(res);
|
|
res.width.should.be.equal(expectedImageObject.width);
|
|
res.height.should.be.equal(expectedImageObject.height);
|
|
res.url.should.be.equal(expectedImageObject.url);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[success] can handle redirect (probe-image-size)', function (done) {
|
|
const url = 'http://noimagehere.com/files/f/feedough/x/11/1540353_20925115.jpg';
|
|
const expectedImageObject = {
|
|
height: 1,
|
|
url: 'http://noimagehere.com/files/f/feedough/x/11/1540353_20925115.jpg',
|
|
width: 1
|
|
};
|
|
|
|
const requestMock = nock('http://noimagehere.com')
|
|
.get('/files/f/feedough/x/11/1540353_20925115.jpg')
|
|
.reply(301, null, {
|
|
location: 'http://someredirectedurl.com/files/f/feedough/x/11/1540353_20925115.jpg'
|
|
});
|
|
|
|
const secondRequestMock = nock('http://someredirectedurl.com')
|
|
.get('/files/f/feedough/x/11/1540353_20925115.jpg')
|
|
.reply(200, GIF1x1);
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => true
|
|
}, urlUtils: {}, request: {}});
|
|
|
|
imageSize.getImageSizeFromUrl(url).then(function (res) {
|
|
requestMock.isDone().should.be.true();
|
|
secondRequestMock.isDone().should.be.true();
|
|
should.exist(res);
|
|
res.width.should.be.equal(expectedImageObject.width);
|
|
res.height.should.be.equal(expectedImageObject.height);
|
|
res.url.should.be.equal(expectedImageObject.url);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[success] should switch to local file storage if available', function (done) {
|
|
const url = '/content/images/favicon.png';
|
|
const expectedImageObject = {
|
|
height: 100,
|
|
url: 'http://myblog.com/content/images/favicon.png',
|
|
width: 100
|
|
};
|
|
|
|
const storagePath = path.join(__dirname, '../../../../utils/fixtures/images/');
|
|
const urlForStub = sinon.stub();
|
|
urlForStub.withArgs('image').returns('http://myblog.com/content/images/favicon.png');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
const urlGetSubdirStub = sinon.stub();
|
|
urlGetSubdirStub.returns('');
|
|
|
|
const requestMock = nock('http://myblog.com')
|
|
.get('/content/images/favicon.png')
|
|
.reply(200, {
|
|
body: '<Buffer 2c be a4 40 f7 87 73 1e 57 2c c1 e4 0d 79 03 95 42 f0 42 2e 41 95 27 c9 5c 35 a7 71 2c 09 5a 57 d3 04 1e 83 03 28 07 96 b0 c8 88 65 07 7a d1 d6 63 50>'
|
|
});
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {
|
|
getStorage: () => ({
|
|
read: obj => fs.promises.readFile(obj.path)
|
|
})
|
|
}, storageUtils: {
|
|
isLocalImage: () => true,
|
|
getLocalImagesStoragePath: imageUrl => path.join(storagePath, imageUrl.replace(/.*\//, ''))
|
|
}, validator: {}, urlUtils: {
|
|
urlFor: urlForStub,
|
|
getSubdir: urlGetSubdirStub
|
|
}, request: {}});
|
|
|
|
imageSize.getImageSizeFromUrl(url).then(function (res) {
|
|
requestMock.isDone().should.be.false();
|
|
should.exist(res);
|
|
should.exist(res.width);
|
|
res.width.should.be.equal(expectedImageObject.width);
|
|
should.exist(res.height);
|
|
res.height.should.be.equal(expectedImageObject.height);
|
|
should.exist(res.url);
|
|
res.url.should.be.equal(expectedImageObject.url);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[failure] can handle an error with statuscode not 200 (probe-image-size)', function (done) {
|
|
const url = 'http://noimagehere.com/files/f/feedough/x/11/1540353_20925115.jpg';
|
|
|
|
const requestMock = nock('http://noimagehere.com')
|
|
.get('/files/f/feedough/x/11/1540353_20925115.jpg')
|
|
.reply(404);
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => true
|
|
}, urlUtils: {}, request: {}});
|
|
|
|
imageSize.getImageSizeFromUrl(url)
|
|
.catch(function (err) {
|
|
requestMock.isDone().should.be.true();
|
|
should.exist(err);
|
|
err.errorType.should.be.equal('NotFoundError');
|
|
err.message.should.be.equal('Image not found.');
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[failure] can handle an error with statuscode not 200 (image-size)', function (done) {
|
|
const url = 'http://noimagehere.com/files/f/feedough/x/11/1540353_20925115.cur';
|
|
|
|
const requestMock = nock('http://noimagehere.com')
|
|
.get('/files/f/feedough/x/11/1540353_20925115.cur')
|
|
.reply(404);
|
|
|
|
class NotFound extends Error {
|
|
constructor(message) {
|
|
super(message);
|
|
this.code = 'ENOENT';
|
|
this.statusCode = 404;
|
|
}
|
|
}
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => true
|
|
}, urlUtils: {}, request: (requestUrl) => {
|
|
if (requestUrl === url) {
|
|
return Promise.reject(new NotFound());
|
|
}
|
|
return Promise.reject();
|
|
}});
|
|
|
|
imageSize.getImageSizeFromUrl(url)
|
|
.catch(function (err) {
|
|
requestMock.isDone().should.be.false();
|
|
should.exist(err);
|
|
err.errorType.should.be.equal('NotFoundError');
|
|
err.message.should.be.equal('Image not found.');
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[failure] handles invalid URL', function (done) {
|
|
const url = 'Not-a-valid-url';
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => false
|
|
}, urlUtils: {}, request: {}});
|
|
|
|
imageSize.getImageSizeFromUrl(url)
|
|
.catch(function (err) {
|
|
should.exist(err);
|
|
err.errorType.should.be.equal('InternalServerError');
|
|
err.message.should.be.equal('URL empty or invalid.');
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[failure] will timeout', function (done) {
|
|
const url = 'https://static.wixstatic.com/media/355241_d31358572a2542c5a44738ddcb59e7ea.jpg_256';
|
|
|
|
const requestMock = nock('https://static.wixstatic.com')
|
|
.get('/media/355241_d31358572a2542c5a44738ddcb59e7ea.jpg_256')
|
|
.delayConnection(10)
|
|
.reply(408);
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: (key) => {
|
|
if (key === 'times:getImageSizeTimeoutInMS') {
|
|
return 1;
|
|
}
|
|
}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => true
|
|
}, urlUtils: {}, request: {}});
|
|
|
|
imageSize.getImageSizeFromUrl(url)
|
|
.catch(function (err) {
|
|
requestMock.isDone().should.be.true();
|
|
should.exist(err);
|
|
err.errorType.should.be.equal('InternalServerError');
|
|
err.message.should.be.equal('Request timed out.');
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[failure] returns error if \`probe-image-size`\ module throws error', function (done) {
|
|
const url = 'https://static.wixstatic.com/media/355241_d31358572a2542c5a44738ddcb59e7ea.jpg';
|
|
|
|
const requestMock = nock('https://static.wixstatic.com')
|
|
.get('/media/355241_d31358572a2542c5a44738ddcb59e7ea.jpg')
|
|
.reply(200, Buffer.from('FFD8 FFC0 0004 00112233 FFD9'.replace(/ /g, ''), 'hex'));
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => true
|
|
}, urlUtils: {}, request: {}});
|
|
|
|
imageSize.getImageSizeFromUrl(url)
|
|
.then(() => {
|
|
true.should.be.false('succeeded when expecting failure');
|
|
})
|
|
.catch(function (err) {
|
|
requestMock.isDone().should.be.true();
|
|
should.exist(err);
|
|
err.errorType.should.be.equal('InternalServerError');
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[failure] returns error if \`image-size`\ module throws error', function (done) {
|
|
const url = 'https://static.wixstatic.com/media/355241_d31358572a2542c5a44738ddcb59e7ea.cur';
|
|
|
|
const requestMock = nock('https://static.wixstatic.com')
|
|
.get('/media/nope.cur')
|
|
.reply(404);
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => true
|
|
}, urlUtils: {}, request: (requestUrl) => {
|
|
if (requestUrl === url) {
|
|
return Promise.resolve({
|
|
body: Buffer.from('2c be a4 40 f7 87 73 1e 57 2c c1 e4 0d 79 03 95 42 f0 42 2e 41 95 27 c9 5c 35 a7 71 2c 09 5a 57 d3 04 1e 83 03 28 07 96 b0 c8 88 65 07 7a d1 d6 63 50'.replace(/ /g, ''), 'hex')
|
|
});
|
|
}
|
|
return Promise.reject();
|
|
}});
|
|
|
|
imageSize.getImageSizeFromUrl(url)
|
|
.then(() => {
|
|
true.should.be.false('succeeded when expecting failure');
|
|
})
|
|
.catch(function (err) {
|
|
requestMock.isDone().should.be.false();
|
|
should.exist(err);
|
|
err.errorType.should.be.equal('InternalServerError');
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[failure] returns error if request errors', function (done) {
|
|
const url = 'https://notarealwebsite.com/images/notapicture.dds';
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {}, storageUtils: {
|
|
isLocalImage: () => false
|
|
}, validator: {
|
|
isURL: () => true
|
|
}, urlUtils: {}, request: () => {
|
|
return Promise.reject({});
|
|
}});
|
|
|
|
imageSize.getImageSizeFromUrl(url)
|
|
.catch(function (err) {
|
|
should.exist(err);
|
|
err.errorType.should.be.equal('InternalServerError');
|
|
err.message.should.be.equal('Unknown Request error.');
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
});
|
|
|
|
describe('getImageSizeFromStoragePath', function () {
|
|
it('[success] should return image dimensions for locally stored images', function (done) {
|
|
const url = '/content/images/ghost-logo.png';
|
|
const expectedImageObject = {
|
|
height: 257,
|
|
url: 'http://myblog.com/content/images/ghost-logo.png',
|
|
width: 800
|
|
};
|
|
|
|
const storagePath = path.join(__dirname, '../../../../utils/fixtures/images/');
|
|
const urlForStub = sinon.stub();
|
|
urlForStub.withArgs('image').returns('http://myblog.com/content/images/ghost-logo.png');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
const urlGetSubdirStub = sinon.stub();
|
|
urlGetSubdirStub.returns('');
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {
|
|
getStorage: () => ({
|
|
read: obj => fs.promises.readFile(obj.path)
|
|
})
|
|
}, storageUtils: {
|
|
isLocalImage: () => true,
|
|
getLocalImagesStoragePath: imageUrl => path.join(storagePath, imageUrl.replace(/.*\//, ''))
|
|
}, validator: {}, urlUtils: {
|
|
urlFor: urlForStub,
|
|
getSubdir: urlGetSubdirStub
|
|
}, request: () => {
|
|
return Promise.reject({});
|
|
}});
|
|
|
|
imageSize.getImageSizeFromStoragePath(url).then(function (res) {
|
|
should.exist(res);
|
|
should.exist(res.width);
|
|
res.width.should.be.equal(expectedImageObject.width);
|
|
should.exist(res.height);
|
|
res.height.should.be.equal(expectedImageObject.height);
|
|
should.exist(res.url);
|
|
res.url.should.be.equal(expectedImageObject.url);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[success] should return image dimensions for locally stored images with subdirectory', function (done) {
|
|
const url = '/content/images/favicon_too_large.png';
|
|
const expectedImageObject = {
|
|
height: 1010,
|
|
url: 'http://myblog.com/blog/content/images/favicon_too_large.png',
|
|
width: 1010
|
|
};
|
|
|
|
const storagePath = path.join(__dirname, '../../../../utils/fixtures/images/');
|
|
const urlForStub = sinon.stub();
|
|
urlForStub.withArgs('image').returns('http://myblog.com/blog/content/images/favicon_too_large.png');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
const urlGetSubdirStub = sinon.stub();
|
|
urlGetSubdirStub.returns('/blog');
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {
|
|
getStorage: () => ({
|
|
read: obj => fs.promises.readFile(obj.path)
|
|
})
|
|
}, storageUtils: {
|
|
isLocalImage: () => true,
|
|
getLocalImagesStoragePath: imageUrl => path.join(storagePath, imageUrl.replace(/.*\//, ''))
|
|
}, validator: {}, urlUtils: {
|
|
urlFor: urlForStub,
|
|
getSubdir: urlGetSubdirStub
|
|
}, request: () => {
|
|
return Promise.reject({});
|
|
}});
|
|
|
|
imageSize.getImageSizeFromStoragePath(url).then(function (res) {
|
|
should.exist(res);
|
|
should.exist(res.width);
|
|
res.width.should.be.equal(expectedImageObject.width);
|
|
should.exist(res.height);
|
|
res.height.should.be.equal(expectedImageObject.height);
|
|
should.exist(res.url);
|
|
res.url.should.be.equal(expectedImageObject.url);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[success] should return largest image dimensions for locally stored .ico image', function (done) {
|
|
const url = 'http://myblog.com/content/images/favicon_multi_sizes.ico';
|
|
const expectedImageObject = {
|
|
height: 64,
|
|
url: 'http://myblog.com/content/images/favicon_multi_sizes.ico',
|
|
width: 64
|
|
};
|
|
|
|
const storagePath = path.join(__dirname, '../../../../utils/fixtures/images/');
|
|
const urlForStub = sinon.stub();
|
|
urlForStub.withArgs('image').returns('http://myblog.com/content/images/favicon_multi_sizes.ico');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
const urlGetSubdirStub = sinon.stub();
|
|
urlGetSubdirStub.returns('');
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {
|
|
getStorage: () => ({
|
|
read: obj => fs.promises.readFile(obj.path)
|
|
})
|
|
}, storageUtils: {
|
|
isLocalImage: () => true,
|
|
getLocalImagesStoragePath: imageUrl => path.join(storagePath, imageUrl.replace(/.*\//, ''))
|
|
}, validator: {}, urlUtils: {
|
|
urlFor: urlForStub,
|
|
getSubdir: urlGetSubdirStub
|
|
}, request: () => {
|
|
return Promise.reject({});
|
|
}});
|
|
|
|
imageSize.getImageSizeFromStoragePath(url).then(function (res) {
|
|
should.exist(res);
|
|
should.exist(res.width);
|
|
res.width.should.be.equal(expectedImageObject.width);
|
|
should.exist(res.height);
|
|
res.height.should.be.equal(expectedImageObject.height);
|
|
should.exist(res.url);
|
|
res.url.should.be.equal(expectedImageObject.url);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[success] should return image dimensions for locally stored .webp image', function (done) {
|
|
const url = 'http://myblog.com/content/images/ghosticon.webp';
|
|
const expectedImageObject = {
|
|
height: 249,
|
|
url: 'http://myblog.com/content/images/ghosticon.webp',
|
|
width: 249
|
|
};
|
|
|
|
const storagePath = path.join(__dirname, '../../../../utils/fixtures/images/');
|
|
const urlForStub = sinon.stub();
|
|
urlForStub.withArgs('image').returns('http://myblog.com/content/images/ghosticon.webp');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
const urlGetSubdirStub = sinon.stub();
|
|
urlGetSubdirStub.returns('');
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {
|
|
getStorage: () => ({
|
|
read: obj => fs.promises.readFile(obj.path)
|
|
})
|
|
}, storageUtils: {
|
|
isLocalImage: () => true,
|
|
getLocalImagesStoragePath: imageUrl => path.join(storagePath, imageUrl.replace(/.*\//, ''))
|
|
}, validator: {}, urlUtils: {
|
|
urlFor: urlForStub,
|
|
getSubdir: urlGetSubdirStub
|
|
}, request: () => {
|
|
return Promise.reject({});
|
|
}});
|
|
|
|
imageSize.getImageSizeFromStoragePath(url).then(function (res) {
|
|
should.exist(res);
|
|
should.exist(res.width);
|
|
res.width.should.be.equal(expectedImageObject.width);
|
|
should.exist(res.height);
|
|
res.height.should.be.equal(expectedImageObject.height);
|
|
should.exist(res.url);
|
|
res.url.should.be.equal(expectedImageObject.url);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[failure] returns error if storage adapter errors', function (done) {
|
|
const url = '/content/images/not-existing-image.png';
|
|
|
|
const storagePath = path.join(__dirname, '../../../../utils/fixtures/images/');
|
|
const urlForStub = sinon.stub();
|
|
urlForStub.withArgs('image').returns('http://myblog.com/content/images/not-existing-image.png');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
const urlGetSubdirStub = sinon.stub();
|
|
urlGetSubdirStub.returns('');
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {
|
|
getStorage: () => ({
|
|
read: () => {
|
|
return Promise.reject(new errors.NotFoundError());
|
|
}
|
|
})
|
|
}, storageUtils: {
|
|
isLocalImage: () => true,
|
|
getLocalImagesStoragePath: imageUrl => path.join(storagePath, imageUrl.replace(/.*\//, ''))
|
|
}, validator: {}, urlUtils: {
|
|
urlFor: urlForStub,
|
|
getSubdir: urlGetSubdirStub
|
|
}, request: () => {
|
|
return Promise.reject({});
|
|
}});
|
|
|
|
imageSize.getImageSizeFromStoragePath(url)
|
|
.catch(function (err) {
|
|
should.exist(err);
|
|
(err instanceof errors.NotFoundError).should.eql(true);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
|
|
it('[failure] returns error if \`image-size`\ module throws error', function (done) {
|
|
const url = '/content/images/malformed.svg';
|
|
|
|
const urlForStub = sinon.stub();
|
|
urlForStub.withArgs('image').returns('http://myblog.com/content/images/malformed.svg');
|
|
urlForStub.withArgs('home').returns('http://myblog.com/');
|
|
const urlGetSubdirStub = sinon.stub();
|
|
urlGetSubdirStub.returns('');
|
|
|
|
const imageSize = new ImageSize({config: {
|
|
get: () => {}
|
|
}, tpl: {}, storage: {
|
|
getStorage: () => ({
|
|
read: () => {
|
|
return Promise.resolve(Buffer.from('<svg xmlns="http://www.w3.org/2000/svg viewBox="0 0 100 100>/svg>'));
|
|
}
|
|
})
|
|
}, storageUtils: {
|
|
isLocalImage: () => true,
|
|
getLocalImagesStoragePath: () => ''
|
|
}, validator: {}, urlUtils: {
|
|
urlFor: urlForStub,
|
|
getSubdir: urlGetSubdirStub
|
|
}, request: () => {
|
|
return Promise.reject({});
|
|
}});
|
|
|
|
imageSize.getImageSizeFromStoragePath(url)
|
|
.catch(function (err) {
|
|
should.exist(err);
|
|
done();
|
|
}).catch(done);
|
|
});
|
|
});
|
|
});
|