mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-26 20:34:02 +03:00
c47891c3f6
refs https://ghost.slack.com/archives/C02G9E68C/p1670075366333929?thread_ts=1669963540.980309&cid=C02G9E68C When we receive a permanent bounce/failure, we set delivered_at to null. But we don't want to lose this information. Instead we should be able to handle recipients that both have failed_at and delivered_at set.
349 lines
11 KiB
JavaScript
349 lines
11 KiB
JavaScript
const EmailEventStorage = require('../lib/email-event-storage');
|
|
const {EmailDeliveredEvent, EmailOpenedEvent, EmailBouncedEvent, EmailTemporaryBouncedEvent, EmailUnsubscribedEvent, SpamComplaintEvent} = require('@tryghost/email-events');
|
|
const sinon = require('sinon');
|
|
const assert = require('assert');
|
|
|
|
function stubDb() {
|
|
const db = {
|
|
knex: function () {
|
|
return this;
|
|
},
|
|
where: function () {
|
|
return this;
|
|
},
|
|
whereNull: function () {
|
|
return this;
|
|
},
|
|
update: sinon.stub().resolves()
|
|
};
|
|
db.knex.raw = function () {
|
|
return this;
|
|
};
|
|
return db;
|
|
}
|
|
|
|
describe('Email event storage', function () {
|
|
describe('Constructor', function () {
|
|
it('doesn\'t throw', function () {
|
|
new EmailEventStorage({});
|
|
});
|
|
});
|
|
|
|
it('Handles email delivered events', async function () {
|
|
const DomainEvents = {
|
|
subscribe: async (type, handler) => {
|
|
if (type === EmailDeliveredEvent) {
|
|
handler(EmailDeliveredEvent.create({
|
|
email: 'example@example.com',
|
|
memberId: '123',
|
|
emailId: '456',
|
|
emailRecipientId: '789'
|
|
}, new Date(0)));
|
|
}
|
|
}
|
|
};
|
|
|
|
const subscribeSpy = sinon.spy(DomainEvents, 'subscribe');
|
|
const db = stubDb();
|
|
const eventHandler = new EmailEventStorage({db});
|
|
eventHandler.listen(DomainEvents);
|
|
sinon.assert.callCount(subscribeSpy, 6);
|
|
sinon.assert.calledOnce(db.update);
|
|
assert(!!db.update.firstCall.args[0].delivered_at);
|
|
});
|
|
|
|
it('Handles email opened events', async function () {
|
|
const DomainEvents = {
|
|
subscribe: async (type, handler) => {
|
|
if (type === EmailOpenedEvent) {
|
|
handler(EmailOpenedEvent.create({
|
|
email: 'example@example.com',
|
|
memberId: '123',
|
|
emailId: '456',
|
|
emailRecipientId: '789'
|
|
}, new Date(0)));
|
|
}
|
|
}
|
|
};
|
|
|
|
const subscribeSpy = sinon.spy(DomainEvents, 'subscribe');
|
|
const db = stubDb();
|
|
const eventHandler = new EmailEventStorage({db});
|
|
eventHandler.listen(DomainEvents);
|
|
sinon.assert.callCount(subscribeSpy, 6);
|
|
sinon.assert.calledOnce(db.update);
|
|
assert(!!db.update.firstCall.args[0].opened_at);
|
|
});
|
|
|
|
it('Handles email permanent bounce events with update', async function () {
|
|
let waitPromise;
|
|
|
|
const DomainEvents = {
|
|
subscribe: async (type, handler) => {
|
|
if (type === EmailBouncedEvent) {
|
|
waitPromise = handler(EmailBouncedEvent.create({
|
|
email: 'example@example.com',
|
|
memberId: '123',
|
|
emailId: '456',
|
|
emailRecipientId: '789',
|
|
error: {
|
|
message: 'test',
|
|
code: 500,
|
|
enhancedCode: '5.5.5'
|
|
}
|
|
}, new Date(0)));
|
|
}
|
|
}
|
|
};
|
|
|
|
const subscribeSpy = sinon.spy(DomainEvents, 'subscribe');
|
|
const db = stubDb();
|
|
const existing = {
|
|
id: 1,
|
|
get: (key) => {
|
|
if (key === 'severity') {
|
|
return 'temporary';
|
|
}
|
|
if (key === 'failed_at') {
|
|
return new Date(-5);
|
|
}
|
|
},
|
|
save: sinon.stub().resolves()
|
|
};
|
|
const EmailRecipientFailure = {
|
|
transaction: async function (callback) {
|
|
return await callback(1);
|
|
},
|
|
findOne: sinon.stub().resolves(existing)
|
|
};
|
|
|
|
const eventHandler = new EmailEventStorage({
|
|
db,
|
|
models: {
|
|
EmailRecipientFailure
|
|
}
|
|
});
|
|
eventHandler.listen(DomainEvents);
|
|
sinon.assert.callCount(subscribeSpy, 6);
|
|
await waitPromise;
|
|
sinon.assert.calledOnce(db.update);
|
|
assert(!!db.update.firstCall.args[0].failed_at);
|
|
assert(existing.save.calledOnce);
|
|
});
|
|
|
|
it('Handles email permanent bounce events with insert', async function () {
|
|
let waitPromise;
|
|
|
|
const DomainEvents = {
|
|
subscribe: async (type, handler) => {
|
|
if (type === EmailBouncedEvent) {
|
|
waitPromise = handler(EmailBouncedEvent.create({
|
|
email: 'example@example.com',
|
|
memberId: '123',
|
|
emailId: '456',
|
|
emailRecipientId: '789',
|
|
error: {
|
|
message: 'test',
|
|
code: 500,
|
|
enhancedCode: '5.5.5'
|
|
}
|
|
}, new Date(0)));
|
|
}
|
|
}
|
|
};
|
|
|
|
const subscribeSpy = sinon.spy(DomainEvents, 'subscribe');
|
|
const db = stubDb();
|
|
const EmailRecipientFailure = {
|
|
transaction: async function (callback) {
|
|
return await callback(1);
|
|
},
|
|
findOne: sinon.stub().resolves(undefined),
|
|
add: sinon.stub().resolves()
|
|
};
|
|
|
|
const eventHandler = new EmailEventStorage({
|
|
db,
|
|
models: {
|
|
EmailRecipientFailure
|
|
}
|
|
});
|
|
eventHandler.listen(DomainEvents);
|
|
sinon.assert.callCount(subscribeSpy, 6);
|
|
await waitPromise;
|
|
sinon.assert.calledOnce(db.update);
|
|
assert(!!db.update.firstCall.args[0].failed_at);
|
|
assert(EmailRecipientFailure.add.calledOnce);
|
|
});
|
|
|
|
it('Handles email permanent bounce events with skipped update', async function () {
|
|
let waitPromise;
|
|
|
|
const DomainEvents = {
|
|
subscribe: async (type, handler) => {
|
|
if (type === EmailBouncedEvent) {
|
|
waitPromise = handler(EmailBouncedEvent.create({
|
|
email: 'example@example.com',
|
|
memberId: '123',
|
|
emailId: '456',
|
|
emailRecipientId: '789',
|
|
error: {
|
|
message: 'test',
|
|
code: 500,
|
|
enhancedCode: '5.5.5'
|
|
}
|
|
}, new Date(0)));
|
|
}
|
|
}
|
|
};
|
|
|
|
const subscribeSpy = sinon.spy(DomainEvents, 'subscribe');
|
|
const db = stubDb();
|
|
const existing = {
|
|
id: 1,
|
|
get: (key) => {
|
|
if (key === 'severity') {
|
|
return 'permanent';
|
|
}
|
|
if (key === 'failed_at') {
|
|
return new Date(-5);
|
|
}
|
|
},
|
|
save: sinon.stub().resolves()
|
|
};
|
|
const EmailRecipientFailure = {
|
|
transaction: async function (callback) {
|
|
return await callback(1);
|
|
},
|
|
findOne: sinon.stub().resolves(existing)
|
|
};
|
|
|
|
const eventHandler = new EmailEventStorage({
|
|
db,
|
|
models: {
|
|
EmailRecipientFailure
|
|
}
|
|
});
|
|
eventHandler.listen(DomainEvents);
|
|
sinon.assert.callCount(subscribeSpy, 6);
|
|
await waitPromise;
|
|
sinon.assert.calledOnce(db.update);
|
|
assert(!!db.update.firstCall.args[0].failed_at);
|
|
assert(EmailRecipientFailure.findOne.called);
|
|
assert(!existing.save.called);
|
|
});
|
|
|
|
it('Handles email temporary bounce events with update', async function () {
|
|
let waitPromise;
|
|
|
|
const DomainEvents = {
|
|
subscribe: async (type, handler) => {
|
|
if (type === EmailTemporaryBouncedEvent) {
|
|
waitPromise = handler(EmailTemporaryBouncedEvent.create({
|
|
email: 'example@example.com',
|
|
memberId: '123',
|
|
emailId: '456',
|
|
emailRecipientId: '789',
|
|
error: {
|
|
message: 'test',
|
|
code: 500,
|
|
enhancedCode: '5.5.5'
|
|
}
|
|
}, new Date(0)));
|
|
}
|
|
}
|
|
};
|
|
|
|
const subscribeSpy = sinon.spy(DomainEvents, 'subscribe');
|
|
const existing = {
|
|
id: 1,
|
|
get: (key) => {
|
|
if (key === 'severity') {
|
|
return 'temporary';
|
|
}
|
|
if (key === 'failed_at') {
|
|
return new Date(-5);
|
|
}
|
|
},
|
|
save: sinon.stub().resolves()
|
|
};
|
|
const EmailRecipientFailure = {
|
|
transaction: async function (callback) {
|
|
return await callback(1);
|
|
},
|
|
findOne: sinon.stub().resolves(existing)
|
|
};
|
|
|
|
const eventHandler = new EmailEventStorage({
|
|
models: {
|
|
EmailRecipientFailure
|
|
}
|
|
});
|
|
eventHandler.listen(DomainEvents);
|
|
sinon.assert.callCount(subscribeSpy, 6);
|
|
await waitPromise;
|
|
assert(existing.save.calledOnce);
|
|
});
|
|
|
|
it('Handles unsubscribe', async function () {
|
|
let waitPromise;
|
|
|
|
const DomainEvents = {
|
|
subscribe: async (type, handler) => {
|
|
if (type === EmailUnsubscribedEvent) {
|
|
waitPromise = handler(EmailUnsubscribedEvent.create({
|
|
email: 'example@example.com',
|
|
memberId: '123',
|
|
emailId: '456'
|
|
}, new Date(0)));
|
|
}
|
|
}
|
|
};
|
|
|
|
const subscribeSpy = sinon.spy(DomainEvents, 'subscribe');
|
|
const update = sinon.stub().resolves();
|
|
|
|
const eventHandler = new EmailEventStorage({
|
|
membersRepository: {
|
|
update
|
|
}
|
|
});
|
|
eventHandler.listen(DomainEvents);
|
|
sinon.assert.callCount(subscribeSpy, 6);
|
|
await waitPromise;
|
|
assert(update.calledOnce);
|
|
assert(update.firstCall.args[0].newsletters.length === 0);
|
|
});
|
|
|
|
it('Handles complaints', async function () {
|
|
let waitPromise;
|
|
|
|
const DomainEvents = {
|
|
subscribe: async (type, handler) => {
|
|
if (type === SpamComplaintEvent) {
|
|
waitPromise = handler(SpamComplaintEvent.create({
|
|
email: 'example@example.com',
|
|
memberId: '123',
|
|
emailId: '456'
|
|
}, new Date(0)));
|
|
}
|
|
}
|
|
};
|
|
|
|
const subscribeSpy = sinon.spy(DomainEvents, 'subscribe');
|
|
const EmailSpamComplaintEvent = {
|
|
add: sinon.stub().resolves()
|
|
};
|
|
|
|
const eventHandler = new EmailEventStorage({
|
|
models: {
|
|
EmailSpamComplaintEvent
|
|
}
|
|
});
|
|
eventHandler.listen(DomainEvents);
|
|
sinon.assert.callCount(subscribeSpy, 6);
|
|
await waitPromise;
|
|
assert(EmailSpamComplaintEvent.add.calledOnce);
|
|
});
|
|
});
|