mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-11-27 00:52:36 +03:00
2f57e95a5d
refs https://www.notion.so/ghost/Marketing-Milestone-email-campaigns-1d2c9dee3cfa4029863edb16092ad5c4?pvs=4 - Added a `slack-notifications` repository which handles sending Slack messages to a URL as defined in our Ghost(Pro) config (also includes a global switch to disable the feature if needed) and listens to `MilestoneCreatedEvents`. - Added a `slack-notification` service which listens to the events on boot. - In order to have access to further information such as the reason why a Milestone email hasn't been sent, or the current ARR or Member value as comparison to the achieved milestone, I added a `meta` object to the `MilestoneCreatedEvent` which then gets accessible by the event subscriber. This avoid doing further requests to the DB as we need to have this information in relation to the event occurred. --------- Co-authored-by: Fabien "egg" O'Carroll <fabien@allou.is>
458 lines
16 KiB
JavaScript
458 lines
16 KiB
JavaScript
const assert = require('assert');
|
|
const {
|
|
MilestonesService,
|
|
InMemoryMilestoneRepository
|
|
} = require('../index');
|
|
const Milestone = require('../lib/Milestone');
|
|
const DomainEvents = require('@tryghost/domain-events');
|
|
const sinon = require('sinon');
|
|
|
|
describe('MilestonesService', function () {
|
|
let repository;
|
|
let domainEventSpy;
|
|
|
|
beforeEach(async function () {
|
|
domainEventSpy = sinon.spy(DomainEvents, 'dispatch');
|
|
});
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
});
|
|
|
|
const milestonesConfig = {
|
|
arr: [
|
|
{
|
|
currency: 'usd',
|
|
values: [1000, 10000, 50000, 100000, 250000, 500000, 1000000]
|
|
},
|
|
{
|
|
currency: 'gbp',
|
|
values: [500, 1000, 5000, 100000, 250000, 500000, 1000000]
|
|
},
|
|
{
|
|
currency: 'idr',
|
|
values: [1000, 10000, 50000, 100000, 250000, 500000, 1000000]
|
|
},
|
|
{
|
|
currency: 'eur',
|
|
values: [1000, 10000, 50000, 100000, 250000, 500000, 1000000]
|
|
}
|
|
],
|
|
members: [100, 1000, 10000, 50000, 100000, 250000, 500000, 1000000]
|
|
|
|
};
|
|
|
|
describe('ARR Milestones', function () {
|
|
it('Adds first ARR milestone and sends email', async function () {
|
|
repository = new InMemoryMilestoneRepository({DomainEvents});
|
|
|
|
const milestoneEmailService = new MilestonesService({
|
|
repository,
|
|
milestonesConfig,
|
|
queries: {
|
|
async getARR() {
|
|
return [{currency: 'usd', arr: 1298}, {currency: 'nzd', arr: 600}];
|
|
},
|
|
async hasImportedMembersInPeriod() {
|
|
return false;
|
|
},
|
|
async getDefaultCurrency() {
|
|
return 'usd';
|
|
}
|
|
}
|
|
});
|
|
|
|
const arrResult = await milestoneEmailService.checkMilestones('arr');
|
|
assert(arrResult.type === 'arr');
|
|
assert(arrResult.currency === 'usd');
|
|
assert(arrResult.value === 1000);
|
|
assert(arrResult.emailSentAt !== null);
|
|
assert(arrResult.name === 'arr-1000-usd');
|
|
|
|
const domainEventSpyResult = domainEventSpy.getCall(0).args[0];
|
|
assert(domainEventSpy.calledOnce === true);
|
|
assert(domainEventSpyResult.data.milestone);
|
|
assert(domainEventSpyResult.data.meta.currentARR === 1298);
|
|
});
|
|
|
|
it('Adds next ARR milestone and sends email', async function () {
|
|
repository = new InMemoryMilestoneRepository({DomainEvents});
|
|
|
|
const milestoneOne = await Milestone.create({
|
|
type: 'arr',
|
|
value: 100,
|
|
createdAt: '2023-01-01T00:00:00Z',
|
|
emailSentAt: '2023-01-01T00:00:00Z'
|
|
});
|
|
|
|
const milestoneTwo = await Milestone.create({
|
|
type: 'arr',
|
|
value: 500,
|
|
createdAt: '2023-01-02T00:00:00Z',
|
|
emailSentAt: '2023-01-02T00:00:00Z'
|
|
});
|
|
|
|
const milestoneThree = await Milestone.create({
|
|
type: 'arr',
|
|
value: 1000,
|
|
currency: 'eur',
|
|
createdAt: '2023-01-15T00:00:00Z',
|
|
emailSentAt: '2023-01-15T00:00:00Z'
|
|
});
|
|
|
|
await repository.save(milestoneOne);
|
|
await repository.save(milestoneTwo);
|
|
await repository.save(milestoneThree);
|
|
|
|
assert(domainEventSpy.callCount === 3);
|
|
|
|
const milestoneEmailService = new MilestonesService({
|
|
repository,
|
|
milestonesConfig,
|
|
queries: {
|
|
async getARR() {
|
|
// Same ARR values for both supported currencies
|
|
return [{currency: 'usd', arr: 10001}, {currency: 'eur', arr: 10001}];
|
|
},
|
|
async hasImportedMembersInPeriod() {
|
|
return false;
|
|
},
|
|
async getDefaultCurrency() {
|
|
return 'usd';
|
|
}
|
|
}
|
|
});
|
|
|
|
const arrResult = await milestoneEmailService.checkMilestones('arr');
|
|
assert(arrResult.type === 'arr');
|
|
assert(arrResult.currency === 'usd');
|
|
assert(arrResult.value === 10000);
|
|
assert(arrResult.emailSentAt !== null);
|
|
assert(arrResult.name === 'arr-10000-usd');
|
|
assert(domainEventSpy.callCount === 4); // we have just created a new milestone
|
|
const domainEventSpyResult = domainEventSpy.getCall(3).args[0];
|
|
assert(domainEventSpyResult.data.milestone);
|
|
assert(domainEventSpyResult.data.meta.currentARR === 10001);
|
|
});
|
|
|
|
it('Does not add ARR milestone for out of scope currency', async function () {
|
|
repository = new InMemoryMilestoneRepository({DomainEvents});
|
|
|
|
const milestoneEmailService = new MilestonesService({
|
|
repository,
|
|
milestonesConfig,
|
|
queries: {
|
|
async getARR() {
|
|
return [{currency: 'nzd', arr: 1005}];
|
|
},
|
|
async hasImportedMembersInPeriod() {
|
|
return false;
|
|
},
|
|
async getDefaultCurrency() {
|
|
return 'nzd';
|
|
}
|
|
}
|
|
});
|
|
|
|
const arrResult = await milestoneEmailService.checkMilestones('arr');
|
|
assert(arrResult === undefined);
|
|
assert(domainEventSpy.callCount === 0);
|
|
});
|
|
|
|
it('Does not add new ARR milestone if already achieved', async function () {
|
|
repository = new InMemoryMilestoneRepository({DomainEvents});
|
|
|
|
const milestone = await Milestone.create({
|
|
type: 'arr',
|
|
value: 5000,
|
|
currency: 'gbp'
|
|
});
|
|
|
|
await repository.save(milestone);
|
|
|
|
assert(domainEventSpy.callCount === 1);
|
|
|
|
const milestoneEmailService = new MilestonesService({
|
|
repository,
|
|
milestonesConfig,
|
|
queries: {
|
|
async getARR() {
|
|
return [{currency: 'gbp', arr: 5005}, {currency: 'usd', arr: 100}];
|
|
},
|
|
async hasImportedMembersInPeriod() {
|
|
return false;
|
|
},
|
|
async getDefaultCurrency() {
|
|
return 'gbp';
|
|
}
|
|
}
|
|
});
|
|
|
|
const arrResult = await milestoneEmailService.checkMilestones('arr');
|
|
assert(arrResult === undefined);
|
|
assert(domainEventSpy.callCount === 1);
|
|
});
|
|
|
|
it('Adds ARR milestone but does not send email if imported members are detected', async function () {
|
|
repository = new InMemoryMilestoneRepository({DomainEvents});
|
|
|
|
const milestoneEmailService = new MilestonesService({
|
|
repository,
|
|
milestonesConfig,
|
|
queries: {
|
|
async getARR() {
|
|
return [{currency: 'usd', arr: 100000}, {currency: 'idr', arr: 2600}];
|
|
},
|
|
async hasImportedMembersInPeriod() {
|
|
return true;
|
|
},
|
|
async getDefaultCurrency() {
|
|
return 'usd';
|
|
}
|
|
}
|
|
});
|
|
|
|
const arrResult = await milestoneEmailService.checkMilestones('arr');
|
|
assert(arrResult.type === 'arr');
|
|
assert(arrResult.currency === 'usd');
|
|
assert(arrResult.value === 100000);
|
|
assert(arrResult.emailSentAt === null);
|
|
assert(domainEventSpy.callCount === 1);
|
|
const domainEventSpyResult = domainEventSpy.getCall(0).args[0];
|
|
assert(domainEventSpyResult.data.meta.reason === 'import');
|
|
});
|
|
|
|
it('Adds ARR milestone but does not send email if last email was too recent', async function () {
|
|
repository = new InMemoryMilestoneRepository({DomainEvents});
|
|
|
|
const lessThanTwoWeeksAgo = new Date();
|
|
lessThanTwoWeeksAgo.setDate(lessThanTwoWeeksAgo.getDate() - 12);
|
|
|
|
const milestone = await Milestone.create({
|
|
type: 'arr',
|
|
value: 1000,
|
|
currency: 'idr',
|
|
emailSentAt: lessThanTwoWeeksAgo
|
|
});
|
|
|
|
await repository.save(milestone);
|
|
assert(domainEventSpy.callCount === 1);
|
|
|
|
const milestoneEmailService = new MilestonesService({
|
|
repository,
|
|
milestonesConfig,
|
|
queries: {
|
|
async getARR() {
|
|
return [{currency: 'idr', arr: 10000}];
|
|
},
|
|
async hasImportedMembersInPeriod() {
|
|
return false;
|
|
},
|
|
async getDefaultCurrency() {
|
|
return 'idr';
|
|
}
|
|
}
|
|
});
|
|
|
|
const arrResult = await milestoneEmailService.checkMilestones('arr');
|
|
assert(arrResult.type === 'arr');
|
|
assert(arrResult.currency === 'idr');
|
|
assert(arrResult.value === 10000);
|
|
assert(arrResult.emailSentAt === null);
|
|
assert(domainEventSpy.callCount === 2); // new milestone created
|
|
const domainEventSpyResult = domainEventSpy.getCall(1).args[0];
|
|
assert(domainEventSpyResult.data.meta.reason === 'email');
|
|
});
|
|
});
|
|
|
|
describe('Members Milestones', function () {
|
|
it('Adds first Members milestone and sends email', async function () {
|
|
repository = new InMemoryMilestoneRepository({DomainEvents});
|
|
|
|
const milestoneEmailService = new MilestonesService({
|
|
repository,
|
|
milestonesConfig,
|
|
queries: {
|
|
async getMembersCount() {
|
|
return 110;
|
|
},
|
|
async hasImportedMembersInPeriod() {
|
|
return false;
|
|
},
|
|
async getDefaultCurrency() {
|
|
return 'usd';
|
|
}
|
|
}
|
|
});
|
|
|
|
const membersResult = await milestoneEmailService.checkMilestones('members');
|
|
assert(membersResult.type === 'members');
|
|
assert(membersResult.value === 100);
|
|
assert(membersResult.emailSentAt !== null);
|
|
assert(domainEventSpy.callCount === 1);
|
|
});
|
|
|
|
it('Adds next Members milestone and sends email', async function () {
|
|
repository = new InMemoryMilestoneRepository({DomainEvents});
|
|
|
|
const milestoneOne = await Milestone.create({
|
|
type: 'members',
|
|
value: 1000,
|
|
createdAt: '2023-01-01T00:00:00Z',
|
|
emailSentAt: '2023-01-01T00:00:00Z'
|
|
});
|
|
|
|
const milestoneTwo = await Milestone.create({
|
|
type: 'members',
|
|
value: 500,
|
|
createdAt: '2023-01-02T00:00:00Z',
|
|
emailSentAt: '2023-01-02T00:00:00Z'
|
|
});
|
|
|
|
const milestoneThree = await Milestone.create({
|
|
type: 'members',
|
|
value: 1000,
|
|
createdAt: '2023-01-15T00:00:00Z',
|
|
emailSentAt: '2023-01-15T00:00:00Z'
|
|
});
|
|
|
|
await repository.save(milestoneOne);
|
|
await repository.save(milestoneTwo);
|
|
await repository.save(milestoneThree);
|
|
|
|
assert(domainEventSpy.callCount === 3);
|
|
|
|
const milestoneEmailService = new MilestonesService({
|
|
repository,
|
|
milestonesConfig,
|
|
queries: {
|
|
async getMembersCount() {
|
|
return 50005;
|
|
},
|
|
async hasImportedMembersInPeriod() {
|
|
return false;
|
|
},
|
|
async getDefaultCurrency() {
|
|
return 'usd';
|
|
}
|
|
}
|
|
});
|
|
|
|
const membersResult = await milestoneEmailService.checkMilestones('members');
|
|
assert(membersResult.type === 'members');
|
|
assert(membersResult.currency === null);
|
|
assert(membersResult.value === 50000);
|
|
assert(membersResult.emailSentAt !== null);
|
|
assert(membersResult.name === 'members-50000');
|
|
assert(domainEventSpy.callCount === 4);
|
|
});
|
|
|
|
it('Does not add new Members milestone if already achieved', async function () {
|
|
repository = new InMemoryMilestoneRepository({DomainEvents});
|
|
|
|
const milestone = await Milestone.create({
|
|
type: 'members',
|
|
value: 50000
|
|
});
|
|
|
|
await repository.save(milestone);
|
|
|
|
assert(domainEventSpy.callCount === 1);
|
|
|
|
const milestoneEmailService = new MilestonesService({
|
|
repository,
|
|
milestonesConfig,
|
|
queries: {
|
|
async getMembersCount() {
|
|
return 50555;
|
|
},
|
|
async hasImportedMembersInPeriod() {
|
|
return false;
|
|
},
|
|
async getDefaultCurrency() {
|
|
return 'usd';
|
|
}
|
|
}
|
|
});
|
|
|
|
const membersResult = await milestoneEmailService.checkMilestones('members');
|
|
assert(membersResult === undefined);
|
|
assert(domainEventSpy.callCount === 1);
|
|
});
|
|
|
|
it('Adds Members milestone but does not send email if imported members are detected', async function () {
|
|
repository = new InMemoryMilestoneRepository({DomainEvents});
|
|
|
|
const milestone = await Milestone.create({
|
|
type: 'members',
|
|
value: 100
|
|
});
|
|
|
|
await repository.save(milestone);
|
|
|
|
assert(domainEventSpy.callCount === 1);
|
|
|
|
const milestoneEmailService = new MilestonesService({
|
|
repository,
|
|
milestonesConfig,
|
|
queries: {
|
|
async getMembersCount() {
|
|
return 1001;
|
|
},
|
|
async hasImportedMembersInPeriod() {
|
|
return true;
|
|
},
|
|
async getDefaultCurrency() {
|
|
return 'usd';
|
|
}
|
|
}
|
|
});
|
|
|
|
const membersResult = await milestoneEmailService.checkMilestones('members');
|
|
assert(membersResult.type === 'members');
|
|
assert(membersResult.value === 1000);
|
|
assert(membersResult.emailSentAt === null);
|
|
assert(domainEventSpy.callCount === 2);
|
|
});
|
|
|
|
it('Adds Members milestone but does not send email if last email was too recent', async function () {
|
|
repository = new InMemoryMilestoneRepository({DomainEvents});
|
|
|
|
const lessThanTwoWeeksAgo = new Date();
|
|
lessThanTwoWeeksAgo.setDate(lessThanTwoWeeksAgo.getDate() - 8);
|
|
|
|
const milestone = await Milestone.create({
|
|
type: 'members',
|
|
value: 100,
|
|
emailSentAt: lessThanTwoWeeksAgo
|
|
});
|
|
|
|
await repository.save(milestone);
|
|
|
|
assert(domainEventSpy.callCount === 1);
|
|
|
|
const milestoneEmailService = new MilestonesService({
|
|
repository,
|
|
milestonesConfig,
|
|
queries: {
|
|
async getMembersCount() {
|
|
return 50010;
|
|
},
|
|
async hasImportedMembersInPeriod() {
|
|
return false;
|
|
},
|
|
async getDefaultCurrency() {
|
|
return 'usd';
|
|
}
|
|
}
|
|
});
|
|
|
|
const membersResult = await milestoneEmailService.checkMilestones('members');
|
|
assert(membersResult.type === 'members');
|
|
assert(membersResult.value === 50000);
|
|
assert(membersResult.emailSentAt === null);
|
|
assert(domainEventSpy.callCount === 2);
|
|
});
|
|
});
|
|
});
|