mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-21 09:52:06 +03:00
b392d1925a
refs #9601 ### Dynamic Routing This is the beta version of dynamic routing. - we had a initial implementation of "channels" available in the codebase - we have removed and moved this implementation - there is now a centralised place for dynamic routing - server/services/routing - each routing component is represented by a router type e.g. collections, routes, static pages, taxonomies, rss, preview of posts - keep as much as possible logic of routing helpers, middlewares and controllers - ensure test coverage - connect all the things together - yaml file + validation - routing + routers - url service - sitemaps - url access - deeper implementation of yaml validations - e.g. hard require slashes - ensure routing hierarchy/order - e.g. you enable the subscriber app - you have a custom static page, which lives under the same slug /subscribe - static pages are stronger than apps - e.g. the first collection owns the post it has filtered - a post cannot live in two collections - ensure apps are still working and hook into the routers layer (or better said: and register in the routing service) - put as much as possible comments to the code base for better understanding - ensure a clean debug log - ensure we can unmount routes - e.g. you have a collection permalink of /:slug/ represented by {globals.permalink} - and you change the permalink in the admin to dated permalink - the express route get's refreshed from /:slug/ to /:year/:month/:day/:slug/ - unmount without server restart, yey - ensure we are backwards compatible - e.g. render home.hbs for collection index if collection route is / - ensure you can access your configured permalink from the settings table with {globals.permalink} ### Render 503 if url service did not finish - return 503 if the url service has not finished generating the resource urls ### Rewrite sitemaps - we have rewritten the sitemaps "service", because the url generator does no longer happen on runtime - we generate all urls on bootstrap - the sitemaps service will consume created resource and router urls - these urls will be shown on the xml pages - we listen on url events - we listen on router events - we no longer have to fetch the resources, which is nice - the urlservice pre-fetches resources and emits their urls - the urlservice is the only component who knows which urls are valid - i made some ES6 adaptions - we keep the caching logic -> only regenerate xml if there is a change - updated tests - checked test coverage (100%) ### Re-work usage of Url utility - replace all usages of `urlService.utils.urlFor` by `urlService.getByResourceId` - only for resources e.g. post, author, tag - this is important, because with dynamic routing we no longer create static urls based on the settings permalink on runtime - adapt url utility - adapt tests
208 lines
6.2 KiB
JavaScript
208 lines
6.2 KiB
JavaScript
const _ = require('lodash'),
|
|
jsonpath = require('jsonpath'),
|
|
debug = require('ghost-ignition').debug('services:url:generator'),
|
|
localUtils = require('./utils'),
|
|
/**
|
|
* @TODO: This is a fake version of the upcoming GQL tool.
|
|
* GQL will offer a tool to match a JSON against a filter.
|
|
*/
|
|
transformFilter = (filter) => {
|
|
filter = '$[?(' + filter + ')]';
|
|
filter = filter.replace(/(\w+):(\w+)/g, '@.$1 == "$2"');
|
|
filter = filter.replace(/"true"/g, 'true');
|
|
filter = filter.replace(/"false"/g, 'false');
|
|
filter = filter.replace(/"0"/g, '0');
|
|
filter = filter.replace(/"1"/g, '1');
|
|
filter = filter.replace(/\+/g, ' && ');
|
|
return filter;
|
|
};
|
|
|
|
class UrlGenerator {
|
|
constructor(router, queue, resources, urls, position) {
|
|
this.router = router;
|
|
this.queue = queue;
|
|
this.urls = urls;
|
|
this.resources = resources;
|
|
this.uid = position;
|
|
|
|
debug('constructor', this.toString());
|
|
|
|
// CASE: routers can define custom filters, but not required.
|
|
if (this.router.getFilter()) {
|
|
this.filter = transformFilter(this.router.getFilter());
|
|
debug('filter', this.filter);
|
|
}
|
|
|
|
this._listeners();
|
|
}
|
|
|
|
_listeners() {
|
|
/**
|
|
* @NOTE: currently only used if the permalink setting changes and it's used for this url generator.
|
|
* @TODO: remove in Ghost 2.0
|
|
*/
|
|
this.router.addListener('updated', () => {
|
|
const myResources = this.urls.getByGeneratorId(this.uid);
|
|
|
|
myResources.forEach((object) => {
|
|
this.urls.removeResourceId(object.resource.data.id);
|
|
object.resource.release();
|
|
this._try(object.resource);
|
|
});
|
|
});
|
|
|
|
/**
|
|
* Listen on two events:
|
|
*
|
|
* - init: bootstrap or url reset
|
|
* - added: resource was added
|
|
*/
|
|
this.queue.register({
|
|
event: 'init',
|
|
tolerance: 100
|
|
}, this._onInit.bind(this));
|
|
|
|
// @TODO: listen on added event per type (post optimisation)
|
|
this.queue.register({
|
|
event: 'added'
|
|
}, this._onAdded.bind(this));
|
|
}
|
|
|
|
_onInit() {
|
|
debug('_onInit', this.toString());
|
|
|
|
// @NOTE: get the resources of my type e.g. posts.
|
|
const resources = this.resources.getAllByType(this.router.getType());
|
|
|
|
_.each(resources, (resource) => {
|
|
this._try(resource);
|
|
});
|
|
}
|
|
|
|
_onAdded(event) {
|
|
debug('onAdded', this.toString());
|
|
|
|
// CASE: you are type "pages", but the incoming type is "users"
|
|
if (event.type !== this.router.getType()) {
|
|
return;
|
|
}
|
|
|
|
const resource = this.resources.getByIdAndType(event.type, event.id);
|
|
|
|
this._try(resource);
|
|
}
|
|
|
|
_try(resource) {
|
|
/**
|
|
* CASE: another url generator has taken this resource already.
|
|
*
|
|
* We have to remember that, because each url generator can generate a different url
|
|
* for a resource. So we can't directly check `this.urls.getUrl(url)`.
|
|
*/
|
|
if (resource.isReserved()) {
|
|
return false;
|
|
}
|
|
|
|
const url = this._generateUrl(resource);
|
|
|
|
// CASE 1: route has no custom filter, it will own the resource for sure
|
|
// CASE 2: find out if my filter matches the resource
|
|
if (!this.filter) {
|
|
this.urls.add({
|
|
url: url,
|
|
generatorId: this.uid,
|
|
resource: resource
|
|
});
|
|
|
|
resource.reserve();
|
|
this._resourceListeners(resource);
|
|
return true;
|
|
} else if (jsonpath.query(resource, this.filter).length) {
|
|
this.urls.add({
|
|
url: url,
|
|
generatorId: this.uid,
|
|
resource: resource
|
|
});
|
|
|
|
resource.reserve();
|
|
this._resourceListeners(resource);
|
|
return true;
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* We currently generate relative urls.
|
|
*/
|
|
_generateUrl(resource) {
|
|
const permalink = this.router.getPermalinks().getValue();
|
|
const url = localUtils.replacePermalink(permalink, resource.data);
|
|
|
|
return localUtils.createUrl(url, false, false, true);
|
|
}
|
|
|
|
/**
|
|
* I want to know if my resources changes.
|
|
* Register events of resource.
|
|
*/
|
|
_resourceListeners(resource) {
|
|
const onUpdate = (updatedResource) => {
|
|
// 1. remove old resource
|
|
this.urls.removeResourceId(updatedResource.data.id);
|
|
|
|
// 2. free resource, the url <-> resource connection no longer exists
|
|
updatedResource.release();
|
|
|
|
// 3. try to own the resource again
|
|
// Imagine you change `featured` to true and your filter excludes featured posts.
|
|
const isMine = this._try(updatedResource);
|
|
|
|
// 4. if the resource is no longer mine, tell the others
|
|
// e.g. post -> page
|
|
// e.g. post is featured now
|
|
if (!isMine) {
|
|
debug('free, this is not mine anymore', updatedResource.data.id);
|
|
|
|
this.queue.start({
|
|
event: 'added',
|
|
action: 'added:' + resource.data.id,
|
|
eventData: {
|
|
id: resource.data.id,
|
|
type: this.router.getType()
|
|
}
|
|
});
|
|
}
|
|
};
|
|
|
|
const onRemoved = (removedResource) => {
|
|
this.urls.removeResourceId(removedResource.data.id);
|
|
removedResource.release();
|
|
};
|
|
|
|
resource.removeAllListeners();
|
|
resource.addListener('updated', onUpdate.bind(this));
|
|
resource.addListener('removed', onRemoved.bind(this));
|
|
}
|
|
|
|
hasUrl(url) {
|
|
const existingUrl = this.urls.getByUrl(url);
|
|
|
|
if (existingUrl.length && existingUrl[0].generatorId === this.uid) {
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
getUrls() {
|
|
return this.urls.getByGeneratorId(this.uid);
|
|
}
|
|
|
|
toString() {
|
|
return this.router.toString();
|
|
}
|
|
}
|
|
|
|
module.exports = UrlGenerator;
|