mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-11 09:53:32 +03:00
6f1abc610a
refs https://github.com/TryGhost/Ghost/issues/12033 refs https://github.com/TryGhost/Ghost/issues/10567 - Creating a webhook without valid parent integration leads to orphaned webhook records, which shoult not ever happen - This scenario is only possible for non-integration authentication, because in case of integration being authenticated it's id is automatically assigned to creatd webhook
161 lines
6.1 KiB
JavaScript
161 lines
6.1 KiB
JavaScript
const models = require('../../models');
|
|
const {i18n} = require('../../lib/common');
|
|
const errors = require('@tryghost/errors');
|
|
|
|
module.exports = {
|
|
docName: 'webhooks',
|
|
|
|
add: {
|
|
statusCode: 201,
|
|
headers: {
|
|
// NOTE: remove if there is ever a 'read' method
|
|
location: false
|
|
},
|
|
options: [],
|
|
data: [],
|
|
permissions: true,
|
|
async query(frame) {
|
|
const isIntegrationRequest = frame.options.context && frame.options.context.integration && frame.options.context.integration.id;
|
|
|
|
// NOTE: this check can be removed once `webhooks.integration_id` gets foreigh ke constraint (Ghost 4.0)
|
|
if (!isIntegrationRequest && frame.data.webhooks[0].integration_id) {
|
|
const integration = await models.Integration.findOne({id: frame.data.webhooks[0].integration_id}, {context: {internal: true}});
|
|
|
|
if (!integration) {
|
|
throw new errors.ValidationError({
|
|
message: i18n.t('notices.data.validation.index.schemaValidationFailed', {
|
|
key: 'integration_id'
|
|
}),
|
|
context: i18n.t('errors.api.webhooks.nonExistingIntegrationIdProvided.context'),
|
|
help: i18n.t('errors.api.webhooks.nonExistingIntegrationIdProvided.help')
|
|
});
|
|
}
|
|
}
|
|
|
|
const webhook = await models.Webhook.getByEventAndTarget(
|
|
frame.data.webhooks[0].event,
|
|
frame.data.webhooks[0].target_url,
|
|
frame.options
|
|
);
|
|
|
|
if (webhook) {
|
|
throw new errors.ValidationError({message: i18n.t('errors.api.webhooks.webhookAlreadyExists')});
|
|
}
|
|
|
|
return models.Webhook.add(frame.data.webhooks[0], frame.options);
|
|
}
|
|
},
|
|
|
|
edit: {
|
|
permissions: {
|
|
before: (frame) => {
|
|
if (frame.options.context && frame.options.context.integration && frame.options.context.integration.id) {
|
|
return models.Webhook.findOne({id: frame.options.id})
|
|
.then((webhook) => {
|
|
if (!webhook) {
|
|
throw new errors.NotFoundError({
|
|
message: i18n.t('errors.api.resource.resourceNotFound', {
|
|
resource: 'Webhook'
|
|
})
|
|
});
|
|
}
|
|
|
|
if (webhook.get('integration_id') !== frame.options.context.integration.id) {
|
|
throw new errors.NoPermissionError({
|
|
message: i18n.t('errors.api.webhooks.noPermissionToEdit.message', {
|
|
method: 'edit'
|
|
}),
|
|
context: i18n.t('errors.api.webhooks.noPermissionToEdit.context', {
|
|
method: 'edit'
|
|
})
|
|
});
|
|
}
|
|
});
|
|
}
|
|
}
|
|
},
|
|
data: [
|
|
'name',
|
|
'event',
|
|
'target_url',
|
|
'secret',
|
|
'api_version'
|
|
],
|
|
options: [
|
|
'id'
|
|
],
|
|
validation: {
|
|
options: {
|
|
id: {
|
|
required: true
|
|
}
|
|
}
|
|
},
|
|
query({data, options}) {
|
|
return models.Webhook.edit(data.webhooks[0], Object.assign(options, {require: true}))
|
|
.catch(models.Webhook.NotFoundError, () => {
|
|
throw new errors.NotFoundError({
|
|
message: i18n.t('errors.api.resource.resourceNotFound', {
|
|
resource: 'Webhook'
|
|
})
|
|
});
|
|
});
|
|
}
|
|
},
|
|
|
|
destroy: {
|
|
statusCode: 204,
|
|
headers: {},
|
|
options: [
|
|
'id'
|
|
],
|
|
validation: {
|
|
options: {
|
|
id: {
|
|
required: true
|
|
}
|
|
}
|
|
},
|
|
permissions: {
|
|
before: (frame) => {
|
|
if (frame.options.context && frame.options.context.integration && frame.options.context.integration.id) {
|
|
return models.Webhook.findOne({id: frame.options.id})
|
|
.then((webhook) => {
|
|
if (!webhook) {
|
|
throw new errors.NotFoundError({
|
|
message: i18n.t('errors.api.resource.resourceNotFound', {
|
|
resource: 'Webhook'
|
|
})
|
|
});
|
|
}
|
|
|
|
if (webhook.get('integration_id') !== frame.options.context.integration.id) {
|
|
throw new errors.NoPermissionError({
|
|
message: i18n.t('errors.api.webhooks.noPermissionToEdit.message', {
|
|
method: 'destroy'
|
|
}),
|
|
context: i18n.t('errors.api.webhooks.noPermissionToEdit.context', {
|
|
method: 'destroy'
|
|
})
|
|
});
|
|
}
|
|
});
|
|
}
|
|
}
|
|
},
|
|
query(frame) {
|
|
frame.options.require = true;
|
|
|
|
return models.Webhook.destroy(frame.options)
|
|
.then(() => null)
|
|
.catch(models.Webhook.NotFoundError, () => {
|
|
return Promise.reject(new errors.NotFoundError({
|
|
message: i18n.t('errors.api.resource.resourceNotFound', {
|
|
resource: 'Webhook'
|
|
})
|
|
}));
|
|
});
|
|
}
|
|
}
|
|
};
|