mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-14 18:52:05 +03:00
fb044e6d88
refs #9389 - https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md Breaking changes for Ghost: - no need to create a sandbox anymore, each file get's it's own sandbox - just require sinon and use this sandbox - you can still create separate sandboxes with .createSandbox - reset single stubs: use .resetHistory instead of .reset This is a global replace for any sandbox creation. --- From https://sinonjs.org/releases/v7.2.3/sandbox/ > Default sandbox > Since sinon@5.0.0, the sinon object is a default sandbox. Unless you have a very advanced setup or need a special configuration, you probably want to just use that one.
237 lines
8.3 KiB
JavaScript
237 lines
8.3 KiB
JavaScript
var should = require('should'),
|
|
sinon = require('sinon'),
|
|
_ = require('lodash'),
|
|
rewire = require('rewire'),
|
|
testUtils = require('../../utils'),
|
|
configUtils = require('../../utils/configUtils'),
|
|
|
|
// Stuff we test
|
|
slack = rewire('../../../server/services/slack'),
|
|
common = require('../../../server/lib/common'),
|
|
urlService = require('../../../server/services/url'),
|
|
schema = require('../../../server/data/schema').checks,
|
|
settingsCache = require('../../../server/services/settings/cache'),
|
|
|
|
// Test data
|
|
slackObjNoUrl = [{url: ''}],
|
|
slackObjWithUrl = [{url: 'https://hooks.slack.com/services/a-b-c-d'}];
|
|
|
|
describe('Slack', function () {
|
|
var eventStub;
|
|
|
|
beforeEach(function () {
|
|
eventStub = sinon.stub(common.events, 'on');
|
|
});
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
configUtils.restore();
|
|
});
|
|
|
|
it('listen() should initialise event correctly', function () {
|
|
slack.listen();
|
|
eventStub.calledTwice.should.be.true();
|
|
eventStub.firstCall.calledWith('post.published', slack.__get__('listener')).should.be.true();
|
|
eventStub.secondCall.calledWith('slack.test', slack.__get__('testPing')).should.be.true();
|
|
});
|
|
|
|
it('listener() calls ping() with toJSONified model', function () {
|
|
var testPost = _.clone(testUtils.DataGenerator.Content.posts[2]),
|
|
testModel = {
|
|
toJSON: function () {
|
|
return testPost;
|
|
}
|
|
},
|
|
pingStub = sinon.stub(),
|
|
resetSlack = slack.__set__('ping', pingStub),
|
|
listener = slack.__get__('listener');
|
|
|
|
listener(testModel);
|
|
|
|
pingStub.calledOnce.should.be.true();
|
|
pingStub.calledWith(testPost).should.be.true();
|
|
|
|
// Reset slack ping method
|
|
resetSlack();
|
|
});
|
|
|
|
it('listener() does not call ping() when importing', function () {
|
|
var testPost = _.clone(testUtils.DataGenerator.Content.posts[2]),
|
|
testModel = {
|
|
toJSON: function () {
|
|
return testPost;
|
|
}
|
|
},
|
|
pingStub = sinon.stub(),
|
|
resetSlack = slack.__set__('ping', pingStub),
|
|
listener = slack.__get__('listener');
|
|
|
|
listener(testModel, {importing: true});
|
|
|
|
pingStub.calledOnce.should.be.false();
|
|
|
|
// Reset slack ping method
|
|
resetSlack();
|
|
});
|
|
|
|
it('testPing() calls ping() with default message', function () {
|
|
var pingStub = sinon.stub(),
|
|
resetSlack = slack.__set__('ping', pingStub),
|
|
testPing = slack.__get__('testPing');
|
|
|
|
testPing();
|
|
|
|
pingStub.calledOnce.should.be.true();
|
|
pingStub.calledWith(sinon.match.has('message')).should.be.true();
|
|
|
|
// Reset slack ping method
|
|
resetSlack();
|
|
});
|
|
|
|
describe('ping()', function () {
|
|
var isPostStub,
|
|
settingsCacheStub,
|
|
|
|
slackReset,
|
|
makeRequestStub,
|
|
ping = slack.__get__('ping');
|
|
|
|
beforeEach(function () {
|
|
isPostStub = sinon.stub(schema, 'isPost');
|
|
sinon.stub(urlService, 'getUrlByResourceId');
|
|
|
|
settingsCacheStub = sinon.stub(settingsCache, 'get');
|
|
sinon.spy(common.logging, 'error');
|
|
|
|
makeRequestStub = sinon.stub();
|
|
slackReset = slack.__set__('request', makeRequestStub);
|
|
makeRequestStub.resolves();
|
|
|
|
configUtils.set('url', 'http://myblog.com');
|
|
});
|
|
|
|
afterEach(function () {
|
|
slackReset();
|
|
});
|
|
|
|
it('makes a request for a post if url is provided', function () {
|
|
var requestUrl, requestData;
|
|
|
|
const post = testUtils.DataGenerator.forKnex.createPost({slug: 'webhook-test'});
|
|
urlService.getUrlByResourceId.withArgs(post.id, {absolute: true}).returns('http://myblog.com/' + post.slug + '/');
|
|
|
|
isPostStub.returns(true);
|
|
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
|
|
|
|
// execute code
|
|
ping(post);
|
|
|
|
// assertions
|
|
makeRequestStub.calledOnce.should.be.true();
|
|
isPostStub.calledTwice.should.be.true();
|
|
urlService.getUrlByResourceId.calledOnce.should.be.true();
|
|
settingsCacheStub.calledWith('slack').should.be.true();
|
|
|
|
requestUrl = makeRequestStub.firstCall.args[0];
|
|
requestData = JSON.parse(makeRequestStub.firstCall.args[1].body);
|
|
|
|
requestUrl.should.equal(slackObjWithUrl[0].url);
|
|
requestData.attachments[0].title.should.equal(post.title);
|
|
requestData.attachments[0].title_link.should.equal('http://myblog.com/webhook-test/');
|
|
requestData.attachments[0].fields[0].value.should.equal('## markdown.');
|
|
requestData.attachments[0].should.not.have.property('author_name');
|
|
requestData.icon_url.should.equal('http://myblog.com/favicon.ico');
|
|
requestData.username.should.equal('Ghost');
|
|
requestData.unfurl_links.should.equal(true);
|
|
});
|
|
|
|
it('makes a request for a message if url is provided', function () {
|
|
var requestUrl, requestData;
|
|
|
|
isPostStub.returns(false);
|
|
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
|
|
|
|
configUtils.set('url', 'https://myblog.com');
|
|
|
|
// execute code
|
|
ping({message: 'Hi!'});
|
|
|
|
// assertions
|
|
makeRequestStub.calledOnce.should.be.true();
|
|
isPostStub.calledTwice.should.be.true();
|
|
urlService.getUrlByResourceId.called.should.be.false();
|
|
settingsCacheStub.calledWith('slack').should.be.true();
|
|
|
|
requestUrl = makeRequestStub.firstCall.args[0];
|
|
requestData = JSON.parse(makeRequestStub.firstCall.args[1].body);
|
|
|
|
requestUrl.should.equal(slackObjWithUrl[0].url);
|
|
requestData.text.should.equal('Hi!');
|
|
requestData.icon_url.should.equal('https://myblog.com/favicon.ico');
|
|
requestData.username.should.equal('Ghost');
|
|
requestData.unfurl_links.should.equal(true);
|
|
});
|
|
|
|
it('makes a request and errors', function (done) {
|
|
makeRequestStub.rejects();
|
|
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
|
|
|
|
// execute code
|
|
ping({});
|
|
|
|
(function retry() {
|
|
if (common.logging.error.calledOnce) {
|
|
makeRequestStub.calledOnce.should.be.true();
|
|
return done();
|
|
}
|
|
|
|
setTimeout(retry, 50);
|
|
}());
|
|
});
|
|
|
|
it('does not make a request if post is a page', function () {
|
|
const post = testUtils.DataGenerator.forKnex.createPost({page: true});
|
|
isPostStub.returns(true);
|
|
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
|
|
|
|
// execute code
|
|
ping(post);
|
|
|
|
// assertions
|
|
makeRequestStub.calledOnce.should.be.false();
|
|
isPostStub.calledOnce.should.be.true();
|
|
urlService.getUrlByResourceId.calledOnce.should.be.true();
|
|
settingsCacheStub.calledWith('slack').should.be.true();
|
|
});
|
|
|
|
it('does not send webhook for \'welcome\' post', function () {
|
|
const post = testUtils.DataGenerator.forKnex.createPost({slug: 'welcome'});
|
|
isPostStub.returns(true);
|
|
settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);
|
|
|
|
// execute code
|
|
ping(post);
|
|
|
|
// assertions
|
|
makeRequestStub.calledOnce.should.be.false();
|
|
isPostStub.calledOnce.should.be.true();
|
|
urlService.getUrlByResourceId.calledOnce.should.be.true();
|
|
settingsCacheStub.calledWith('slack').should.be.true();
|
|
});
|
|
|
|
it('handles broken slack settings', function () {
|
|
const post = testUtils.DataGenerator.forKnex.createPost({slug: 'any'});
|
|
settingsCacheStub.withArgs('slack').returns();
|
|
|
|
// execute code
|
|
ping(post);
|
|
|
|
// assertions
|
|
makeRequestStub.calledOnce.should.be.false();
|
|
isPostStub.calledOnce.should.be.true();
|
|
urlService.getUrlByResourceId.called.should.be.false();
|
|
settingsCacheStub.calledWith('slack').should.be.true();
|
|
});
|
|
});
|
|
});
|