TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-25 09:03:12 +03:00
Code Issues Projects Releases Wiki Activity
3c3b3e6710
Ghost/ghost/admin/app
History
Kevin Ansfield 3c3b3e6710 Fixed infinite loop when lightening/darkening colors 
refs https://github.com/TryGhost/Team/issues/928
refs eed299d1f6

- usage of `color` was incorrect resulting in an infinite loop because the color was not being changed on each iteration
  - `Color().lightness()` adjusts via percentage not exact number
  - `Color().l()` does not return lightness
2021-07-28 19:10:26 +01:00
..
adapters Wired new membership tiers UI to API 2021-06-04 13:30:11 +05:30
authenticators Made session.user a synchronous property rather than a promise 2021-07-08 14:54:31 +01:00
components Displed special modal header for disabled email limit 2021-07-28 14:47:16 +04:00
controllers Moved adjusted accent color properties to ui service 2021-07-26 17:03:17 +01:00
errors Improved validation process for members CSV import 2020-07-07 00:28:30 +12:00
helpers Matched Portal's contrast threshold for white/black text on background color 2021-07-28 17:14:33 +01:00
initializers Bumped dependencies (Fixed production build) (#1091) 2019-01-08 12:36:16 +00:00
mixins Bumped eslint-plugin-ghost and fixed linter errors 2021-07-15 15:27:29 +01:00
models Renamed isAdmin/isOwner/isAdminOrOwner to reduce confusion 2021-07-12 14:55:56 +02:00
modifiers Update dependency ember-power-select to v4 (#1528) 2020-05-17 22:35:53 +01:00
routes Added first pass at feature image drag+drop uploading 2021-07-16 15:01:00 +01:00
serializers Handled visibility filter for posts 2021-07-05 17:14:26 +05:30
services Matched Portal's contrast threshold for white/black text on background color 2021-07-28 17:14:33 +01:00
session-stores Made session.user a synchronous property rather than a promise 2021-07-08 14:54:31 +01:00
styles Updated email CTA card in editor 2021-07-28 13:25:26 +02:00
templates Added CTA button display when not in edit mode 2021-07-26 21:17:10 +01:00
transforms Fixed transformer error when saving invalid twitter/facebook URLs 2021-07-14 15:24:17 +01:00
transitions Fixed autofocus not working on modal inputs 2018-06-04 17:48:57 +01:00
utils Fixed infinite loop when lightening/darkening colors 2021-07-28 19:10:26 +01:00
validators Updated copy for tiers 2021-07-19 12:39:59 +02:00
app.js Updated scheduling copy 2020-10-02 10:45:49 +02:00
index.html Fixed editor flex breakouts squashing sidebar in settings menu redesign 2021-06-23 13:54:40 +01:00
README.md Convert Sass to Myth 2015-05-22 19:05:09 +01:00
router.js Commented out temporarily unused products routes 2021-05-21 08:59:29 +01:00
transitions.js Removed tour feature 2021-03-02 14:29:26 +00:00

README.md

Ghost Admin Client

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)